From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75E72C3A59E for ; Sat, 24 Aug 2019 18:31:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4734321897 for ; Sat, 24 Aug 2019 18:31:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="slddJA8R"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="M2QXTWCI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4734321897 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GLsmPZnqGqzsUeUkF4ViWEMO+HBT/nbIR+0U1QIY9F8=; b=slddJA8Rg6lZc+ W5xu57xdENu8iMlMoe0L7R+1fdO2trnF/Np6S0It32EzBksbaEYQ5RU4U+gM0lduJYy5lQRTbTW9Z rF0LDJOiLzayn3D7u2eleTsXCasZtJH48KfeXa/mo4VkOJP0/VLRFQ1isjOinz7xQJpBK/T2TiRLT 0upe73ZXRKqqaNCDOWsDIFEDimIGOMn/OADRBYEv9a0uaN6aidKQv2eCYbJVyFPKml8qRdsqgrxW0 yG5TDYknugs3EhW/ROSg9HoL07qegbuz5fes5cM+Q3r4sOrXfJRtvMv9mISSfNnzGOSDqIdYV61Co wY5nveAuZaLhpTDsMqlw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i1aow-00087f-8O; Sat, 24 Aug 2019 18:31:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i1aos-00087L-Hg for linux-arm-kernel@lists.infradead.org; Sat, 24 Aug 2019 18:31:23 +0000 Received: from X250 (cm-84.211.118.175.getinternet.no [84.211.118.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E42B21897; Sat, 24 Aug 2019 18:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566671481; bh=DmSHzsJoUz62nz9KFHCqYK6dgiAFue8c2ZDdH9pdfK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M2QXTWCICjZPv5ZEEjocTVjyM1eAuZZ3ftM80JvvuhT4NKVpk5Jg22a5w8p1+0DDh JOznZRvPQ6/xi4yZUjy/WzTPwV1ALtOQP+3r75xC7IncNppOtnZ5fdQL+xtpea0Sz1 ZdMtyV0YApmDfm/u7EXdgNGBZkX1LECVOlTh6iUQ= Date: Sat, 24 Aug 2019 20:31:09 +0200 From: Shawn Guo To: Leonard Crestez Subject: Re: [PATCH] ARM: imx: Drop imx_anatop_init() Message-ID: <20190824183108.GA14936@X250> References: <20190731180131.8597-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190824_113122_608822_CD447072 X-CRM114-Status: GOOD ( 12.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-arm-kernel@lists.infradead.org" , Peter Chen , Andrey Smirnov , "linux-kernel@vger.kernel.org" , dl-linux-imx , Fabio Estevam , Aisheng Dong , Chris Healy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 22, 2019 at 05:33:13PM +0000, Leonard Crestez wrote: > On 31.07.2019 21:01, Andrey Smirnov wrote: > > With commit b5bbe2235361 ("usb: phy: mxs: Disable external charger > > detect in mxs_phy_hw_init()") in tree all of the necessary charger > > setup is done by the USB PHY driver which covers all of the affected > > i.MX6 SoCs. > > > > NOTE: Imx_anatop_init() was also called for i.MX7D, but looking at its > > datasheet it appears to have a different USB PHY IP block, so > > executing i.MX6 charger disable configuration seems unnecessary. > > > > -void __init imx_anatop_init(void) > > -{ > > - anatop = syscon_regmap_lookup_by_compatible("fsl,imx6q-anatop"); > > - if (IS_ERR(anatop)) { > > - pr_err("%s: failed to find imx6q-anatop regmap!\n", __func__); > > - return; > > - } > > This patch breaks suspend on imx6 in linux-next because the "anatop" > regmap is no longer initialized. This was found via bisect but > no_console_suspend prints a helpful stack anyway: > > (regmap_read) from [] (imx_anatop_enable_weak2p5+0x28/0x70) > (imx_anatop_enable_weak2p5) from [] > (imx_anatop_pre_suspend+0x18/0x64) > (imx_anatop_pre_suspend) from [] (imx6q_pm_enter+0x60/0x16c) > (imx6q_pm_enter) from [] (suspend_devices_and_enter+0x7d4/0xcbc) > (suspend_devices_and_enter) from [] (pm_suspend+0x7b8/0x904) > (pm_suspend) from [] (state_store+0x68/0xc8) I dropped it from my branch for now. Thanks for reporting! Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel