From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B53E8C3A59F for ; Mon, 26 Aug 2019 13:07:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89B54217F5 for ; Mon, 26 Aug 2019 13:07:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tOF7f+fB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="VRHBnQud" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89B54217F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ti1EzEpCRAH3d8mlIh0hD4yQ9MduT7avRag2jh/inJU=; b=tOF7f+fB6n+4kR CLSlxuydBk1kW/5X22CpJaFqEKPIC6iBdqpeyUFnT1rL1a6qyU6DZYm7IHO77NAZ7kZvxAw25Unnq Nzex4Vd4iCqYarhtyRVF7N6HILiCDCp+jshClslMtwsG/RV4g6U1sr6uyiQyoOtI4u0p2Mpy2jGdT qJ1A1s3EsBevt+Xwhpmh11pD7y0OCcibnuOaL8mhUN6JFAEF4ImQE12qxKDJhsEAuv6upT/cwUKyX G82nU+Eka9Wju9r6K+TtLETzP5SMW3r0wl0ASJBxtNrQtKse6CAQ0rpr5RyjJyycZMy6Wc4Xob7xu FJoZDsEhBMKbrOkk2guA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2Ehm-0000bK-RU; Mon, 26 Aug 2019 13:06:42 +0000 Received: from userp2130.oracle.com ([156.151.31.86]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2Ehh-0007Kt-MJ for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2019 13:06:39 +0000 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7QD4BNI089364; Mon, 26 Aug 2019 13:04:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=vJnEs/zVB+9mS41wRVHEaFY5nc+m3Axz/YoiQ2okbtI=; b=VRHBnQudsig8Q5m9ZDhcs/dKeMXUikug+wfXXpZuj8XzIYHUR7QZV7KcdlFbHep6i8Dw Cp9h5qptKM8jLJ/V6tMGij4q2WpRO0jhUNNrUPum5Sz+sz55PTuy+znsSDS5gL4GZXKj V/+NTrqoaPO+PwF/cSim6/Q1bjJ5CgNx0JDEFnhNcDw3ZrRONmyO/zuJerRUWlaGHWrU B071FxmRqImNAxsxR9aj/kN0FzMVYGu/Wbc9pFFjelr6KEWLHzu8rY4KqcgGQ/czQvdm llyzjznMReoPW+Bq3sGbu8C5puWsXu+shjSzLxSyfj9mAN7wW9qtBp9pUckgsCD8EzNO IA== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2ujw718x0c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Aug 2019 13:04:22 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7QD49P3095525; Mon, 26 Aug 2019 13:04:22 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2ujw6htgtp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Aug 2019 13:04:22 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x7QD3tS1016179; Mon, 26 Aug 2019 13:03:55 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 26 Aug 2019 06:03:54 -0700 Date: Mon, 26 Aug 2019 16:03:44 +0300 From: Dan Carpenter To: Wei Yongjun Subject: Re: [PATCH -next] mmc: aspeed: Fix return value check in aspeed_sdc_probe() Message-ID: <20190826130343.GA23584@kadam> References: <20190826120013.183435-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190826120013.183435-1-weiyongjun1@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9360 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908260142 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9360 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908260142 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190826_060637_857150_131568A3 X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-aspeed@lists.ozlabs.org, Andrew Jeffery , kernel-janitors@vger.kernel.org, linux-mmc@vger.kernel.org, Adrian Hunter , Joel Stanley , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Fixes: 09eed7fffd33 ("mmc: Add support for the ASPEED SD controller") ^^^^ When we're adding new files, could we use the prefix for the new driver instead of just the subsystem? "mmc: aspeed: Add new driver"? Otherwise it's tricky to know what people want for the driver. I just wrote this same patch and I swear I would have sent my patch earlier but I spent hours thinking about the patch prefix and then the census people came to the house and delayed me even more. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel