From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF828C3A59F for ; Mon, 26 Aug 2019 18:56:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C85E52070B for ; Mon, 26 Aug 2019 18:56:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W/SjbYC4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C85E52070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ehyScEyVkIRPaZxDGUBiH5NW1FZkBqEjS02/pk4bN/Y=; b=W/SjbYC4xyhC96 UDRyfee60CwqiFKrorG6Zb08vj0y5W/sQHfjccpCj27wcQtK+1mq5nTq5w6K6dgIB+W/cudv0Ta2c 2Fh24KleyAwzviG7rtLn84YRDkk/SEV1eoDPHn9n2gkXqtfB24G+eitOAX1cI4CYBB/fDDFUvktcz 6aimztL9sis+PGQogL7hk5Kd9TuUdPPmaItdnYd3rsgOjegR7rrB0qkI+4gjD56gVK7Evk8fVavb1 UZvI7FttDDvHh2SfJHIzzE8Udyfrx2TRMYkXl8Cs98k+QouEanKDfMTO5hbXMq63+S7sdBHdzo/PK LdQVOnDHOH9QTniOYfsQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2K9j-00054Y-Dq; Mon, 26 Aug 2019 18:55:55 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2K9g-00054B-ER for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2019 18:55:53 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 7F21228A165; Mon, 26 Aug 2019 19:55:50 +0100 (BST) Date: Mon, 26 Aug 2019 20:55:47 +0200 From: Boris Brezillon To: Jernej Skrabec Subject: Re: [PATCH 8/8] media: cedrus: Add support for V4L2_DEC_CMD_FLUSH Message-ID: <20190826205547.3ecbf2a1@collabora.com> In-Reply-To: <20190822194500.2071-9-jernej.skrabec@siol.net> References: <20190822194500.2071-1-jernej.skrabec@siol.net> <20190822194500.2071-9-jernej.skrabec@siol.net> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190826_115552_618975_87B63D1B X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, acourbot@chromium.org, pawel@osciak.com, jonas@kwiboo.se, gregkh@linuxfoundation.org, wens@csie.org, mripard@kernel.org, tfiga@chromium.org, paul.kocialkowski@bootlin.com, kyungmin.park@samsung.com, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, hverkuil-cisco@xs4all.nl, mchehab@kernel.org, ezequiel@collabora.com, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 22 Aug 2019 21:45:00 +0200 Jernej Skrabec wrote: > This command is useful for explicitly flushing last decoded frame. > > Signed-off-by: Jernej Skrabec Reviewed-by: Boris Brezillon > --- > .../staging/media/sunxi/cedrus/cedrus_video.c | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c > index 5153b2bba21e..9eae69d5741c 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c > @@ -331,6 +331,37 @@ static int cedrus_s_fmt_vid_out(struct file *file, void *priv, > return 0; > } > > +static int cedrus_try_decoder_cmd(struct file *file, void *fh, > + struct v4l2_decoder_cmd *dc) > +{ > + if (dc->cmd != V4L2_DEC_CMD_FLUSH) > + return -EINVAL; > + > + return 0; > +} > + > +static int cedrus_decoder_cmd(struct file *file, void *fh, > + struct v4l2_decoder_cmd *dc) > +{ > + struct cedrus_ctx *ctx = cedrus_file2ctx(file); > + struct vb2_v4l2_buffer *out_vb, *cap_vb; > + int ret; > + > + ret = cedrus_try_decoder_cmd(file, fh, dc); > + if (ret < 0) > + return ret; Not directly related to this patch, but it seems most drivers implementing ->vdioc_decoder_cmd() call ->vidioc_try_decoder_cmd() internally to make sure the cmd is supported. Maybe something we could automate at the v4l2-ioctl.c level. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel