From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C35DC3A5A3 for ; Tue, 27 Aug 2019 07:01:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F167206BF for ; Tue, 27 Aug 2019 07:01:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jOf6/7YN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hgQhsTQ0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F167206BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FEm9YuELlRTnnRZWUwFEZ+rVvjtxdXBvyvsM7P0F7I4=; b=jOf6/7YN04cmrnQ6BCodROneH NiNpwQxnhtkJ3OleNFIYL9lJ534+l1UFHAAccvv8v0KZV/2+vc5YK+4honMsQhqUsh3CphRXwgVSj jm7aSN7x+gFfFJSuXdRuzaaYcMbO60+ah9buN1n8FuhHSG70JzeZUxOf4W+K6XslHmNOp3SWSsyAI X6gVuAzm2cTBBtYEK51jY8RAkgPL6P9HyQXKE5OC562xg775GeMtf5OHCrFR78WUX2BLoYXYBXMEi zmkXTFa3nFdVAwUqj1XgTjn9migNsArAsknMtZoiPAck+nAJ0+NKot1d0xhkcyusswX++b3/jw8Yf Fm3Crln8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2VTb-00063j-7J; Tue, 27 Aug 2019 07:01:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2VTW-000634-E5 for linux-arm-kernel@lists.infradead.org; Tue, 27 Aug 2019 07:01:08 +0000 Received: from localhost (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C88C1206BF; Tue, 27 Aug 2019 07:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566889264; bh=Biq9mF8dTT+XjGplKumTdtUTNHz0ImKVfvD7CkyAwj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hgQhsTQ0uGStkRN08ze0pp7gYCNZAgjNr980p+jcVF5VXiEywouzHu1X/QaioYG7h pCwT9TmFUF4jd97IjGFMlF+qXHiYfnmwMA/XS1uzU8+t2GJf5VfqFsV2wMcd3tXQ08 RHKJsMf0efsZ6ws16aWkFS5lZ0ADFggxZxhDxI0I= Date: Tue, 27 Aug 2019 09:01:01 +0200 From: Maxime Ripard To: codekipper@gmail.com Subject: Re: [PATCH v6 3/3] ASoC: sun4i-i2s: Adjust LRCLK width Message-ID: <20190827070101.tastgcqvzrgv3kc5@flea> References: <20190826180734.15801-1-codekipper@gmail.com> <20190826180734.15801-4-codekipper@gmail.com> MIME-Version: 1.0 In-Reply-To: <20190826180734.15801-4-codekipper@gmail.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190827_000106_774721_2F460CB1 X-CRM114-Status: GOOD ( 14.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, be17068@iperbole.bo.it, wens@csie.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7447450928998448507==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7447450928998448507== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aewobl2wvpczcoyt" Content-Disposition: inline --aewobl2wvpczcoyt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 26, 2019 at 08:07:34PM +0200, codekipper@gmail.com wrote: > From: Marcus Cooper > > Some codecs such as i2s based HDMI audio and the Pine64 DAC require > a different amount of bit clocks per frame than what is calculated > by the sample width. Use the values obtained by the tdm slot bindings > to adjust the LRCLK width accordingly. > > Signed-off-by: Marcus Cooper > --- > sound/soc/sunxi/sun4i-i2s.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c > index 056a299c03fb..0965a97c96e5 100644 > --- a/sound/soc/sunxi/sun4i-i2s.c > +++ b/sound/soc/sunxi/sun4i-i2s.c > @@ -455,7 +455,10 @@ static int sun8i_i2s_set_chan_cfg(const struct sun4i_i2s *i2s, > break; > > case SND_SOC_DAIFMT_I2S: > - lrck_period = params_physical_width(params); > + if (i2s->slot_width) > + lrck_period = i2s->slot_width; > + else > + lrck_period = params_physical_width(params); > break; That would be the case with the DSP formats too, right? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --aewobl2wvpczcoyt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXWTVLQAKCRDj7w1vZxhR xSAlAQCvR8zoBbzxDhfl4BOVHlf7M+d/VwTWUWIndBN6/bMNDAD+KSWSTL9rCbyM 5aTcKxbY8Hi2H/ljbFggOIAykqgEnQI= =88rE -----END PGP SIGNATURE----- --aewobl2wvpczcoyt-- --===============7447450928998448507== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7447450928998448507==--