From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92E3BC3A5A3 for ; Tue, 27 Aug 2019 09:35:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 600A42186A for ; Tue, 27 Aug 2019 09:35:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DTC04pth"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="IBElxmoU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 600A42186A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w94Kd2AifC9QELlO+p+HA9WMqhJ5mvrezARy7J4ExnM=; b=DTC04pthiFsUFmVo9VrZOisHx 5/SWqq7K0/l7FBdj2ZHM+k9kvYE0xdCULkNcr9WHGXrLCLo29A1VXGcBuSm9UJZ+F1TE4mYzyByav 5xjvbsdVIlsnU5yqTpzqtABm3WKdsYV6zNu87pzx0823lYhs9XDkch0O9uTJfRqdCFSqkp2HeSLjV lXt35yb7qC7qrFIEMSd4K67LlvwsikEnf0R7V6d168N6cWNaVFVFJto8ALjEMA52Gxk2ViIO5tA35 tUYsnpsiBTj8ydmTNY00fYrmzOyc6xGvhflGp7Rbhgw6W5cFKUl318pJA9s54Gry7A3CX4y/BPEGz 5pE2U0EsQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2Xt8-0008Ew-Ny; Tue, 27 Aug 2019 09:35:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2Xt5-0008EZ-6E for linux-arm-kernel@lists.infradead.org; Tue, 27 Aug 2019 09:35:40 +0000 Received: from localhost (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C22D2186A; Tue, 27 Aug 2019 09:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566898538; bh=QwBJ6oW0mDUbmXmBZq/xOiSb0AoEWSa+i67Fo2EQs3E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IBElxmoUKNRUm9l3uA8x2MyS+ZMpfcJG5jPMcXf/AbP8WeAt4AK0moq7YYtVCyMi3 +WABBe3yhR0HqCC4213+rKtjpwTL8ALAwhzGjnw5yiBdZrBXKUzg70rj1OhmcRmOM1 SBZPITCAS7sME54Y/kLDWZ6+0EI5Yz4Kn9JxqPu4= Date: Tue, 27 Aug 2019 11:35:36 +0200 From: Maxime Ripard To: Chen-Yu Tsai Subject: Re: [PATCH 00/21] ASoC: sun4i-i2s: Number of fixes and TDM Support Message-ID: <20190827093536.rl6fjuvctjwd33as@flea> References: MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190827_023539_267905_DA3E7243 X-CRM114-Status: GOOD ( 20.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-ALSA , Liam Girdwood , linux-kernel , Code Kipper , Mark Brown , linux-arm-kernel Content-Type: multipart/mixed; boundary="===============3503150571234465844==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3503150571234465844== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zfutohgftfydg3jy" Content-Disposition: inline --zfutohgftfydg3jy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Tue, Aug 27, 2019 at 04:20:24PM +0800, Chen-Yu Tsai wrote: > Hi everyone, > > On Tue, Aug 20, 2019 at 3:25 AM Maxime Ripard wrote: > > > > From: Maxime Ripard > > > > Hi, > > > > This series aims at fixing a number of issues in the current i2s driver, > > mostly related to the i2s master support and the A83t support. It also uses > > that occasion to cleanup a few things and simplify the driver. Finally, it > > builds on those fixes and cleanups to introduce TDM and DSP formats support. > > > > Let me know what you think, > > Maxime > > > > Marcus Cooper (1): > > ASoC: sun4i-i2s: Fix the MCLK and BCLK dividers on newer SoCs > > > > Maxime Ripard (20): > > ASoC: sun4i-i2s: Register regmap and PCM before our component > > ASoC: sun4i-i2s: Switch to devm for PCM register > > ASoC: sun4i-i2s: Replace call to params_channels by local variable > > ASoC: sun4i-i2s: Move the channel configuration to a callback > > ASoC: sun4i-i2s: Move the format configuration to a callback > > ASoC: sun4i-i2s: Rework MCLK divider calculation > > ASoC: sun4i-i2s: Don't use the oversample to calculate BCLK > > ASoC: sun4i-i2s: Use module clock as BCLK parent on newer SoCs > > ASoC: sun4i-i2s: RX and TX counter registers are swapped > > ASoC: sun4i-i2s: Use the actual format width instead of an hardcoded one > > ASoC: sun4i-i2s: Fix LRCK and BCLK polarity offsets on newer SoCs > > ASoC: sun4i-i2s: Fix the LRCK polarity > > ASoC: sun4i-i2s: Fix WSS and SR fields for the A83t > > ASoC: sun4i-i2s: Fix MCLK Enable bit offset on A83t > > ASoC: sun4i-i2s: Fix the LRCK period on A83t > > ASoC: sun4i-i2s: Remove duplicated quirks structure > > Unfortunately the patches that "fix" support on the A83T actually break it. > The confusion stems from the user manual not actually documenting the I2S > controller. Instead it documents the TDM controller, which is very similar > or the same as the I2S controller in the H3. The I2S controller that we > actually support in this driver is not the TDM controller, but three other > I2S controllers that are only mentioned in the memory map. Support for this > was done by referencing the BSP kernel, which has separate driver instances > for each controller instance, both I2S and TDM. > > Now to remedy this I could send reverts for all the "A83t" patches, and > fixes for all the others that affect the A83t quirks. However the fixes > tags existing in the tree would be wrong and confusing. That might be a > pain for the stable kernel maintainers. > > Any suggestions on how to proceed? I've just sent two patches to address that (adding a comment in the process so that hopefully it doesn't happen again). Let me know if it works, and sorry for the mess :/ Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --zfutohgftfydg3jy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXWT5aAAKCRDj7w1vZxhR xdWcAP92UC8ohpBC1hEZ+YE9YtL68wqEMKjjgaiRbBPuMCI9tQEAvzYPAtyZtF9A o8AofY1070asyuWTmZNoBs4WWZOnHQ4= =P/nX -----END PGP SIGNATURE----- --zfutohgftfydg3jy-- --===============3503150571234465844== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3503150571234465844==--