From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38F53C3A5A3 for ; Tue, 27 Aug 2019 16:05:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D40A2173E for ; Tue, 27 Aug 2019 16:05:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IgQidKm9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D40A2173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vArwNg+MWh0LvwOddgMGPW+ME4jedmH9EHJenjeIB88=; b=IgQidKm9hAyxi6 k5BZaMhby5YrKVcSSfMTECekfGkwgOWMtHoGllYjrGlDyHES6+e4Vy6I/KNIpnTty6vU48VBqsIn2 gh3h0s2glsvWWKI8cY7QYnqrQzU4BCt1lDWioIx9tkfkA9JYjsh4nKC+xMNj6arfCDT7Y8wN0DbkL z6bCzn0mbIQXTVExAtuACsAGXTjusGEHD5jqQYm9gAW/BySuBYspXp8MK7mlOpGvI7YlOYUyDSxQr B5u8WuBLQlgva0poQHPG8MsFnbmCw7IacRcmDZ5Ml7JhzF60j/rEdZ7pk9R0miHkjOKZoc3wAA4pI LlYGXcYFonNjDbAhBEyQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2dyb-0001pu-N1; Tue, 27 Aug 2019 16:05:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2dyY-0001mJ-W0 for linux-arm-kernel@lists.infradead.org; Tue, 27 Aug 2019 16:05:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7D79E337; Tue, 27 Aug 2019 09:05:42 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E70B33F59C; Tue, 27 Aug 2019 09:05:41 -0700 (PDT) Date: Tue, 27 Aug 2019 17:05:39 +0100 From: Mark Rutland To: Will Deacon Subject: Re: [PATCH 1/3] arm64: smp: Increase secondary CPU boot timeout value Message-ID: <20190827160539.GD43183@lakrids.cambridge.arm.com> References: <20190827151815.2160-1-will@kernel.org> <20190827151815.2160-2-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190827151815.2160-2-will@kernel.org> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190827_090543_069606_56B4B451 X-CRM114-Status: GOOD ( 16.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 27, 2019 at 04:18:13PM +0100, Will Deacon wrote: > When many debug options are enabled simultaneously (e.g. PROVE_LOCKING, > KMEMLEAK, DEBUG_PAGE_ALLOC, KASAN etc), it is possible for us to timeout > when attempting to boot a secondary CPU and give up. Unfortunately, the > CPU will /eventually/ appear, and sit in the background happily stuck > in a recursive exception due to a NULL stack pointer. > > Increase the timeout to 5s, which will of course be enough for anybody. > > Signed-off-by: Will Deacon Reviewed-by: Mark Rutland Thanks, Mark. > --- > arch/arm64/kernel/smp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > index 018a33e01b0e..63c7a7682e93 100644 > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -123,7 +123,7 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle) > * time out. > */ > wait_for_completion_timeout(&cpu_running, > - msecs_to_jiffies(1000)); > + msecs_to_jiffies(5000)); > > if (!cpu_online(cpu)) { > pr_crit("CPU%u: failed to come online\n", cpu); > -- > 2.11.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel