From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5761C3A5A3 for ; Tue, 27 Aug 2019 17:22:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86AC8214DA for ; Tue, 27 Aug 2019 17:22:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bjxv3syL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Iauj4YMD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86AC8214DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vvvm9DnXDY07muvHKpTsSFZaSKKVryX3eadATGvdGhw=; b=bjxv3syLso54z0 0NubhaPvGzDhhoJw88IUL1vXprbVwd7MsI0dz64dj6ITqlyjp/0aU5hnicdBJ5XtEcFvk4TfSV0Vm etXydDWfFdONNSoKMOdT1xa043UNmLct35RFKgNKOLwZ3p8zTUW1jZmkHKl+MutyP7ebwzP0MEFbV O6UYyq1hGrRgwtFnigM+SRckfCirVlGgAxbvmRUHJ3sy1VEuscHfr15Xmj/M6YZpmfmMHYXOsYOK0 +2rS+ziMfEWEiss3BqM8CnEYgxPod1RoWX+hGd2J54kiiv8ZJR5Nk0acps+HcbsB76/TGM4lfMdl0 ZetIPe85GR79IIHtO+lA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2fAL-0003yj-KT; Tue, 27 Aug 2019 17:21:57 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2fAI-0003xx-Ev for linux-arm-kernel@lists.infradead.org; Tue, 27 Aug 2019 17:21:55 +0000 Received: by mail-pg1-x541.google.com with SMTP id l21so13047351pgm.3 for ; Tue, 27 Aug 2019 10:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zRigP/msiQiDSPdu4zbzx+Q8x/ih7vzlwsY6a8Wz66s=; b=Iauj4YMDxlI7eSu/g9BPoFQBxpnhpWIfR4fBeRCtD1F+hz08fDxiccP5oYfoAH7en3 bTcbEs/SFVl9UkpYreup9INiGKmMuerTPULnaBtTUygkNG0nbaoMSyflf3ERPTRpMLSP VVfD+4qV6SHX/L8+KcYbfan27OAC0eVHgWPrr/r0ugUUblmgOSBvN3t+cz0PmxOiN277 /+gewSrztdybZcF91zFblvsW6WTD/D8pBvNHBm5DD8inJL4925TLHvKitxges+MpkKYc rwXDYio+g1DLNHBP7uCu8EKOZZXsGRXU1BcmPBdX4Q+FJZwICl99e6kCKvcIJY5YU3qd Rtbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=zRigP/msiQiDSPdu4zbzx+Q8x/ih7vzlwsY6a8Wz66s=; b=shqnvP1y88nn1l2M14AF42fQ9loU1+i0GqrLF7ahzZ/MR1q8aTiKgfz1i6x8i2IDZd AL2/MlhEM/Qf+uTjW2Cb9JZN1CYu8kP/GpzO5krNjSWSWZ46b5dmrGt3og1S327zK6k9 MPvh0PeKldwErTk0/noE0+tLlq60eXC+BbfKLR1O5Z0Uh0Vlql9dGK+JHY4aMWSTQI9x dohziSsT4cb1C60VWoG9vO3AozfCCQQJsTgL9UN1pPd/sloRuDEBM5xe4ra65++Noya+ HV/cCzwvL9uf896ZsNOpVJ+xqVm0OjI1ahUkSPDmr3IUrVNUPIPxQASc6/ObNcsDRBEo Yj5Q== X-Gm-Message-State: APjAAAWl8tTN8BzRjJx+GnO27NWWh6kUv0Ui0Z1htt1DkCEmB2LC+bcL BZvDMDi6n7cL0Kve4hfWk4E= X-Google-Smtp-Source: APXvYqyKRhppJ/qA2UBq6ZMaVWHjlMRhLmiVaZLdW9FTrJ4pwB3mo84sMTVDrIA1/lMdfAUIYt8F0A== X-Received: by 2002:a62:4ed1:: with SMTP id c200mr27207401pfb.218.1566926513664; Tue, 27 Aug 2019 10:21:53 -0700 (PDT) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by smtp.gmail.com with ESMTPSA id 6sm15692223pfa.7.2019.08.27.10.21.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Aug 2019 10:21:53 -0700 (PDT) Date: Tue, 27 Aug 2019 10:21:52 -0700 From: Guenter Roeck To: Ivan Mikhaylov Subject: Re: [PATCH v3 3/4] watchdog/aspeed: add support for dual boot Message-ID: <20190827172151.GA31588@roeck-us.net> References: <20190827165426.17037-1-i.mikhaylov@yadro.com> <20190827165426.17037-4-i.mikhaylov@yadro.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190827165426.17037-4-i.mikhaylov@yadro.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190827_102154_524326_14ACC0CD X-CRM114-Status: GOOD ( 11.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Andrew Jeffery , openbmc@lists.ozlabs.org, Alexander Amelkin , linux-kernel@vger.kernel.org, Rob Herring , Joel Stanley , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 27, 2019 at 07:54:25PM +0300, Ivan Mikhaylov wrote: > Set WDT_CLEAR_TIMEOUT_AND_BOOT_CODE_SELECTION into WDT_CLEAR_TIMEOUT_STATUS > to clear out boot code source and re-enable access to the primary SPI flash > chip while booted via wdt2 from the alternate chip. > > AST2400 datasheet says: > "In the 2nd flash booting mode, all the address mapping to CS0# would be > re-directed to CS1#. And CS0# is not accessable under this mode. To access > CS0#, firmware should clear the 2nd boot mode register in the WDT2 status > register WDT30.bit[1]." > > Signed-off-by: Ivan Mikhaylov Please run "checkpatch --strict" on this patch and fix the reported problems (I _did_ ask for proper multi-line aligment before, but there are a couple of other issues as well). Thanks, Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel