From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD69C3A5A3 for ; Tue, 27 Aug 2019 23:11:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 818D220856 for ; Tue, 27 Aug 2019 23:11:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V+c0xG5Z"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZRFwTS1r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 818D220856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SluPMS7l2jRag/1DvX4pAxsgiA5fitE/fSD/+qcwBTk=; b=V+c0xG5ZovQ9S5 wCEPb52feOmq90oNZKNmT/GQisVcKV1vWdzazvnW6Zvs45MWBHVWkF+3/4DPFBIIjvJQh8l2imIoe IZGcpU5Mg9G5yPcdOA+qbwgxDQlgFDyEsm7hiHBRr+feUy1pjMpQGmy879ENtkjXhLgIN1uiIwU7z IJdh+0ieuGYVJew4+Vcs2FDBR9iCGUR7aSxlUstQ/uRtWJ40Cnv9B+v2wAPEsAg1nPH3KhxSOwGmr APK+YZ7nNrSzunlV1sf9YQj3uwIVLXPz7luUA1yXwDgTo1RPOjoLtF5MyE9hotn6yPQAFUzwoBqLM zsp2uyvZMJLHrtia3J8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2kcp-0001cE-OF; Tue, 27 Aug 2019 23:11:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2kch-0001az-14; Tue, 27 Aug 2019 23:11:42 +0000 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6EECF20856; Tue, 27 Aug 2019 23:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566947494; bh=aNlA/MApouOcwf72/8GMSwuzsBqyO6Sp9x6HCpSXgGk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZRFwTS1rqTxwj2gvps8jYXhfiuL5Eq3hUd/q4PyouqcIke/YpvR0yEqCnHJpG0oBG q+uh2ZEibfyAH/G5ndZQGkinr8VnwC95MliB678A5+UIXUovp7a4j0ytcyqog3dgIl 8jeD5gpDNVsUfsxolJbYrmZuu7z9XbuEg9x+Ts0Y= Date: Tue, 27 Aug 2019 18:11:33 -0500 From: Bjorn Helgaas To: Krzysztof Wilczynski Subject: Re: [PATCH] PCI: mediatek: Remove surplus return from a void function Message-ID: <20190827231133.GG9987@google.com> References: <20190825221039.6977-1-kw@linux.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190825221039.6977-1-kw@linux.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190827_161140_874590_8DE5D0C2 X-CRM114-Status: GOOD ( 13.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Ryder Lee , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 26, 2019 at 12:10:39AM +0200, Krzysztof Wilczynski wrote: > Remove unnecessary empty return statement at the > end of a void function mtk_pcie_intr_handler() in > the drivers/pci/controller/pcie-mediatek.c. > > The surplus return statement was added as part of > the work in commit 42fe2f91b4eb ("PCI: mediatek: > Implement chained IRQ handling setup"). > > Signed-off-by: Krzysztof Wilczynski I squashed this together with the other patch doing the same thing. If it causes any conflict with Lorenzo's branches, I'll resolve it when merging. > --- > drivers/pci/controller/pcie-mediatek.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c > index 3eaa7081ab2a..626a7c352dfd 100644 > --- a/drivers/pci/controller/pcie-mediatek.c > +++ b/drivers/pci/controller/pcie-mediatek.c > @@ -635,8 +635,6 @@ static void mtk_pcie_intr_handler(struct irq_desc *desc) > } > > chained_irq_exit(irqchip, desc); > - > - return; > } > > static int mtk_pcie_setup_irq(struct mtk_pcie_port *port, > -- > 2.22.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel