From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 612FAC3A5A1 for ; Wed, 28 Aug 2019 04:01:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 337F7217F5 for ; Wed, 28 Aug 2019 04:01:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R92nI1KO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Lm4ahhT+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 337F7217F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KnmppEwho1ZVF6/iEHohYLoWXinENoBO3cu6On+MWtI=; b=R92nI1KODSVJ/c wACbJemUd4zcmxuJ7cnQPEEaXIQQENx4FFvVTLz+SBmIkugmizST56gqj/9EINSuVh66Mm+GZ/j8O TKYgW94yolYktTp4nTBHgQB2yPbv2I0HmtyDzemjXM7KgGOmQk+2bic61yRboQ+bgrvvpfTOUfUnx +5Vq/6ru9EnUP2FCEpr4dOchGPWPxZuHskcLLC3HxJZnnvXrz0lQi0aNBz7sq8m94QUn/Gfp4pdVX 5/6rNufbQcm65qxwhnTd+1T2XJwM2aYiDLbuNsccdDvSIYuXtA032eIPhp1CsOMTbF7PXzCoTIWr0 ZINXaXDZXmDmcaI4N1jA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2p8w-0006ru-S3; Wed, 28 Aug 2019 04:01:10 +0000 Received: from mail-yw1-xc41.google.com ([2607:f8b0:4864:20::c41]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2p8t-0006pJ-Ko for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2019 04:01:09 +0000 Received: by mail-yw1-xc41.google.com with SMTP id n11so327109ywn.6 for ; Tue, 27 Aug 2019 21:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=g4EYW4YY3/AavRz5P4dr9epsF4kvApj/bXuAeLB5HCo=; b=Lm4ahhT+WgyH1SaeZ1SC8GfdXFFKOeKbv6eLE4GXfFbMp0hFX/8FKmsEL78jQ3f2IA slimxZixlcJjsCYutB+34t2lxE+5Or0cuYy4Lj1vRgTfY75dr07cEqMIVvYsy/sbHSLm SoIws1VN4TgGb+Mrp/QdoBRVkPjYTwusjkZZx/dtX7Potgsfv56i6GrqtJRlYOLTRt93 xMSKN/J3tsSacxehrSIS63wJ0ATVN4z7SqsAxw7D6ekESl4G6OJlu28F4H7raGHbfQix CKMSv+jpAwauRBbSx9l3bdMEjcR/3uKqPOHpT23l4nr+tNvCcH4bDfc3AeDfWDPV94Fn Gq6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=g4EYW4YY3/AavRz5P4dr9epsF4kvApj/bXuAeLB5HCo=; b=KjmI0zLgJES06gtM7kXyQBSJG9IEPazOrK131hOTM5DK4D12cBuduGOWG+oyPuwAx/ ECB3ekLmgkYcTRxbkEtiII3kVfOF7a1b7u0HRF/fx7tK+3sH+MmfTnnj6VX5QbcJVw7m ViMLradpLwoYve0JM/kOIARkugY1rcDSNyfvz0hk6IxJPFEqkfCaF3TsqKnBi2AAAnwS 21ioZL+c68R5ikGqoGE/6eHyIuLMJZ0AWkwN0LVkQAmlpH4MoX+jTfr3TwB0qt90yxEy EBoYGD8ML61PObWmkwG8aX0nTC/h+efA4EGxbV/+8j3SXze/vtHMoJSMvcXTyP3Wa1Bw 8fiw== X-Gm-Message-State: APjAAAWke85W9E8kD232OrkRJvHT/OLm35Ng/cc78E/EqBkG2b/r8KqM Es3cYPpPw74FMc45c281wohbjsd41Y3b8A== X-Google-Smtp-Source: APXvYqzVOrqKEfMMYHhXY39byA9nyim3UaQDAXcZxrbtUh1An3yYncGj2kdk4/P8g7S60iYQTeQ4/Q== X-Received: by 2002:a81:5245:: with SMTP id g66mr1648942ywb.396.1566964862977; Tue, 27 Aug 2019 21:01:02 -0700 (PDT) Received: from leoy-ThinkPad-X240s (li1320-244.members.linode.com. [45.79.221.244]) by smtp.gmail.com with ESMTPSA id v203sm266018ywa.99.2019.08.27.21.00.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Aug 2019 21:01:02 -0700 (PDT) Date: Wed, 28 Aug 2019 12:00:55 +0800 From: Leo Yan To: Mike Leach Subject: Re: [PATCH 6/8] coresight: etm4x: Add view comparator settings API to sysfs. Message-ID: <20190828040055.GF26133@leoy-ThinkPad-X240s> References: <20190819205720.24457-1-mike.leach@linaro.org> <20190819205720.24457-7-mike.leach@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190819205720.24457-7-mike.leach@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190827_210107_694887_D6AD7765 X-CRM114-Status: GOOD ( 23.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, mathieu.poirier@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mike, On Mon, Aug 19, 2019 at 09:57:18PM +0100, Mike Leach wrote: > Currently it is not possible to view the current settings of a given > address comparator without knowing what type it is set to. For example, if > a comparator is set as an addr_start comparator, attempting to read > addr_stop for the same index will result in an error. > > addr_cmp_view is added to allow the user to see the current settings of > the indexed address comparator without resorting to trail and error when > the set type is not known. > > Signed-off-by: Mike Leach > --- > .../coresight/coresight-etm4x-sysfs.c | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > index baac5b48b7ac..483976074779 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > @@ -1272,6 +1272,56 @@ static ssize_t addr_exlevel_s_ns_store(struct device *dev, > } > static DEVICE_ATTR_RW(addr_exlevel_s_ns); > > +static const char * const addr_type_names[] = { > + "unused", > + "single", > + "range", > + "start", > + "stop" > +}; > + > +static ssize_t addr_cmp_view_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + u8 idx, addr_type; > + unsigned long addr_v, addr_v2, addr_ctrl; Some nitpicks, if you disagree, just ignore them :) nitpicks: maybe we can use 'addr_v1' and 'addr_v2', we even can use 'addr_l' and 'addr_h'. > + struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); > + struct etmv4_config *config = &drvdata->config; > + int size = 0; > + bool exclude = false; > + > + spin_lock(&drvdata->spinlock); > + idx = config->addr_idx; > + addr_v = config->addr_val[idx]; > + addr_ctrl = config->addr_acc[idx]; > + addr_type = config->addr_type[idx]; > + if (addr_type == ETM_ADDR_TYPE_RANGE) { > + if (idx%2) { if (idx & 0x1) > + idx -= 1; > + addr_v2 = addr_v; > + addr_v = config->addr_val[idx]; > + } else > + addr_v2 = config->addr_val[idx+1]; The code style doc [1] suggests to use braces for 'else' as well. > + exclude = config->viiectlr & BIT(idx / 2 + 16); > + } > + spin_unlock(&drvdata->spinlock); > + if (addr_type) { > + size = scnprintf(buf, PAGE_SIZE, "addr_cmp[%i] %s %#lx", idx, > + addr_type_names[addr_type], addr_v); > + if (addr_type == ETM_ADDR_TYPE_RANGE) { > + size += scnprintf(buf+size, PAGE_SIZE-size, s/buf+size/buf + size s/PAGE_SIZE-size/PAGE_SIZE - size > + " %#lx %s", addr_v2, > + exclude ? "exclude" : "include"); > + } > + size += scnprintf(buf+size, PAGE_SIZE-size, s/buf+size/buf + size This patch logic is clear for me, so you could add my review tag: Reviewed-by: Leo Yan Thanks, Leo Yan [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst#n194 > + " ctrl(%#lx)\n", addr_ctrl); > + } else { > + size = scnprintf(buf, PAGE_SIZE, "addr_cmp[%i] unused\n", idx); > + } > + return size; > +} > +static DEVICE_ATTR_RO(addr_cmp_view); > + > static ssize_t vinst_pe_cmp_start_stop_show(struct device *dev, > struct device_attribute *attr, > char *buf) > @@ -2117,6 +2167,7 @@ static struct attribute *coresight_etmv4_attrs[] = { > &dev_attr_addr_ctxtype.attr, > &dev_attr_addr_context.attr, > &dev_attr_addr_exlevel_s_ns.attr, > + &dev_attr_addr_cmp_view.attr, > &dev_attr_vinst_pe_cmp_start_stop.attr, > &dev_attr_seq_idx.attr, > &dev_attr_seq_state.attr, > -- > 2.17.1 > > _______________________________________________ > CoreSight mailing list > CoreSight@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/coresight _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel