From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D34ADC3A5A1 for ; Wed, 28 Aug 2019 16:24:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7606217F5 for ; Wed, 28 Aug 2019 16:24:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LgSj0cby" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7606217F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/uq526pRplg6ZLX7JpjMcGp84tfGRIX7cr+7QgFWZXU=; b=LgSj0cbyzCrFQy jTsM4XOYmdWhWd5Mhqc7tVyNLfGNwd3hE5LZA/7txYHrrJJ9FBmG0M+O4bVwXrfLRLOZ7oAH9cRm1 poLdYEbXliV3NecinYZtY6cR3Miw/u/UFqpryOfiKkF86nMnRmD8cl72IJeevzVz2TZaUPpjnJ0Qh pvUABIl7UTmBdjJ3rCM6wmfmeOMcTryHkHQKPcsT2NIeZhBxxnv77uGw1op2BMwOZI3OjanwlLCFJ krSsyBekXoEZFoY8SIgf2Dn3cIgF648EQaFXkl6Wk+qd1NdhhRaqbCZ7dKiD1trzDb0BuUE5XBAZR iSREv5/gaE8J9shDhpCQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i30k5-0008Or-74; Wed, 28 Aug 2019 16:24:17 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i30k1-0008OS-J8 for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2019 16:24:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DD7FD28; Wed, 28 Aug 2019 09:24:12 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D9AD43F59C; Wed, 28 Aug 2019 09:24:11 -0700 (PDT) Date: Wed, 28 Aug 2019 17:24:09 +0100 From: Mark Rutland To: Andrew Murray Subject: Re: [PATCH v3 2/5] arm64: Use correct ll/sc atomic constraints Message-ID: <20190828162409.GC42408@lakrids.cambridge.arm.com> References: <20190812143625.42745-1-andrew.murray@arm.com> <20190812143625.42745-3-andrew.murray@arm.com> <20190822153223.GB33080@lakrids.cambridge.arm.com> <20190828130118.GW14582@e119886-lin.cambridge.arm.com> <20190828152540.GA42408@lakrids.cambridge.arm.com> <20190828154422.GA14582@e119886-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190828154422.GA14582@e119886-lin.cambridge.arm.com> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190828_092413_676641_52783A7D X-CRM114-Status: GOOD ( 14.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Catalin Marinas , Boqun Feng , Will Deacon , Ard.Biesheuvel@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 28, 2019 at 04:44:22PM +0100, Andrew Murray wrote: > On Wed, Aug 28, 2019 at 04:25:40PM +0100, Mark Rutland wrote: > > On Wed, Aug 28, 2019 at 02:01:19PM +0100, Andrew Murray wrote: > > > On Thu, Aug 22, 2019 at 04:32:23PM +0100, Mark Rutland wrote: > > > > On Mon, Aug 12, 2019 at 03:36:22PM +0100, Andrew Murray wrote: > > > > [...] > > > > > > > > > -ATOMIC64_OPS(and, and) > > > > > -ATOMIC64_OPS(andnot, bic) > > > > > -ATOMIC64_OPS(or, orr) > > > > > -ATOMIC64_OPS(xor, eor) > > > > > +ATOMIC64_OPS(and, and, K) > > > > > +ATOMIC64_OPS(andnot, bic, ) > > > > > +ATOMIC64_OPS(or, orr, K) > > > > > +ATOMIC64_OPS(xor, eor, K) > > > > > > > > Shouldn't these be 'L'? > > > > > > > > IIUC K is a subset of L, so if that's deliberate we should call that out > > > > explicitly... > > > > > > Oooh yes that's wrong. I guess the atomic64_[and,or,xor] are rarely called > > > in the kernel which perhaps is why the compiler hasn't shouted at me. > > > > > > Do you agree that the and, orr and eor should all be 'L' instead of 'K'? > > > > Yes, I think all the 64-bit logical ops should all use 'L'. > > With the exception of bic? I don't think there is an appropriate constraint > for this (it requires an 8 bit immediate). The ARM ARM doesn't mention BIC (Immediate), and AFAICT that's an (undocumented?) alias for AND (Immediate) with a negated immediate. Where did you find a description with an 8-bit immediate? Regardless, yes, drop the 'L' there -- I can't find any suitable constraint either. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel