From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA25C3A5A1 for ; Wed, 28 Aug 2019 18:30:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F9932070B for ; Wed, 28 Aug 2019 18:30:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Zy8oxntO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F9932070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6pjh0meZkZ/MUB7vXIqRYHUX8BhPCvo++fo4io89ITI=; b=Zy8oxntOWosro2 FzwcwnPiV5jTf9YXOYNbS2yp2x3RfDILbNF2nzilcv3q/o9kZr3vhQDKBXRLosvD00474VgeP8Tvc tR+3hUEedBcMRMQPLGaKxwFSOTMANs9PwIMDw9VwORkVLIHIOUsIea78AoneJee0mIkLFgRHRdpeY HnOyv6diRFdf6edC5XS+O8XnWHxTZIx2ASAxy03VxjZE4/l+7gWiTfYZvDH4YOduCSMWR2JaogBjI hYsjicImCExyY3kf1aySSmgu3dANnkyPF/4aa61IEf+hrTg2AkGRayov0NRWtHO6noxwg4wjw2UNu /AGaJ+FS/b4PJNnOlx/A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i32i1-0003iN-GJ; Wed, 28 Aug 2019 18:30:17 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i32hz-0003hi-1M for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2019 18:30:16 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 3292F80C5; Wed, 28 Aug 2019 18:30:40 +0000 (UTC) Date: Wed, 28 Aug 2019 11:30:07 -0700 From: Tony Lindgren To: Ladislav Michl Subject: Re: [PATCH] ARM: OMAP2+: Delete an unnecessary kfree() call in omap_hsmmc_pdata_init() Message-ID: <20190828183007.GD52127@atomide.com> References: <69025c8c-8d84-6686-138b-cde59467b802@web.de> <20190826162050.GX52127@atomide.com> <20190827181457.GA16333@lenoch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190827181457.GA16333@lenoch> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190828_113015_129559_AE8294AF X-CRM114-Status: GOOD ( 10.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Walmsley , Balaji T K , kernel-janitors@vger.kernel.org, Kishore Kadiyala , Russell King , LKML , Markus Elfring , Nikolaus Schaller , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Benoit Cousson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Ladislav Michl [190827 18:15]: > On Mon, Aug 26, 2019 at 09:20:50AM -0700, Tony Lindgren wrote: > > * Markus Elfring [190826 06:31]: > > > From: Markus Elfring > > > Date: Mon, 26 Aug 2019 15:05:31 +0200 > > > > > > A null pointer would be passed to a call of the function "kfree" directly > > > after a call of the function "kzalloc" failed at one place. > > > Remove this superfluous function call. > > > > > > This issue was detected by using the Coccinelle software. > > > > Applying into omap-for-v5.4/soc thanks. > > Is it really wise touching almost dead code? Last user is pandora board, so > +Cc: Nikolaus Schaller Yeah would be good to finally get rid of that old code. Anyways, I'll keep the $subject patch to cut down on coccinelle produced issue. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel