Re: [arm:for-next 13/25] include/linux/error-injection.h:7:10: fatal error: asm/error-injection.h: No such file or directory

[Leo Yan <leo.yan@linaro.org>]

Hi Will,

On Thu, Aug 29, 2019 at 09:32:00AM +0100, Will Deacon wrote:
> [ Move RMK to To: ]
> 
> On Thu, Aug 29, 2019 at 02:43:10PM +0800, Leo Yan wrote:
> > On Thu, Aug 29, 2019 at 08:49:16AM +0800, kbuild test robot wrote:
> > > tree:   git://git.armlinux.org.uk/~rmk/linux-arm.git for-next
> > > head:   d0d54dc04e37be14a9e51d9a2e431f302948e99d
> > > commit: 566c290c6498b2fdc04a54556c4e8747f0298c7b [13/25] ARM: 8899/1: arm/arm64: Add support for function error injection
> > > config: arm-allmodconfig (attached as .config)
> > > compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
> > > reproduce:
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         git checkout 566c290c6498b2fdc04a54556c4e8747f0298c7b
> > >         # save the attached .config to linux build tree
> > >         GCC_VERSION=7.4.0 make.cross ARCH=arm 
> > > 
> > > If you fix the issue, kindly add following tag
> > > Reported-by: kbuild test robot <lkp@intel.com>
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > >    In file included from include/linux/module.h:22:0,
> > >                     from drivers/pps/pps.c:11:
> > > >> include/linux/error-injection.h:7:10: fatal error: asm/error-injection.h: No such file or directory
> > >     #include <asm/error-injection.h>
> > >              ^~~~~~~~~~~~~~~~~~~~~~~
> > >    compilation terminated.
> > 
> > This building error is caused by there have a dependent patch:
> > error-injection: Consolidate override function definition
> > https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?h=for-next/error-injection&id=45880f7b7b19e043ce0aaa4cb7d05369425c82fa
> 
> Ah, I guess you put the ARM patch into the patch system without reference to
> the core parts?

Yes, this is exactly what I did.  Sorry I only put the ARM patch and
didn't give out the whole context.

> > This patch has been picked up by Will in one of arm64's next branch:
> > https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=for-next/error-injection
> > 
> > I don't know what's the best practice for the dependency between
> > two branches, if need me to follow up anything, please let me know.
> 
> The for-next/error-injection branch here:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=for-next/error-injection
> 
> is stable, so I suppose either:
> 
>    * That could be pulled into the ARM tree, or
>    * The ARM part could wait until the core stuff has landed in mainline, or
>    * I could take the ARM patch via the arm64 tree if Russell is ok with it

Thanks for these options.  I'd like to know what's Russell's decision,
then I will look closely to know what I should follow up or not.

Thanks,
Leo Yan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel