linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kishon Vijay Abraham I <kishon@ti.com>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/11] dt-bindings: phy-mtk-tphy: add two optional properties for u2phy
Date: Thu, 29 Aug 2019 14:23:41 -0500	[thread overview]
Message-ID: <20190829192341.GA26293@bogus> (raw)
In-Reply-To: <e99c0d7a55869a4425250c601b80a3331c9d0976.1566542696.git.chunfeng.yun@mediatek.com>

On Fri, Aug 23, 2019 at 03:00:08PM +0800, Chunfeng Yun wrote:
> Add two optional properties, one for J-K test, another for disconnect
> threshold, both of them can be used to debug disconnection issues.

Testing and debug properties aren't really things that belong in DT.

> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
>  Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt
> index a5f7a4f0dbc1..d5b327f85fa2 100644
> --- a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt
> +++ b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt
> @@ -52,6 +52,8 @@ Optional properties (PHY_TYPE_USB2 port (child) node):
>  - mediatek,eye-vrt	: u32, the selection of VRT reference voltage
>  - mediatek,eye-term	: u32, the selection of HS_TX TERM reference voltage
>  - mediatek,bc12	: bool, enable BC12 of u2phy if support it
> +- mediatek,discth	: u32, the voltage of disconnect threshold
> +- mediatek,intr	: u32, the value of internal R (resistance)

These need units as defined in property-units.txt.

>  
>  Example:
>  
> -- 
> 2.23.0
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-08-29 19:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23  7:00 [PATCH 01/11] dt-bindings: phy-mtk-tphy: add two optional properties for u2phy Chunfeng Yun
2019-08-23  7:00 ` [PATCH 02/11] dt-bindings: phy-mtk-tphy: make the ref clock optional Chunfeng Yun
2019-08-29 19:25   ` Rob Herring
2019-08-30  6:22     ` Chunfeng Yun
2019-08-23  7:00 ` [PATCH 03/11] dt-bindings: phy-mtk-tphy: remove unused u3phya_ref clock Chunfeng Yun
2019-08-29 20:03   ` Rob Herring
2019-08-23  7:00 ` [PATCH 04/11] dt-bindings: phy-mtk-tphy: add a new reference clock Chunfeng Yun
2019-08-29 20:05   ` Rob Herring
2019-08-30  6:23     ` Chunfeng Yun
2019-08-23  7:00 ` [PATCH 05/11] dt-bindings: phy-mtk-tphy: add the properties about address mapping Chunfeng Yun
2019-08-29 20:16   ` Rob Herring
2019-08-23  7:00 ` [PATCH 06/11] phy: phy-mtk-tphy: add a property for disconnect threshold Chunfeng Yun
2019-08-23  7:00 ` [PATCH 07/11] phy: phy-mtk-tphy: add a property for internal resistance Chunfeng Yun
2019-08-23  7:00 ` [PATCH 08/11] phy: phy-mtk-tphy: make the ref clock optional Chunfeng Yun
2019-08-23  7:00 ` [PATCH 09/11] phy: phy-mtk-tphy: remove unused u3phya_ref clock Chunfeng Yun
2019-08-23  7:00 ` [PATCH 10/11] phy: phy-mtk-tphy: add a new reference clock Chunfeng Yun
2019-08-23  7:00 ` [PATCH 11/11] arm64: dts: mt2712: use non-empty ranges for usb-phy Chunfeng Yun
2019-08-29 19:23 ` Rob Herring [this message]
2019-08-30  6:03   ` [PATCH 01/11] dt-bindings: phy-mtk-tphy: add two optional properties for u2phy Chunfeng Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190829192341.GA26293@bogus \
    --to=robh@kernel.org \
    --cc=chunfeng.yun@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).