From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B89F8C3A59F for ; Thu, 29 Aug 2019 21:55:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EB7C208C2 for ; Thu, 29 Aug 2019 21:55:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eCq4tk5H"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YCjZYPDG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EB7C208C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lGTrE6t4vZPI68bdwdzp1HOIPaxuzERTsAjI/AJyXyU=; b=eCq4tk5HQ5Uw+b AiHAU5Uds3H0PE4XPxa6QYfMpTeM4WGSFWf9jihvT6VcSHOA0hgufp5IScQZcAIvdzme72rGwj0Vn AU8xnjNONzFTnKx3wQdf1FkDGhPOucj+bD4J0Nflg5EBcnP/J48ZYlf+Doi9YI41TsZAxZmlAT3oM vEYwlUCEwF2vpYvTernCvz9q3N39kTV3vSPE8w6oN5YijmhhE49/blwGrmmBvbd9wqfj/DlrdU5wg EnzrIXlChwB031ZM5dy4AVNO6iukcfqtrP/tH1HW+VuUqXxhJR/0O5GqudAp8j+lHNCus2JcY1mhP sfdIt9POLrTscMUgbVGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i3SNh-0003Le-Na; Thu, 29 Aug 2019 21:55:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i3SNe-0003LF-Kd for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2019 21:54:59 +0000 Received: from brain-police (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E4E10208C2; Thu, 29 Aug 2019 21:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567115698; bh=1Ma6LNUxXynsrgMoV6mYy1LUKgVsxh29b17391c3yjw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YCjZYPDGBN7yqErDM2W4ZksZ0SguZsZUWatjlqOCqNmSQpe6+EXhCtmMh4xCFNU85 gOaAcEZNHZEG3Nku16PQkPxPcbgQRmQrFcyDHHkB7e+wZtUdlDTENgBVCvPi1OcJ2Z iLkSCyviPEn3A6lv1OY27M13liYEaaWQL+yenVTM= Date: Thu, 29 Aug 2019 22:54:52 +0100 From: Will Deacon To: Tri Vo Subject: Re: [PATCH v5 05/10] arm64: atomics: Remove atomic_ll_sc compilation unit Message-ID: <20190829215452.GC2404@brain-police> References: <20190829154834.26547-1-will@kernel.org> <20190829154834.26547-6-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190829_145458_720098_D056891B X-CRM114-Status: GOOD ( 18.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Zijlstra , Catalin Marinas , Nick Desaulniers , Ard.Biesheuvel@arm.com, andrew.murray@arm.com, Nathan Chancellor , Robin Murphy , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 29, 2019 at 01:07:04PM -0700, Tri Vo wrote: > On Thu, Aug 29, 2019 at 10:47 AM Nick Desaulniers > wrote: > > > > On Thu, Aug 29, 2019 at 8:48 AM Will Deacon wrote: > > > > > > From: Andrew Murray > > > > > > We no longer fall back to out-of-line atomics on systems with > > > CONFIG_ARM64_LSE_ATOMICS where ARM64_HAS_LSE_ATOMICS is not set. > > > > > > Remove the unused compilation unit which provided these symbols. > > > > > > Signed-off-by: Andrew Murray > > > Signed-off-by: Will Deacon > > > --- > > > arch/arm64/lib/Makefile | 19 ------------------- > > > arch/arm64/lib/atomic_ll_sc.c | 3 --- > > > 2 files changed, 22 deletions(-) > > > delete mode 100644 arch/arm64/lib/atomic_ll_sc.c > > > > > > diff --git a/arch/arm64/lib/Makefile b/arch/arm64/lib/Makefile > > > index 33c2a4abda04..f10809ef1690 100644 > > > --- a/arch/arm64/lib/Makefile > > > +++ b/arch/arm64/lib/Makefile > > > @@ -11,25 +11,6 @@ CFLAGS_REMOVE_xor-neon.o += -mgeneral-regs-only > > > CFLAGS_xor-neon.o += -ffreestanding > > > endif > > > > > > -# Tell the compiler to treat all general purpose registers (with the > > > -# exception of the IP registers, which are already handled by the caller > > > -# in case of a PLT) as callee-saved, which allows for efficient runtime > > > -# patching of the bl instruction in the caller with an atomic instruction > > > -# when supported by the CPU. Result and argument registers are handled > > > -# correctly, based on the function prototype. > > > -lib-$(CONFIG_ARM64_LSE_ATOMICS) += atomic_ll_sc.o > > > -CFLAGS_atomic_ll_sc.o := -ffixed-x1 -ffixed-x2 \ > > > - -ffixed-x3 -ffixed-x4 -ffixed-x5 -ffixed-x6 \ > > > - -ffixed-x7 -fcall-saved-x8 -fcall-saved-x9 \ > > > - -fcall-saved-x10 -fcall-saved-x11 -fcall-saved-x12 \ > > > - -fcall-saved-x13 -fcall-saved-x14 -fcall-saved-x15 \ > > > - -fcall-saved-x18 -fomit-frame-pointer > > > > + Tri (who implemented support for -fcall-saved-x*, -ffixed-x* in > > Clang). I won't be sad to see the use of these flags go. > > Nice! IMO these flags made the code hard to read. Well, we didn't do it like that because it looked pretty ;) Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel