From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE79AC3A59F for ; Sat, 31 Aug 2019 08:39:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 814FC23711 for ; Sat, 31 Aug 2019 08:39:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VBYvPVhp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 814FC23711 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=peouAZsaNkZ3lHdv0uuM3b2xFFSjaKBjbALdPxt63UY=; b=VBYvPVhpR7+f8+ zIsl/kIayh0DdFZtEHocdYkCCHkyWXC8XucnxlU+whcyORLouv9FUU2Q1BuBxfeAsFdIMi672PlEb TWIrwp0CtwyPc0cam0ucGGWMkvViNQ9FFj3WBA3Ui0F6Rv09MBVcTSeBBqcb2D/3uOCBZqtRb0Jz+ HeaVg4fDwABAp2+YeIB1G6Y1Br7zuqPS7d87zIl3YeA5/BXNT57oCn7ruCxoHDv4grnLJQqXY1ddV wgltl2KQS+WqZGN2cv/QcnOQea/Tji0FQoLXwEd3U7yyxZruLsHoZNt5q0Wn7A7YQK4N0nUXsKLt0 fSoTJnRm0J45KcQfTwWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i3yuU-0006RS-W7; Sat, 31 Aug 2019 08:39:03 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i3yuH-0006RE-Bs; Sat, 31 Aug 2019 08:38:49 +0000 Date: Sat, 31 Aug 2019 01:38:49 -0700 From: Christoph Hellwig To: Arnd Bergmann Subject: Re: [PATCH] Revert "asm-generic: Remove unneeded __ARCH_WANT_SYS_LLSEEK macro" Message-ID: <20190831083849.GA24644@infradead.org> References: <20190830194651.31043-1-msuchanek@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Linux-sh list , Benjamin Herrenschmidt , Heiko Carstens , Linux Kernel Mailing List , "James E.J. Bottomley" , Max Filippov , Guo Ren , "H. Peter Anvin" , sparclinux , Vincenzo Frascino , Will Deacon , linux-arch , linux-s390 , Yoshinori Sato , Michael Ellerman , Helge Deller , the arch/x86 maintainers , Russell King , Christian Borntraeger , Ingo Molnar , Geert Uytterhoeven , Christian Brauner , Catalin Marinas , James Hogan , Firoz Khan , Michal Suchanek , linux-xtensa@linux-xtensa.org, Vasily Gorbik , Chris Zankel , linux-m68k , Borislav Petkov , Alexander Viro , Thomas Gleixner , Linux ARM , David Howells , Michal Simek , Parisc List , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Ralf Baechle , Paul Burton , Linux FS-devel Mailing List , Paul Mackerras , linuxppc-dev , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 30, 2019 at 09:54:43PM +0200, Arnd Bergmann wrote: > > -#if !defined(CONFIG_64BIT) || defined(CONFIG_COMPAT) > > +#ifdef __ARCH_WANT_SYS_LLSEEK > > SYSCALL_DEFINE5(llseek, unsigned int, fd, unsigned long, offset_high, > > unsigned long, offset_low, loff_t __user *, result, > > unsigned int, whence) > > However, only reverting the patch will now break all newly added > 32-bit architectures that don't define __ARCH_WANT_SYS_LLSEEK: > at least nds32 and riscv32 come to mind, not sure if there is another. > > I think the easiest way however would be to combine the two checks > above and make it > > #if !defined(CONFIG_64BIT) || defined(CONFIG_COMPAT) || > defined(__ARCH_WANT_SYS_LLSEEK) > > and then only set __ARCH_WANT_SYS_LLSEEK for powerpc. I'd much rather introduce a CONFIG_SYS_LLSEEK Kconfig symbol, selected by CONFIG_64BIT and CONFIG_COMPAT by default, plus manually by powerpc. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel