From: Wolfram Sang <wsa@the-dreams.de>
To: Eugen.Hristev@microchip.com
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org,
pierre-yves.mordret@st.com, Ludovic.Desroches@microchip.com,
robh+dt@kernel.org, linux-i2c@vger.kernel.org, peda@axentia.se,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 5/9] i2c: at91: add support for digital filtering
Date: Sat, 31 Aug 2019 14:13:08 +0200 [thread overview]
Message-ID: <20190831121308.GB1032@ninjato> (raw)
In-Reply-To: <1562678049-17581-6-git-send-email-eugen.hristev@microchip.com>
[-- Attachment #1.1: Type: text/plain, Size: 921 bytes --]
> diff --git a/drivers/i2c/busses/i2c-at91-core.c b/drivers/i2c/busses/i2c-at91-core.c
> index a663a7a..62610af 100644
> --- a/drivers/i2c/busses/i2c-at91-core.c
> +++ b/drivers/i2c/busses/i2c-at91-core.c
> @@ -68,6 +68,7 @@ static struct at91_twi_pdata at91rm9200_config = {
> .has_unre_flag = true,
> .has_alt_cmd = false,
> .has_hold_field = false,
> + .has_dig_filtr = false,
Hmm, 'false' is the default. Maybe not for this series, but it might
make sense to clean up the driver afterwards removing the superfluous
'false'. The precedence will make adding new properties much simpler.
> + dev->enable_dig_filt = of_property_read_bool(pdev->dev.of_node,
> + "i2c-dig-filter");
> +
What do you think of the idea to introduce 'flags' to struct i2c_timings
and parse the bindings in the core, too? Then you'd have sth like:
if (t->flags & I2C_TIMINGS_ANALOG_FILTER)
Would that be useful for you?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-31 12:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 13:19 [PATCH v3 0/9] i2c: add support for filters Eugen.Hristev
2019-07-09 13:19 ` [PATCH v3 1/9] dt-bindings: i2c: at91: add new compatible Eugen.Hristev
2019-07-24 20:22 ` Rob Herring
2019-07-09 13:19 ` [PATCH v3 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter Eugen.Hristev
2019-07-24 20:22 ` Rob Herring
2019-08-31 11:39 ` Wolfram Sang
2019-07-09 13:19 ` [PATCH v3 3/9] i2c: add support for filter-width-ns optional property Eugen.Hristev
2019-07-09 13:19 ` [PATCH v3 4/9] i2c: at91: add new platform support for sam9x60 Eugen.Hristev
2019-07-09 13:19 ` [PATCH v3 5/9] i2c: at91: add support for digital filtering Eugen.Hristev
2019-08-31 12:13 ` Wolfram Sang [this message]
2019-08-31 12:17 ` Wolfram Sang
2019-09-02 8:54 ` Eugen.Hristev
2019-07-09 13:19 ` [PATCH v3 6/9] i2c: at91: add support for advanced " Eugen.Hristev
2019-07-09 13:19 ` [PATCH v3 7/9] i2c: at91: add support for analog filtering Eugen.Hristev
2019-07-09 13:19 ` [PATCH v3 8/9] ARM: dts: at91: sama5d2_xplained: add analog and digital filter for i2c Eugen.Hristev
2019-07-09 13:19 ` [PATCH v3 9/9] ARM: dts: at91: sama5d4_xplained: add " Eugen.Hristev
2019-07-12 8:20 ` [PATCH v3 0/9] i2c: add support for filters Ludovic Desroches
2019-08-22 15:00 ` Eugen.Hristev
2019-08-29 20:28 ` Wolfram Sang
2019-08-31 12:19 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190831121308.GB1032@ninjato \
--to=wsa@the-dreams.de \
--cc=Eugen.Hristev@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peda@axentia.se \
--cc=pierre-yves.mordret@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).