From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F02FEC3A59E for ; Mon, 2 Sep 2019 21:11:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4C2D21881 for ; Mon, 2 Sep 2019 21:11:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="meHtK7za"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="AD5eFMS4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4C2D21881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aS5GebB6uPw5g36QoP0Ij+WVPfDKvFGlIe+GMsWr2Ag=; b=meHtK7zaZr0HLh ZbZhv0khwU7PwbtnvBJphTp2ghya7vSABsgdJdVRp8z9Ae2eFDDzgTXn7p9A8ruJEq63RkVg8iCai +cCm9hfgdLmdnDAIjjULDKGNIX5DeemyK8rBZF7HqZEwbqycyae4aKeRVDLLHTO48s8A7NKRaglz7 8uD9a479yjmjxUMrH0Sco2IVG8n5VnwQ/0VaMr3eJtW6WyHoH4EtvrXxU0411Ryl+NmmizGME1KIw eg9mXNIiqPv5q7PnHLqtMBvQ6CDeKRofhVWq1oyE4A9bC9JgYZ1rWU740WqXf0fKbB6EEUEb2wrcX 7gAA7kHfPflwXYjMvEoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i4tbQ-0003L0-5J; Mon, 02 Sep 2019 21:11:08 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i4tbM-0003Jz-CE for linux-arm-kernel@lists.infradead.org; Mon, 02 Sep 2019 21:11:05 +0000 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE26E20870; Mon, 2 Sep 2019 21:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567458663; bh=qX20IVLvUSWOzNkJj+sBxx54B1HMotDbCAEmajym6B4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AD5eFMS4HiX4X1/0G9Dh521nWKDrI33a0LGJ0QWlqf8kqJtJGwk+ofVyNT7IeCGfl Im9W9rMBG81wLTIm2kTSbYoxtjkXIiRrPWYKaSy4KyVxMQEWteJ9LBElPao4m4VEYW tpe6XC5372WqFaPwj4r+5pjb3N8k7cK0+9491v18= Date: Mon, 2 Sep 2019 16:11:00 -0500 From: Bjorn Helgaas To: Christoph Hellwig Subject: Re: [PATCH] PCI: Move ATS declarations to linux/pci.h Message-ID: <20190902211100.GH7013@google.com> References: <20190830150756.21305-1-kw@linux.com> <20190830161840.GA9733@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190830161840.GA9733@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190902_141104_443559_F48DBC27 X-CRM114-Status: GOOD ( 11.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof Wilczynski , linux-pci@vger.kernel.org, Joerg Roedel , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Will Deacon , David Woodhouse , linux-arm-kernel@lists.infradead.org, Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 30, 2019 at 09:18:40AM -0700, Christoph Hellwig wrote: > On Fri, Aug 30, 2019 at 05:07:56PM +0200, Krzysztof Wilczynski wrote: > > Move ATS function prototypes from include/linux/pci-ats.h to > > include/linux/pci.h so users only need to include : > > Why is that so important? Very few PCI(e) device drivers use ATS, > so keeping it out of everyones include hell doesn't seem all bad. This was my idea, and it wasn't a good one, sorry. The ATS, PRI, and PASID interfaces are all sort of related and are used only by the IOMMU drivers, so it probably makes sense to put them all together. Right now the ATS stuff is in linux/pci.h and PRI/PASID stuff is in linux/pci-ats.h. Maybe the right thing would be to move the ATS stuff to pci-ats.h. I previously moved it from pci-ats.h to pci.h with ff9bee895c4d ("PCI: Move ATS declarations to linux/pci.h so they're all together") with the excuse of putting the external ATS interfaces next to pci_ats_init(). But that really looks like it was a mistake because pci_ats_init() is a PCI-internal thing and its declaration should probably be in drivers/pci/pci.h instead. There's also a useless "struct pci_ats" forward declaration in linux/pci.h that I should have removed with d544d75ac96a ("PCI: Embed ATS info directly into struct pci_dev"). Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel