From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Maruthi Srinivas Bayyavarapu <maruthis@xilinx.com>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
praveenv@xilinx.com, Jaroslav Kysela <perex@perex.cz>,
alexandre@bootlin.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ASoC: xlnx: add Xilinx logicPD-I2S FPGA IP support
Date: Mon, 2 Sep 2019 22:21:11 +0200 [thread overview]
Message-ID: <20190902222111.045ede17@xps13> (raw)
In-Reply-To: <df36fc2d-ed62-2556-513d-158a7707d5cd@xilinx.com>
Hi Michal,
Michal Simek <michal.simek@xilinx.com> wrote on Mon, 2 Sep 2019
09:39:11 +0200:
> Hi Miquel
>
> On 30. 08. 19 23:06, Miquel Raynal wrote:
> > This IP is very simple so this driver manage both the DAI and the PCM
> > streams, hence the presence of both components in this driver.
> >
> > There are plenty available interruptions when capturing or playing
> > back audio that can be triggered but the only one that fits the ALSA
> > sound system is the XFER_DONE which is used to bound sound
> > periods. Other interrupts are masked. Please note that capture and
> > playback are not possible at the same time though.
> >
> > Capture seems to work (at least it creates a file with something
> > inside) but I have no capture mechanism on the board to actually test
> > that it works correctly.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >
> > Hello,
> >
> > This is my first contribution in the sound subsystem, I hope I've
> > understood the core but I might be entirely wrong as well, so please
> > do not hesitate to be critical on my choices.
> >
> > Thanks,
> > Miquèl
> >
> > sound/soc/xilinx/Kconfig | 7 +
> > sound/soc/xilinx/Makefile | 2 +
> > sound/soc/xilinx/xlnx-logicpd-i2s.c | 468 ++++++++++++++++++++++++++++
>
> What IP is this?
> https://www.xilinx.com/products/intellectual-property/audio-i2s.html
>
> https://github.com/Xilinx/linux-xlnx/blob/master/sound/soc/xilinx/xlnx_i2s.c
>
> Anyway I am adding Praveen and Maruthi to take a look.
Actually I have been tricked by a datasheet with the wrong title: this
is a LogicPD IP, it is not from Xilinx. I will resubmit with a new
driver name/compatible and add the relevant people.
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-02 20:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 21:06 [PATCH 1/3] ASoC: xlnx: add Xilinx logicPD-I2S FPGA IP support Miquel Raynal
2019-08-30 21:06 ` [PATCH 2/3] dt-bindings: sound: Add Xilinx logicPD-I2S FPGA IP bindings Miquel Raynal
2019-09-02 13:39 ` Rob Herring
2019-09-02 13:51 ` Miquel Raynal
2019-09-02 14:24 ` Rob Herring
2019-08-30 21:06 ` [PATCH 3/3] MAINTAINERS: Add an entry for the Xilinx logicPD-I2S block Miquel Raynal
2019-09-02 7:39 ` [PATCH 1/3] ASoC: xlnx: add Xilinx logicPD-I2S FPGA IP support Michal Simek
2019-09-02 20:21 ` Miquel Raynal [this message]
2019-09-03 6:51 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902222111.045ede17@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=alexandre@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maruthis@xilinx.com \
--cc=michal.simek@xilinx.com \
--cc=perex@perex.cz \
--cc=praveenv@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).