From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 069ABC3A5A2 for ; Tue, 3 Sep 2019 12:59:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAB9F215EA for ; Tue, 3 Sep 2019 12:59:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HIqJw6KO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAB9F215EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=72eSP/aqik/ULZhjdV4DvR5r2XnDVS5db9jS1vk/iKk=; b=HIqJw6KOZQobPA i1rSohx1Sdnl9aZdu5oN8bSMpNN5GljxjKkzV7ylYhVl+y5VNjhr9NCL7sANYIRYmZfDfO64OBr4H K546zuFDd7aFdhPTrkF9Cl89i/2jkDlQZBaIyTckjLMMQSHIYnoZpHoiBeJh2O80XscNDPgq0KA3/ 7il535LnEN+nLKX7eq1kxKfiBrZySnZlhGyhcxWYracL8Cwf2TPFAbmtpd//x7gtfSX1OSrcQXSVG dTxPfIgsPsbIBokDVOycz3xdsEsie5aqCc0uQevTcFz2CuxGRBAC7RDZI8h4gPnnFe3mh8UVAVevo NpzQeoq0M64G1RQIjA4A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i58Od-0002Fk-QB; Tue, 03 Sep 2019 12:58:55 +0000 Received: from 8bytes.org ([2a01:238:4383:600:38bc:a715:4b6d:a889] helo=theia.8bytes.org) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i58Oa-0002F3-Jy for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2019 12:58:53 +0000 Received: by theia.8bytes.org (Postfix, from userid 1000) id 6786C284; Tue, 3 Sep 2019 14:58:50 +0200 (CEST) Date: Tue, 3 Sep 2019 14:58:49 +0200 From: Joerg Roedel To: YueHaibing Subject: Re: [PATCH v2 -next] iommu/arm-smmu-v3: Fix build error without CONFIG_PCI_ATS Message-ID: <20190903125848.GC11530@8bytes.org> References: <20190903024212.20300-1-yuehaibing@huawei.com> <20190903065056.17988-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190903065056.17988-1-yuehaibing@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190903_055852_810576_B71FD281 X-CRM114-Status: GOOD ( 10.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robin.murphy@arm.com, iommu@lists.linux-foundation.org, will@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 03, 2019 at 02:50:56PM +0800, YueHaibing wrote: > If CONFIG_PCI_ATS is not set, building fails: > > drivers/iommu/arm-smmu-v3.c: In function arm_smmu_ats_supported: > drivers/iommu/arm-smmu-v3.c:2325:35: error: struct pci_dev has no member named ats_cap; did you mean msi_cap? > return !pdev->untrusted && pdev->ats_cap; > ^~~~~~~ > > ats_cap should only used when CONFIG_PCI_ATS is defined, > so use #ifdef block to guard this. > > Fixes: bfff88ec1afe ("iommu/arm-smmu-v3: Rework enabling/disabling of ATS for PCI masters") > Signed-off-by: YueHaibing > --- > v2: Add arm_smmu_ats_supported() of no CONFIG_PCI_ATS > --- > drivers/iommu/arm-smmu-v3.c | 7 +++++++ > 1 file changed, 7 insertions(+) Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel