From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3305C3A5A7 for ; Wed, 4 Sep 2019 11:51:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C654E22CF7 for ; Wed, 4 Sep 2019 11:51:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iUTm13fO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C654E22CF7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1r/Y0LOxPnJHQis1uhz5kTiSTASeaE8WMFsty+c/QTY=; b=iUTm13fOFWGYkA KUH+F4HI3y8mxB2VYpwMMAmqKV7CgL9Wb3bPlgBWyT1aQKiuC6zs7evFLCeKIQ3uT1rjGYPZmYZLl LUlsSNTr/++VaX7NkXmMLkdCfhivfC4xS89PiiF2m5Nqsed4DLOa1o0Zh4L/ASVTUrsee9IgNB1XP 1+8Yrf6dTomAS0FxSQcA4neAiU8K/dy+7rUOVySJyMDN7+SpnvbBgb36LtKz2gj5ggYHiMJccDr/9 wdOOGfFun4j2Vuty+nR/dJJuA/2e/nBnA91LQcOCUjhDlmVYMGX0Q9Jqa6cqCiFOaUThEISfmWvIX pXFczzevT/hs3VOeJW1w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5ToW-0007nr-S1; Wed, 04 Sep 2019 11:51:04 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5TnH-0005gu-MF for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2019 11:49:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E495337; Wed, 4 Sep 2019 04:49:47 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 774743F246; Wed, 4 Sep 2019 04:49:46 -0700 (PDT) Date: Wed, 4 Sep 2019 12:49:44 +0100 From: Dave Martin To: Cristian Marussi Subject: Re: [PATCH v5 11/11] kselftest: arm64: fake_sigreturn_misaligned_sp Message-ID: <20190904114944.GB27757@arm.com> References: <20190902112932.36129-1-cristian.marussi@arm.com> <20190902112932.36129-12-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190902112932.36129-12-cristian.marussi@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190904_044947_837374_3B749A0C X-CRM114-Status: GOOD ( 18.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amit.kachhap@arm.com, andreyknvl@google.com, shuah@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 02, 2019 at 12:29:32pm +0100, Cristian Marussi wrote: > Add a simple fake_sigreturn testcase which places a valid sigframe on a > non-16 bytes aligned SP. Expects a SIGSEGV on test PASS. > > Signed-off-by: Cristian Marussi > --- > v3 --> v4 > - fix commit > - use new fake_sigreturn misalig_bytes params > - removed TODO > - added test description > --- > .../testcases/fake_sigreturn_misaligned_sp.c | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c > > diff --git a/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c > new file mode 100644 > index 000000000000..1e089e66f9f3 > --- /dev/null > +++ b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c > @@ -0,0 +1,37 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2019 ARM Limited > + * > + * Place a fake sigframe on the stack at a misaligned SP: on sigreturn > + * Kernel must spot this attempt and the test case is expected to be > + * terminated via SEGV. > + */ > + > +#include > +#include > + > +#include "test_signals_utils.h" > +#include "testcases.h" > + > +struct fake_sigframe sf; > + > +static int fake_sigreturn_misaligned_run(struct tdescr *td, > + siginfo_t *si, ucontext_t *uc) > +{ > + /* just to fill the ucontext_t with something real */ > + if (!get_current_context(td, &sf.uc)) > + return 1; > + > + /* Forcing sigframe on misaligned SP (16 + 3) */ > + fake_sigreturn(&sf, sizeof(sf), 3); Can we add tests on the TODO list for other misalignments? a) 4 (i.e., __alignof__(struct _aarch64_ctx)) b) 8 (i.e., sizeof(struct _aarch64_ctx)) This may help catch potential wrong-bitmask bugs in the kernel when checking the alignment. Similarly to my suggestion on patch 10, these can go on the TODO list and added later (probably macro-ised). For now, let's get this series settled as-is -- so, after responding to nits: Reviewed-by: Dave Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel