From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A8DC3A5AB for ; Wed, 4 Sep 2019 20:47:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D32621883 for ; Wed, 4 Sep 2019 20:47:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GZ4mEFJn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="B3ZwBoxD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D32621883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1gGAcv8aSp+y04sOXrH22iU99AOc99fDthAPurOSk1U=; b=GZ4mEFJn4SXZZQ NWl+nHFkPMDdN2SKhKwsNZuDH6LHtvb26o6bCzRhSNL0UZPVIdB0CQOJkNVY7mzFs13vtfYsiCjfT 5vU+LCIGoA0kPqom9FrDZWAzTlXv3P37e42M24l3M0eM7xJMWoiyPR9Snq0kmjEm0Vl/O/pUuYBiw aAw5/h0RSSUWRwB5+Ig56iIPrbYbngl0Tc7/BE+weO6pxS8sOOdZnNixBpdjW39046wKAsvHsVlv7 wwXvkx2oQVQWO6wOgYR75IP0oI6Hi6s8E1Zt8pq9NXca63QPOrEJ5mpv66z0w7b+CEO8otEsFn/5J +I5IUYYcYsEqhKJ1ZS1A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5cBC-00067D-1l; Wed, 04 Sep 2019 20:47:02 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i5cB5-00061c-Af for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2019 20:46:57 +0000 Received: by mail-pg1-x541.google.com with SMTP id n9so86891pgc.1 for ; Wed, 04 Sep 2019 13:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7FpVgaIhgimDRqpweFDbMiGBjSsk/JazcD80okKL/K8=; b=B3ZwBoxDNj5wp/W0+6EgPLtyn42FRM4lKEPuGul/INFNVDV0d6vrjAfI74kiYbBjwb RtwOAFpFkp8ULzlYQBnaGau4RSDKiK2Sdq8Hjs6JHKbU5On8H56ARMSYggt77ImaOAXR Phja5i1TBR6bjGzSRWjJc8EZqzoOHCuT1G+iocES8UWBNVeoOYiRY6HkgRLZvKh5M6Sb WHzguaFI/2ByIIVLDKt6nFLW+FJbEXZiBcnjB+VvF1jsWXutZ6GLiXNq+3ly3QHxD/gn UhmFNW0RtNQQoSqk6dbh3isqFmSp5AkCvUY6fi5kmUt8vL3neywbb2V1USK8/dnNvSiJ Cxug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7FpVgaIhgimDRqpweFDbMiGBjSsk/JazcD80okKL/K8=; b=mxMN6I7SunlYrlE8MdLb+LKFpfvcKh20eRnXE6xZeqWAJSpmkUCbaAy6Cw4PkAKy5E 2ZLSydo/AkbPGv3qfgc5mFybDUk6NnbhfrCbe24d3C3HfKnhaOYqOHdqwnOtGK2J9acH YxuSfBiRItpE/Mum0Tff+YPd24KL1tGs0vfBYrZ4lXmft8MeM/TJJu7Pm3HLYOKwhq/H +WZO8Q5MZRH4U0JYiPHhbuN435GuQj5q82fQ9vlTww7Adj+j26LNgi9eCIQYa2SLN5n7 ZTrOXE1fNwUNM32N0Rrpn753LSqhdVAYDGyMfKc+aTEJav1NKHvXzSpySg/NMg1Z0Wkc D/YA== X-Gm-Message-State: APjAAAVAxUq5PknfJktupWCBIX00ZH2rrKCNZjjcEk+pK1t3guK21spX x102ZGUGn7m63rEeD+8madBC+A== X-Google-Smtp-Source: APXvYqx6p9POXMCXKO+7CZNt3OeG669blGTjX7rgKqWleU9xBmKU6iit1LtXZOmDeIMaYc7+Sw+ZcA== X-Received: by 2002:a63:66c5:: with SMTP id a188mr49168pgc.127.1567630014448; Wed, 04 Sep 2019 13:46:54 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id br18sm3019455pjb.20.2019.09.04.13.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2019 13:46:53 -0700 (PDT) Date: Wed, 4 Sep 2019 13:46:49 -0700 From: Bjorn Andersson To: YueHaibing Subject: Re: [PATCH -next 23/36] spi: spi-qcom-qspi: use devm_platform_ioremap_resource() to simplify code Message-ID: <20190904204649.GF580@tuxbook-pro> References: <20190904135918.25352-1-yuehaibing@huawei.com> <20190904135918.25352-24-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190904135918.25352-24-yuehaibing@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190904_134655_374179_85265E85 X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tmaimon77@gmail.com, palmer@sifive.com, tali.perry1@gmail.com, eric@anholt.net, ldewangan@nvidia.com, linux-riscv@lists.infradead.org, festevam@gmail.com, linux-samsung-soc@vger.kernel.org, f.fainelli@gmail.com, benjaminfair@google.com, shc_work@mail.ru, khilman@baylibre.com, openbmc@lists.ozlabs.org, michal.simek@xilinx.com, krzk@kernel.org, jonathanh@nvidia.com, yuenn@google.com, wens@csie.org, agross@kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-imx@nxp.com, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, andi@etezian.org, rjui@broadcom.com, s.hauer@pengutronix.de, mripard@kernel.org, broonie@kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, paul.walmsley@sifive.com, matthias.bgg@gmail.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, baohua@kernel.org, sbranden@broadcom.com, yamada.masahiro@socionext.com, avifishman70@gmail.com, venture@google.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, thierry.reding@gmail.com, wahrenst@gmx.net, kernel@pengutronix.de, kgene@kernel.org, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed 04 Sep 06:59 PDT 2019, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > Reviewed-by: Bjorn Andersson > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > drivers/spi/spi-qcom-qspi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c > index a0ad73f..250fd60 100644 > --- a/drivers/spi/spi-qcom-qspi.c > +++ b/drivers/spi/spi-qcom-qspi.c > @@ -424,7 +424,6 @@ static int qcom_qspi_probe(struct platform_device *pdev) > { > int ret; > struct device *dev; > - struct resource *res; > struct spi_master *master; > struct qcom_qspi *ctrl; > > @@ -440,8 +439,7 @@ static int qcom_qspi_probe(struct platform_device *pdev) > > spin_lock_init(&ctrl->lock); > ctrl->dev = dev; > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - ctrl->base = devm_ioremap_resource(dev, res); > + ctrl->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(ctrl->base)) { > ret = PTR_ERR(ctrl->base); > goto exit_probe_master_put; > -- > 2.7.4 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel