linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	agross@kernel.org, robh+dt@kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	alokc@codeaurora.org, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] i2c: qcom-geni: Provide an option to select FIFO processing
Date: Thu, 5 Sep 2019 15:37:43 +0200	[thread overview]
Message-ID: <20190905133743.GE1157@kunai> (raw)
In-Reply-To: <20190905093444.GE26880@dell>


[-- Attachment #1.1: Type: text/plain, Size: 1279 bytes --]


> > So, are there investigations running why this reboot happens?
> 
> Yes, but they have been running for months, literally.

I see. This is good to know. Just so I also know where we are with this.

> > Which is a clear disadvantage of that solution. It won't fix older
> > kernels. My suggestion above should fix them, too.
> 
> Not sure how this is possible.  Unless you mean LTS?

Why not? Using of_machine_is_compatible() makes the patch 100% self
contained (no extra binding needed). It will work wherever the machine
description fits.

> > Unless we know why the reboot happens on your platform, I'd be careful
> > with saying "work obviously well" on other platforms.
> 
> Someone must have tested it?  Surely ... ;)

It seems to work mostly, I won't deny that. But we don't know if the
buggy situation can be triggered on these platforms as well by something
else later. We just don't know.

> > My suggestion:
> > 
> > For 5.3, use of_machine_is_compatible() and we backport that. For later,
> > try to find out the root cause and fix it. If that can't be done, try to
> > set up a generic "disable-dma" property and use it.
> > 
> > What do you think about that?
> 
> Sounds okay to me.  Let me code that up.

Glad you like it.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2019-09-05 13:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04 11:36 [PATCH 1/2] i2c: qcom-geni: Provide an option to select FIFO processing Lee Jones
2019-09-04 11:36 ` [PATCH 2/2] dt-bindings: soc: qcom: Provide option to select FIFO mode Lee Jones
2019-09-04 11:58   ` Vinod Koul
2019-09-04 11:56 ` [PATCH 1/2] i2c: qcom-geni: Provide an option to select FIFO processing Vinod Koul
2019-09-04 12:18   ` Lee Jones
2019-09-04 11:58 ` Vinod Koul
2019-09-04 20:35 ` Bjorn Andersson
2019-09-04 21:23   ` Wolfram Sang
2019-09-05  7:11     ` Lee Jones
2019-09-05  9:16       ` Wolfram Sang
2019-09-05  9:34         ` Lee Jones
2019-09-05 13:37           ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190905133743.GE1157@kunai \
    --to=wsa@the-dreams.de \
    --cc=agross@kernel.org \
    --cc=alokc@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).