linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Russell King <linux@armlinux.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Enrico Weigelt <info@metux.net>,
	linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] ARM: don't export unused return_address()
Date: Fri,  6 Sep 2019 17:46:55 +0200	[thread overview]
Message-ID: <20190906154706.2449696-1-arnd@arndb.de> (raw)

Without the frame pointer enabled, return_address() is an inline
function and does not need to be exported, as shown by this warning:

WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL

Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/kernel/return_address.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/kernel/return_address.c b/arch/arm/kernel/return_address.c
index b0d2f1fe891d..fb0fc1910102 100644
--- a/arch/arm/kernel/return_address.c
+++ b/arch/arm/kernel/return_address.c
@@ -53,6 +53,7 @@ void *return_address(unsigned int level)
 		return NULL;
 }
 
+EXPORT_SYMBOL_GPL(return_address);
+
 #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
-EXPORT_SYMBOL_GPL(return_address);
-- 
2.20.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2019-09-06 15:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06 15:46 Arnd Bergmann [this message]
2019-09-24  5:15 ` [PATCH] ARM: don't export unused return_address() Masahiro Yamada
2019-10-01 14:31 ` Geert Uytterhoeven
2019-11-13 11:40   ` Masahiro Yamada
2019-11-13 11:45     ` Russell King - ARM Linux admin
2019-11-13 13:15       ` Geert Uytterhoeven
2019-11-13 17:00         ` Russell King - ARM Linux admin
2019-11-20  9:02           ` Masahiro Yamada
2019-11-20  9:07             ` Russell King - ARM Linux admin
2019-11-20  9:42               ` Masahiro Yamada
2019-11-20  9:51                 ` Russell King - ARM Linux admin
2019-11-20 10:07                   ` Russell King - ARM Linux admin
2019-11-20 10:23                     ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190906154706.2449696-1-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=info@metux.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).