From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 507CFC43331 for ; Fri, 6 Sep 2019 18:25:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26FCE20838 for ; Fri, 6 Sep 2019 18:25:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BM9yHASh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tgPNLCyt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26FCE20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JNIAs3RkRi+fkV023sUT2Ldn0kAPwe1EOXWejHzQjoc=; b=BM9yHAShKcVT4Y T3rgGyizdyjbbr+UpUsngH+ztckrUD/726kcvFbZ2NdrmbanipvCPTg+b6XPuJYV9cMJ9Q4wmZKiL xOd32Ro3Qs/lOoQ1DwTScxjPEEcFch2qz9qVFqsXIy6WX8Q5pP64G8o+HaltjXBpfXhMuNAufMErW 6aHieQd9Xeu2DndBqnFltZ3SvCGXWwNqt15NMIVzFG+0iiHL5n4H0TkbiMnzOGewXHRp2EVTqKkrk c7N8g/k7gejheVyiqHaf75UqKzUudxsZRDMyoXholc+lgw8heU7K3V5d8ZRROkVQs34w8fyamtuaw Cl8OJW51ivBxdUJILrzg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i6IvS-0006w8-2c; Fri, 06 Sep 2019 18:25:38 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i6IvO-0006vm-UF for linux-arm-kernel@lists.infradead.org; Fri, 06 Sep 2019 18:25:36 +0000 Received: by mail-pg1-x543.google.com with SMTP id w10so3934792pgj.7 for ; Fri, 06 Sep 2019 11:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=hi4I00yzrvjyDfq4Sb0LtZ///vr5wch4QIwVVeeu58U=; b=tgPNLCytwqi6Eg7kgmztBs/cNpNh9cxkPtPcpl5lRVJoPELYoaUwQ8Mv9YiWOTwGw3 IzabFz5Bg5srMnqvFJ3uIt/IkEwDZktKRRfbIaTjZfIaVW6612RjMfe2d8YgKEELbgXS ghlp9nGO078teOa1dpUSBFq0kz9UYTvqT9Bh5pEbnq4/HtDVEUELnm0enHbVVbYiUny2 5fXqfXoMKFX6naNJRRmm1V2w1xubXFvNZtIJQSH5TD4O9+L4nKJWyd4a2p5Pyg89EuaN lPcLDOlfnHWx5N5AkcKJIRYPZzeSzZNnyOYT1eMGJkr6eRrDGLB7bqILDTeYo6aPqRiY B2eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=hi4I00yzrvjyDfq4Sb0LtZ///vr5wch4QIwVVeeu58U=; b=jseDhR2s3pFyFBE9KcIqpqSgzsiGiBacMP2GMOfXw3bsHXkA3A7NOhNzOzdRiFJ4wx KUSikxS46Y3VIZ3//H6y0e5ryjClH5AUccnLHBVshNPrhOXM7hCVTjr7gdYkQptThxGG NAWSTdj7mOYmGzo6gcny4IsZtj50F1IVQovp8ZL54VKGLm+ZysxEYKnIH+6Pdo8nc7IC uvLejPSTllV4Sb+64iKvZo06IxdDUq6hJSWf8pRFx+uKpTqSNweezErZLaL/GLkjXQd9 448wGy7oWClUMl9Boat2in59++BwMrpYyXLTmbxYUO70GZGwMDqSoth4rfBYUWakkAPC ocFQ== X-Gm-Message-State: APjAAAV2aTVbKH8fQnUpwY1EpnP39+ZSQfZAYFUxoLv6u7ahamRQHk4K 0GuHzlmt5VMenhSuLWbLAAC8p9l1sL8= X-Google-Smtp-Source: APXvYqyeiG+qz99HWZk7tAxTHFq2pCo/5SMXlzP6RqwmzOV6EmB6TEiXu9iDoH0GK5MAewVwnReY8A== X-Received: by 2002:a65:62cd:: with SMTP id m13mr9076178pgv.437.1567794333735; Fri, 06 Sep 2019 11:25:33 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id j18sm7684471pfh.70.2019.09.06.11.25.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2019 11:25:33 -0700 (PDT) Date: Fri, 6 Sep 2019 11:25:30 -0700 From: Bjorn Andersson To: Stephen Boyd Subject: Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings Message-ID: <20190906182530.GD11938@tuxbook-pro> References: <5d694878.1c69fb81.5f13b.ec4f@mx.google.com> <20190830164520.GK26807@tuxbook-pro> <5d696ad2.1c69fb81.977ea.39e5@mx.google.com> <20190903173924.GB9754@jackp-linux.qualcomm.com> <5d6edee5.1c69fb81.a3896.1d05@mx.google.com> <20190903233410.GQ26807@tuxbook-pro> <20190905175802.GA19599@jackp-linux.qualcomm.com> <5d71edf5.1c69fb81.1f307.fdd6@mx.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5d71edf5.1c69fb81.1f307.fdd6@mx.google.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190906_112534_990256_F8F67513 X-CRM114-Status: GOOD ( 23.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, robh@kernel.org, Jack Pham , devicetree@vger.kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, khasim.mohammed@linaro.org, linux-kernel@vger.kernel.org, kishon@ti.com, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, Jorge Ramirez , shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu 05 Sep 22:26 PDT 2019, Stephen Boyd wrote: > Quoting Jack Pham (2019-09-05 10:58:02) > > Hi Jorge, Bjorn, > > = > > On Thu, Sep 05, 2019 at 09:18:57AM +0200, Jorge Ramirez wrote: > > > On 9/4/19 01:34, Bjorn Andersson wrote: > > > > On Tue 03 Sep 14:45 PDT 2019, Stephen Boyd wrote: > > > >> that would need an of_regulator_get() sort of API that can get the > > > >> regulator out of there? Or to make the connector into a struct dev= ice > > > >> that can get the regulator out per some generic connector driver a= nd > > > >> then pass it through to the USB controller when it asks for it. Ma= ybe > > > >> try to prototype that out? > > > >> > > > > = > > > > The examples given in the DT bindings describes the connector as a = child > > > > of a PMIC, with of_graph somehow tying it to the various inputs. Bu= t in > > > > these examples vbus is handled by implicitly inside the MFD, where > > > > extcon is informed about the plug event they toggle vbus as well. > > > > = > > > > In our case we have a extcon-usb-gpio to detect mode, which per Jor= ge's > > > > proposal will trickle down to the PHY and become a regulator calls = on > > > > either some external regulator or more typically one of the charger= s in > > > > the system. > > = > > Interesting you mention extcon-usb-gpio. I thought extcon at least from > > bindings perspective is pass=C3=A9 now. Maybe this is what you need (ju= st > > landed in usb-next): > > = > > usb: common: add USB GPIO based connection detection driver > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?= h=3Dusb-next&id=3D4602f3bff2669012c1147eecfe74c121765f5c56 > > = > > dt-bindings: usb: add binding for USB GPIO based connection detection d= river > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?= h=3Dusb-next&id=3Df651c73e71f53f65e9846677d79d8e120452b59f > > = > > Fortunately this new driver might check the right boxes for you: > > - usb connector binding > > - ID detect GPIO > > - vbus-supply regulator > > = > > With that, I think you can also keep the connector subnode out of the > > SSPHY node well, and similarly get rid of the vbus toggle handling from > > the PHY driver. > > = > > The big thing missing now is that this driver replaces extcon > > completely, so we'll need handling in dwc3/dwc3-qcom to retrieve the > > role switch state to know when host mode is entered. I saw this a while > > back but don't think it got picked up: > > = > > https://patchwork.kernel.org/patch/10909981/ > > = > = > Yes this looks like the approach that should be taken. One question > though, is this a micro-b connector or a type-c connector on the board? > I thought it was a type-c, so then this USB gpio based connection driver > isn't an exact fit? > = For this particular case it's a type c connector, but the port controller is operated completely passively (and there's no PD or DP involved), so the GPIO based approach seems like a good fit. Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel