From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 572FDC49ED6 for ; Wed, 11 Sep 2019 11:44:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2896D20872 for ; Wed, 11 Sep 2019 11:44:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NQXie6lT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2896D20872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wnT6xZSdv0SXTL0tahf3QmJ6QJZ9r5Ut4a2ztHWs/9Y=; b=NQXie6lT1a+yic 1VhyCOTb/hOPiHEbsiTBERabUgGZKi2rKdL1s3BQSqTsmlyXTMXvfAi3zpQFlApw92stiRhKkWkCD QKQoY1Hkya1PjhjJlMxil5wqOMwqL7n/Ur891m9nb7BKNRVrak84siaF7s82iWLIlPuPtLrwleYYz bl0i02Pn0jCNou21FoOaFoV9NxTFVB8tC0JWUJ01vaHGiz+j7y484n536IUbcw7Kv9als7xKzcbC1 2jWO0yCFHaBIdu3sedJNdZCFbYndD7Phocrr6Z8Mu/hDV+OvbQs2XyLmnIZQs/Tz2og+q7JT1XtcL FK6T5fxDrsYP4O9l5Zhw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i812Z-0000j3-0l; Wed, 11 Sep 2019 11:44:03 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i811i-0008UG-4G; Wed, 11 Sep 2019 11:43:12 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2019 04:43:07 -0700 X-IronPort-AV: E=Sophos;i="5.64,489,1559545200"; d="scan'208";a="360110894" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2019 04:43:03 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id B2DE220B6B; Wed, 11 Sep 2019 14:43:00 +0300 (EEST) Date: Wed, 11 Sep 2019 14:43:00 +0300 From: Sakari Ailus To: Tomasz Figa Subject: Re: [V2, 2/2] media: i2c: Add more sensor modes for ov8856 camera sensor Message-ID: <20190911114300.GI5781@paasikivi.fi.intel.com> References: <20190910130446.26413-1-dongchun.zhu@mediatek.com> <20190910130446.26413-3-dongchun.zhu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190911_044310_867597_31370C93 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , andriy.shevchenko@linux.intel.com, srv_heupstream , devicetree@vger.kernel.org, shengnan.wang@mediatek.com, Louis Kuo , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Dongchun Zhu , Matthias Brugger , Cao Bing Bu , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tomasz, On Wed, Sep 11, 2019 at 07:12:02PM +0900, Tomasz Figa wrote: > Hi Sakari, > > On Tue, Sep 10, 2019 at 10:05 PM wrote: > > > > From: Dongchun Zhu > > > > This patch mainly adds two more sensor modes for OV8856 CMOS image sensor. > > That is, the resolution of 1632*1224 and 3264*2448, corresponding to the bayer order of BGGR. > > The sensor revision also differs in some OTP register. > > > > Signed-off-by: Dongchun Zhu > > --- > > drivers/media/i2c/ov8856.c | 654 +++++++++++++++++++++++++++++++++++++++++++-- > > 1 file changed, 639 insertions(+), 15 deletions(-) > > > > What do you think about the approach taken by this patch? > > My understanding is that the register arrays being added by it can be > only used with 24MHz input clock, while the existing ones are for > 19.2MHz. That means that this patch makes the driver expose completely > different modes (resolutions, mbus formats) depending on the input > clock. Are we okay with this? These register list based drivers only support a tiny subset of configurations a sensor can support, and the number of those configurations may be amended over time. I don't see a problem in choosing a different set of available configurations based on the external clock frequency; that may, after all, cause that some of the configurations, at a particular frame rate, are not even achievable --- albeit this is perhaps unlikely in this case. In practice, it's often the case that the sensor vendor provides these configurations and the vendor may provide different configurations (including output resolutions etc.) to different parties. So it may well be the submitter of the patch would also not have access to similar configurations (output size, cropping etc.) that now exist in the driver. I'll review the patch itself soonish. -- Regards, Sakari Ailus sakari.ailus@linux.intel.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel