From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 134FCC4CEC7 for ; Sun, 15 Sep 2019 20:17:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7184214AF for ; Sun, 15 Sep 2019 20:17:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OTiI/iJe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RPq2joGQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7184214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6zFnSHXrz5jgWp21Gc7+S6XHuTELBnNNOUJnuo36V1k=; b=OTiI/iJeXfwpPt YNY3WmikijaUQXniozO7NEOeuiBwzohlE/sR6nWCS0A+c08W3C1qmL/RYqZQNkLjLPXEsj/rF/9kh JEIn6xJgqhTPj40DONUVd7ryLczc7YeF0V/mQglOX1QbyggQtub4eI2WFRK9nSdXL5URSeW3VzHdm uccGw73HZQ6ovf2IF9feezPyEbvLPhrol12LAyjmvZRvkiX7HgnNyBRfUwsSD4xyoiQT8c3bMRCta filjXmqqekPH/SzCXb3KPcsRyx350LV8g/qCp4MNvEs8/Zjz851irqhDMrRZK0xDbHRtIYXzuReki XvYaiq39Csaph+5cx02A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9ax4-0003UZ-UM; Sun, 15 Sep 2019 20:16:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9ax1-0003UC-NJ for linux-arm-kernel@lists.infradead.org; Sun, 15 Sep 2019 20:16:53 +0000 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 50F5D214AF; Sun, 15 Sep 2019 20:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568578610; bh=d/HrE/iGcEqOEmCdLte6zzmoLMwAvKRRiPAXELWKn3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RPq2joGQ2Try6Oplud7Geb+58heA5O9WPpaFV+TgsTLEdLYxZJtAWLKcnE5WvUcgY 51KdN4G0BdcTMn14Z9pd/5PzdnnYrnnj2ZYSQecLJdj/ECyqpPSRa2m6rBwH22i8jU od3ywG3yXgqXps+9ze5whibROFPS8x+liH1IgW64= Date: Sun, 15 Sep 2019 13:16:48 -0700 From: Eric Biggers To: Corentin Labbe Subject: Re: [PATCH] crypto: sun4i-ss: erase key after use Message-ID: <20190915201648.GA1704@sol.localdomain> Mail-Followup-To: Corentin Labbe , davem@davemloft.net, herbert@gondor.apana.org.au, mripard@kernel.org, wens@csie.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, stable@vger.kernel.org References: <20190915183536.3835-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190915183536.3835-1-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190915_131651_784940_0F5C2F9C X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: herbert@gondor.apana.org.au, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, mripard@kernel.org, wens@csie.org, linux-crypto@vger.kernel.org, stable@vger.kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Sep 15, 2019 at 08:35:36PM +0200, Corentin Labbe wrote: > When a TFM is unregistered, the sun4i-ss driver does not clean the key used, > leaking it in memory. > This patch adds this absent key cleaning. > > Fixes: 6298e948215f ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator") > Cc: # 4.3+ > Signed-off-by: Corentin Labbe > --- > drivers/crypto/sunxi-ss/sun4i-ss-cipher.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c b/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c > index fa4b1b47822e..60d99370a4ec 100644 > --- a/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c > +++ b/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c > @@ -503,6 +503,8 @@ int sun4i_ss_cipher_init(struct crypto_tfm *tfm) > void sun4i_ss_cipher_exit(struct crypto_tfm *tfm) > { > struct sun4i_tfm_ctx *op = crypto_tfm_ctx(tfm); > + > + memzero_explicit(op->key, op->keylen); > crypto_free_sync_skcipher(op->fallback_tfm); > } > > -- > 2.21.0 > It's already zeroed by the kzfree() in crypto_destroy_tfm(). - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel