From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Tanmay Vilas Kumar Jagdale <tanmay@marvell.com>
Cc: Tomasz Nowicki <tnowicki@marvell.com>,
Jayachandran Chandrasekharan Nair <jnair@marvell.com>,
Ganapatrao Kulkarni <gkulkarni@marvell.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"suzuki.poulose@arm.com" <suzuki.poulose@arm.com>
Subject: Re: [PATCH v2] coresight: etm4x: Add support for ThunderX2
Date: Mon, 16 Sep 2019 13:58:26 -0600 [thread overview]
Message-ID: <20190916195826.GA16787@xps15> (raw)
In-Reply-To: <1568096664-13252-1-git-send-email-tanmay@marvell.com>
On Tue, Sep 10, 2019 at 06:25:02AM +0000, Tanmay Vilas Kumar Jagdale wrote:
> Add ETMv4 periperhal ID for Marvell's ThunderX2 chip.
> This chip contains ETMv4.1 version.
>
> Signed-off-by: Tanmay Jagdale <tanmay@marvell.com>
mpoirier@xps15:~/work/coresight/kernel-maint$ ./scripts/checkpatch.pl 0001-coresight-etm4x-Add-support-for-ThunderX2.patch
WARNING: Missing Signed-off-by: line by nominal patch author 'Tanmay Vilas Kumar Jagdale <tanmay@marvell.com>'
total: 0 errors, 1 warnings, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
0001-coresight-etm4x-Add-support-for-ThunderX2.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS
> ---
> Changes since v1:
> - Updated commit message.
> - Use UCI to identify ETMv4.
> - Remove addition of ETMv4.1 version checks.
>
> drivers/hwtracing/coresight/coresight-etm4x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
> index a128b5063f46..47839b4a8bc0 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
> @@ -1211,6 +1211,7 @@ static const struct amba_id etm4_ids[] = {
> CS_AMBA_UCI_ID(0x000f0211, uci_id_etm4),/* Qualcomm Kryo */
> CS_AMBA_ID(0x000bb802), /* Qualcomm Kryo 385 Cortex-A55 */
> CS_AMBA_ID(0x000bb803), /* Qualcomm Kryo 385 Cortex-A75 */
> + CS_AMBA_UCI_ID(0x000cc0af, uci_id_etm4),/* Marvell ThunderX2 */
> {},
> };
>
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-16 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 6:25 [PATCH v2] coresight: etm4x: Add support for ThunderX2 Tanmay Vilas Kumar Jagdale
2019-09-16 19:58 ` Mathieu Poirier [this message]
2019-09-17 8:39 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916195826.GA16787@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=gkulkarni@marvell.com \
--cc=jnair@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=tanmay@marvell.com \
--cc=tnowicki@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox