From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBC1FC4CECD for ; Tue, 17 Sep 2019 10:42:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACC3C21852 for ; Tue, 17 Sep 2019 10:42:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n51ctaBk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="kR8fi0sP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACC3C21852 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xXsUhL8ubEvFC1MFGLtYjSrclB0GL2ZHP0jzNHeergo=; b=n51ctaBkBgqvLV iQlnuHYrJJ029hDQS8l75/FIspwKAHsn/fN36J9HXMFDO/6rP2VP7GBIg9IpJSzVIqZPe+5l9Wcgc LW2GgZwHmsbnyL0Z6oSFaWcAxc+qBK5+y45mO5yfEcaoEDq4V4lxb8Ajqdry0S8KW72U9nQDBXdy3 DvUw12lLdm2aIBmLC/3ncMy0TRE2iS96TaWTwJfrrrZ4jWuTIIFr31BLhXz+2YEhw17K+9E3CnGcH pQyHOXg+LvWquLUBhUyg19/wT0My1F6g4gR1UtQfK/saRoivQch4ZXIm+xkkvCWv5AYU7KK3sYDnw wKvZXYx8lgIpYbzpuUFA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAAw4-0007GT-U6; Tue, 17 Sep 2019 10:42:16 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAAw1-0007FV-FE for linux-arm-kernel@lists.infradead.org; Tue, 17 Sep 2019 10:42:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7qdiIJk4N9Bw2jD8YfHU3M1P1qr7Jq1pFBN4pn0Y7QE=; b=kR8fi0sPqUcDaKIN5TMlRbh+d PvTeYxQssHli6bHdeCdwUbDO2p00D/XFd36WblSWfQMe9yeeXXwPwYYpvLx1Q90IpVgcy/LAiZMeP Rtysa1EWAI7Hie/KB3ozKNLvc8kmXn+dgO2utj0yy9/bY3waEfXNeTUgo6+rsSe9uDohtwtu7TKW1 VSFAlib0O5FtHD+Kg74BkSxgHTtZ7u48gOHR4ept3H8TjgAcOvZ9S5x0uB9oxDi5ouA/6eE02zXCb rsJXigc/dz3MGkrtGt3PmFcKxW8G0t2MTbiPfT+QvUYoReCYTAlMCtNEuctjwc7mo9nf23c26kJmU O7MO9RWUQ==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:33066) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iAAvq-0001AJ-Br; Tue, 17 Sep 2019 11:42:02 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1iAAvo-0001DN-D5; Tue, 17 Sep 2019 11:42:00 +0100 Date: Tue, 17 Sep 2019 11:42:00 +0100 From: Russell King - ARM Linux admin To: Adrian Hunter Subject: Re: [REGRESSION] sdhci no longer detects SD cards on LX2160A Message-ID: <20190917104200.GJ25745@shell.armlinux.org.uk> References: <20190916171509.GG25745@shell.armlinux.org.uk> <20190917081931.GI25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190917081931.GI25745@shell.armlinux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190917_034213_508775_0BD8C937 X-CRM114-Status: GOOD ( 20.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mmc@vger.kernel.org, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 17, 2019 at 09:19:31AM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 10:06:12AM +0200, Marc Gonzalez wrote: > > On 16/09/2019 19:15, Russell King - ARM Linux admin wrote: > > > > > The platform has an iommu, which is in pass-through mode, via > > > arm_smmu.disable_bypass=0. > > > > Could be 954a03be033c7cef80ddc232e7cbdb17df735663 > > "iommu/arm-smmu: Break insecure users by disabling bypass by default" > > > > Although it had already landed in v5.2 > > It is not - and the two lines that you quoted above are sufficient > to negate that as a cause. (Please read the help for the option that > the commit referrs to.) > > In fact, with bypass disabled, the SoC fails due to other masters. > That's already been discussed privately between myself and Will > Deacon. > > arm_smmu.disable_bypass=0 re-enables bypass mode irrespective of > the default setting in the Kconfig. Adding some further debugging, and fixing the existing ADMA debugging shows: mmc0: ADMA error: 0x02000000 So this is an ADMA error without the transfer having completed. mmc0: sdhci: Blk size: 0x00000008 | Blk cnt: 0x00000001 The block size is 8, with one block. mmc0: sdhci: ADMA Err: 0x00000009 | ADMA Ptr: 0x000000236df1d20c The ADMA error is a descriptor error at address 0x000000236df1d20c. The descriptor table contains (including the following entry): mmc0: sdhci: 236df1d200: DMA 0x000000236d40e980, LEN 0x0008, Attr=0x23 mmc0: sdhci: 236df1d20c: DMA 0x0000000000000000, LEN 0x0000, Attr=0x00 The descriptor table contains one descriptor of 8 bytes, is marked as the last (END bit set) and is at DMA address 0x236df1d200. The following descriptor is empty, with VALID=0. One may be tempted to blame it on the following descriptor, but having had another example on eMMC while userspace was booting (rootfs on eMMC): mmc1: ADMA error: 0x02000000 mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000099 mmc1: sdhci: ADMA Err: 0x00000006 | ADMA Ptr: 0x000000236dbfa26c mmc1: sdhci: 236dbfa200: DMA 0x000000236c25c000, LEN 0x2000, Attr=0x21 mmc1: sdhci: 236dbfa20c: DMA 0x000000236938c000, LEN 0x0000, Attr=0x21 mmc1: sdhci: 236dbfa218: DMA 0x000000236939c000, LEN 0x5000, Attr=0x21 mmc1: sdhci: 236dbfa224: DMA 0x0000002368545000, LEN 0x1000, Attr=0x21 mmc1: sdhci: 236dbfa230: DMA 0x00000023684f1000, LEN 0x1000, Attr=0x21 mmc1: sdhci: 236dbfa23c: DMA 0x0000002368504000, LEN 0x2000, Attr=0x21 mmc1: sdhci: 236dbfa248: DMA 0x0000002368546000, LEN 0x2000, Attr=0x21 mmc1: sdhci: 236dbfa254: DMA 0x00000023684f2000, LEN 0x2000, Attr=0x21 mmc1: sdhci: 236dbfa260: DMA 0x0000002368500000, LEN 0x1000, Attr=0x23 mmc1: sdhci: 236dbfa26c: DMA 0x000000236b55d000, LEN 0x1000, Attr=0x21 ... which is interesting for several reasons: - The ADMA error register indicates a length mismatch error. The transfer was for 0x99 blocks of 0x200, which is 0x13200 bytes. Summing the ADMA lengths up to the last descriptor (length=0 is 0x10000 bytes) gives 0x20000 bytes. So the DMA table contains more bytes than the requested transfer. - The ADMA error register indicates ST_CADR, which is described as "This state is never set because do not generate ADMA error in this state." - The error descriptor is again after the descriptor with END=1, but this time has VALID=1. This _feels_ like a coherency issue, where the SDHCI engine is not correctly seeing the descriptor table, but then I would have expected userspace (which is basically debian stable) to fail to boot every time given that its rootfs is on eMMC. The other weird thing is if I wind the core MMC code back via: $ git diff -u 7559d612dff0..v5.3 drivers/mmc/core | patch -p1 -R and fix the lack of dma_max_pfn(), then SDHCI is more stable - not completely stable, but way better than plain v5.3. I don't see much in that diff which would be responsible for this - although it does seem that hch's DMA changes do make the problem more likely. (going from 1 in 3 boots with a problem to being not able to boot.) Note, with v5.2, I _never_ saw any ADMA errors, except if I disabled bypass mode on the IOMMU (but then I saw global smmu errors right from when the IOMMU had bypass disabled before MMC was probed - the reason being is the SoC is not currently setup to have the MMU bypass mode disabled.) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel