From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB92AC4CECD for ; Tue, 17 Sep 2019 16:36:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0F7B20665 for ; Tue, 17 Sep 2019 16:36:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WO/tzmWl"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YA0FtVOq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0F7B20665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8t9jw8S6w4U3SF9OVdclsBoPMHWx4ZIRHIqqGPvyTNg=; b=WO/tzmWlQfX0Qj gQxUSBdcqDlBMzQSYVDfdOXcSHRcgmjaAzgE5UGQ7ZWjaMRyjV9XgDj9X0yi4T/HyFy16xxTfl4Pu ouJu60I7nq+CBdEjOSFdO/fwi/LImuzFY26QtqoFRFmTNQjVHhvhWF69QCnFhmSOa2tW0CUNz54hg P7yEywGBdcDtZ2pJ0ue9/hI7K4d61uhl1cnfiBN8cheAINn7v8gEW7jhLoudA9GjZt4T5iaensVYz REmeKMselDhYaByW8TPxhcw7W8LomTYcIsuhN6N50KKsQfJB7ew9fe/DNqQTue9zYUlyjnQrTZnFz c8T0DrT8CKn4FVl21y+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAGT3-0002Vs-DB; Tue, 17 Sep 2019 16:36:41 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAGT0-0002Uu-Ba for linux-arm-kernel@lists.infradead.org; Tue, 17 Sep 2019 16:36:39 +0000 Received: by mail-pf1-x441.google.com with SMTP id y22so2490933pfr.3 for ; Tue, 17 Sep 2019 09:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6oL27CCsiCgWC+s9QdRYX453QCLZxLS2++aHbtnJhwo=; b=YA0FtVOqhPZ+x3BfaIoVZIEZexqC9TyNKApW9YBx6UryG5ITeV5G/PcVyovxlcN+mC os44E6Ij+VtAx8kdLvm5CDW3dSDIYirj+oo2lcs2vH01UDW4bGLLNb9WTGyjObDvjKoj fBuR+TQerwfgIFxcGZl8M9n99ztxdoJWyHTr3aKJskQWgCTjdqc3CzWAMMCPIWWV27uk r6QlYUhCtyjRpnvTXR0DG8uzBazHmw40E5sw5yAMAHs41eotxnNZMhM36rvMkaTMxCjz 4Q5hfisagPglftlQNRwob/iecOFYUAkervhL5SGw2H57K6310ejYzOFpMM61c3xeiltY gc0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6oL27CCsiCgWC+s9QdRYX453QCLZxLS2++aHbtnJhwo=; b=msp7R/nPvqW8HKaxEbgGpd6CphHuy685P+vgopSEbvE9JPdTrLSSGNKUN4zrDWfCg0 7F/GgrthdFz9NQj32/pjNK2ppFEHSXIiuegaWwwK14uTS3M6tp3bZqCRhacQlnuEW8oq neV4VzYEFAt3mXiREHgK6BKLRBXYLm8PvtSYhWLg/qvpZxjShKrDmypPhXNN+/4dzbdJ 8JsAEzSFSLuT0S9z+M15eW1slTHy787rP34VvxauXt6fcm1wZmh2BkrvnU7vKy3+qK2Q wBrr5F1EgLOdIEqR2Yf5sfTbY2GWc+IiiQfc41PbCD9Y8zf+enzZWl9PNhIXWMGGUILM mBxQ== X-Gm-Message-State: APjAAAUNWwqcia2zlqHD9c38eylAUoNgobWnA0YnF2GPhD7GrQVKr9gm p9Iq0+P93juCj57YvRWWK1u6 X-Google-Smtp-Source: APXvYqylABHbwwGnTpG+yB/f0dYMRAjI9T2OAHarx7EJA+9sLbutDPD4P64xC24J0U/cyFBf2nmCMw== X-Received: by 2002:a17:90a:fa0c:: with SMTP id cm12mr5692720pjb.137.1568738197253; Tue, 17 Sep 2019 09:36:37 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:111:7ed:2c13:36f7:e70f:4a47]) by smtp.gmail.com with ESMTPSA id w6sm8080461pfw.84.2019.09.17.09.36.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Sep 2019 09:36:36 -0700 (PDT) Date: Tue, 17 Sep 2019 22:06:28 +0530 From: Manivannan Sadhasivam To: Stephen Boyd Subject: Re: [PATCH v4 1/7] clk: actions: Fix factor clk struct member access Message-ID: <20190917163628.GA2615@Mani-XPS-13-9360> References: <20190916154546.24982-1-manivannan.sadhasivam@linaro.org> <20190916154546.24982-2-manivannan.sadhasivam@linaro.org> <20190917163419.4C4DD20665@mail.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190917163419.4C4DD20665@mail.kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190917_093638_392349_D543DE73 X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, ulf.hansson@linaro.org, linux-actions@lists.infradead.org, linus.walleij@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.liau@actions-semi.com, linux-clk@vger.kernel.org, robh+dt@kernel.org, afaerber@suse.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 17, 2019 at 09:34:18AM -0700, Stephen Boyd wrote: > Quoting Manivannan Sadhasivam (2019-09-16 08:45:40) > > Since the helper "owl_factor_helper_round_rate" is shared between factor > > and composite clocks, using the factor clk specific helper function > > like "hw_to_owl_factor" to access its members will create issues when > > called from composite clk specific code. Hence, pass the "factor_hw" > > struct pointer directly instead of fetching it using factor clk specific > > helpers. > > > > This issue has been observed when a composite clock like "sd0_clk" tried > > to call "owl_factor_helper_round_rate" resulting in pointer dereferencing > > error. > > > > While we are at it, let's rename the "clk_val_best" function to > > "owl_clk_val_best" since this is an owl SoCs specific helper. > > > > Fixes: 4bb78fc9744a ("clk: actions: Add factor clock support") > > Signed-off-by: Manivannan Sadhasivam > > Reviewed-by: Stephen Boyd > > --- > > I can apply this to clk-next? Yes, please :-) Rest can go through Ulf's tree. Thanks, Mani > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel