From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54988C4CEC4 for ; Wed, 18 Sep 2019 06:08:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 274BB20856 for ; Wed, 18 Sep 2019 06:08:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YcpgjtoL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="i2K8gJQM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 274BB20856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:From:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NGYrJpzKp6635Q502BsZ865ebtqrs0JQN1wQkcvzkeQ=; b=YcpgjtoLHyWZhV 5wLKRKAckfwEGFvM9LY1mddIP8JMS3Qv71IPtzmOBHDG1dchqn70qQYRgZjc26HNGN7UNXPBPIgz9 3+M/CJhZhe2gb/R6+/313OCPAXPDCpqP3squvzq8Dv+ic1nJPZ8tghiN6nd7+7U+OGVFWbQYW0qGJ vXJcJ+ZL14MBQxApN2+CWNFlBoS0TXnFpkDPhjjhoikpkUq8IzU0Hw0CzNipuPPcDXxv/sYhxIrk/ Wym84BWXl0/9qw3e7Sx4fizrz/JDl6+9fP9R3HyUXX3Z7uxlB1rBrz3g61tzm0RjGOV5yepJntM8S 6HBmnu/rEAu9sQ1zVYIQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAT8B-0007tO-Mx; Wed, 18 Sep 2019 06:07:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAT7j-0007XK-GP for linux-arm-kernel@lists.infradead.org; Wed, 18 Sep 2019 06:07:32 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1A60220856; Wed, 18 Sep 2019 06:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568786851; bh=jNhbz67CJr/g2fdjXe+N+K8ckAY7k1eWl83twN0NrXA=; h=In-Reply-To:References:Cc:To:From:Subject:Date:From; b=i2K8gJQM0HbM2ZNZSIwPgK+a8ru9cYl2eYOub+t5Aa/Mll4ya7fal7MFOxBo3K1dg pdLVcFKnMNOcHv4rPXBY4N8/rM/YuFsCVOZ0vr/m37Lcis9s47eUYJ2fcQdBGS0Hl5 qXtjMqa4X5+nBV7I8vdwJIESc5HPNhuRphWFOQIc= MIME-Version: 1.0 In-Reply-To: <1568043491-20680-4-git-send-email-peng.fan@nxp.com> References: <1568043491-20680-1-git-send-email-peng.fan@nxp.com> <1568043491-20680-4-git-send-email-peng.fan@nxp.com> To: "festevam@gmail.com" , "mturquette@baylibre.com" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" , Peng Fan From: Stephen Boyd Subject: Re: [PATCH V3 3/4] clk: imx: imx8mm: fix pll mux bit User-Agent: alot/0.8.1 Date: Tue, 17 Sep 2019 23:07:30 -0700 Message-Id: <20190918060731.1A60220856@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190917_230731_753909_461D3C1D X-CRM114-Status: UNSURE ( 7.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Fan , Abel Vesa , Anson Huang , "linux-kernel@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , Leonard Crestez , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jacky Bai Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Peng Fan (2019-09-08 20:39:44) > From: Peng Fan > > pll BYPASS bit should be kept inside pll driver for glitchless freq > setting following spec. If exposing the bit, that means pll driver and > clk driver has two paths to touch this bit, which is wrong. > > So use EXT_BYPASS bit here. > > And drop uneeded set parent, because EXT_BYPASS default is 0. > > Fixes: ba5625c3e272 ("clk: imx: Add clock driver support for imx8mm") > Suggested-by: Jacky Bai > Reviewed-by: Leonard Crestez > Signed-off-by: Peng Fan > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel