From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D125BC4CEC4 for ; Wed, 18 Sep 2019 06:08:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A434E20856 for ; Wed, 18 Sep 2019 06:08:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N6T1sNbe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="VdmBBFmX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A434E20856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:From:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3dbQEYYQRfIwZ/IShpEPF1VtwcC/SkDOwz3mRa2wMmQ=; b=N6T1sNbebQk82Z c4Z6Djx+C75kNPtOLyg3Zm6Xm2oeMjZ2s+ENWj5SaFxs///ldrn++t8Cbztmm2gn4Zhe8hXcNcYng XggClYOG6Qaf5p6MNcxb5O/8EzX71h6p6WI8ka7mvMAGLuv6jYXzS6Up+Ost3ziuVwjGhESNuGG9V ERZDGXquduHDGDNMn6yEeMX8gDJMhCIfXNotJcqz2rdrXzJ2SyVICiZCogdA4Fk1RS+8webJjxTOe FuqvsuDZvsvtaH0RYXsBXXWy3QxNKqqX+zpTZDhw0TFJRYBaG4TLsMX95L/rneBPGoMk57iUbJwMH OSwyGWaSZUtDO0tTbXcA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAT8R-00088M-F3; Wed, 18 Sep 2019 06:08:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAT7n-0007ax-5J for linux-arm-kernel@lists.infradead.org; Wed, 18 Sep 2019 06:07:36 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B90EA20856; Wed, 18 Sep 2019 06:07:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568786854; bh=Ts05YE0IjGolvN6Z7Hv/3J3qFt2qBGevkokf4x6n7e0=; h=In-Reply-To:References:Cc:To:From:Subject:Date:From; b=VdmBBFmXgopq7WcGmLHBMOdq5W0g7H88njURoDcrLWaKfJehCItaEm+WjAX/cGPj0 aHSQG2CE+Csjnw3ZTuB0GlFyoXYDY42es+HDJhbIQ7LvhScgwRUvAMXNf/UCej6nTF ImrBB8oBgAcQcaYSzx7PFhDUTBYCi+PaevSVcNc8= MIME-Version: 1.0 In-Reply-To: <1568043491-20680-5-git-send-email-peng.fan@nxp.com> References: <1568043491-20680-1-git-send-email-peng.fan@nxp.com> <1568043491-20680-5-git-send-email-peng.fan@nxp.com> To: "festevam@gmail.com" , "mturquette@baylibre.com" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" , Peng Fan From: Stephen Boyd Subject: Re: [PATCH V3 4/4] clk: imx: imx8mn: fix pll mux bit User-Agent: alot/0.8.1 Date: Tue, 17 Sep 2019 23:07:33 -0700 Message-Id: <20190918060734.B90EA20856@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190917_230735_338711_45AD8B88 X-CRM114-Status: UNSURE ( 7.35 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Fan , Abel Vesa , Anson Huang , "linux-kernel@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , Leonard Crestez , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jacky Bai Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Peng Fan (2019-09-08 20:39:50) > From: Peng Fan > > pll BYPASS bit should be kept inside pll driver for glitchless freq > setting following spec. If exposing the bit, that means pll driver and > clk driver has two paths to touch this bit, which is wrong. > > So use EXT_BYPASS bit here. > > And drop uneeded set parent, because EXT_BYPASS default is 0. > > Suggested-by: Jacky Bai > Reviewed-by: Leonard Crestez > Signed-off-by: Peng Fan > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel