From: Maxime Ripard <mripard@kernel.org>
To: megous@megous.com
Cc: David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Chen-Yu Tsai <wens@csie.org>, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting
Date: Wed, 18 Sep 2019 16:17:34 +0200 [thread overview]
Message-ID: <20190918141734.kerdbbaynwutrxf6@gilmour> (raw)
In-Reply-To: <20190914220337.646719-1-megous@megous.com>
[-- Attachment #1.1: Type: text/plain, Size: 753 bytes --]
Hi,
On Sun, Sep 15, 2019 at 12:03:37AM +0200, megous@megous.com wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> There are various issues that this re-work of sun8i_[uv]i_layer_enable
> function fixes:
>
> - Make sure that we re-initialize zpos on reset
> - Minimize register updates by doing them only when state changes
> - Fix issue where DE pipe might get disabled even if it is no longer
> used by the layer that's currently calling sun8i_ui_layer_enable
> - .atomic_disable callback is not really needed because .atomic_update
> can do the disable too, so drop the duplicate code
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
It looks like these fixes should be in separate patches. Is there any
reason it's not the case?
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-18 14:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-14 22:03 [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting megous
2019-09-14 22:15 ` Ondřej Jirman
2019-09-18 14:17 ` Maxime Ripard [this message]
2019-09-18 15:23 ` Ondřej Jirman
2019-09-18 20:16 ` Maxime Ripard
2019-09-19 12:20 ` Ondřej Jirman
2019-09-19 13:12 ` Ondřej Jirman
2019-09-20 15:11 ` Maxime Ripard
2019-09-24 12:40 ` Ondřej Jirman
2019-09-30 15:59 ` Ondřej Jirman
2019-10-03 11:38 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918141734.kerdbbaynwutrxf6@gilmour \
--to=mripard@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=megous@megous.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox