From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C134FC4CECE for ; Thu, 19 Sep 2019 07:59:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9824821848 for ; Thu, 19 Sep 2019 07:59:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VKLhChkP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9824821848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P+h2IXfFm1uJRz/k5d+JuG6iPMSZjPxnornqW0GuGkM=; b=VKLhChkPLnjsb5 D/CsVsrx31OCCGMQZ9L95KlrYCoOcvdsn3tGphiO9n7R8ElzE4qzKnjA+JvaCAGlmdg6jUGhSsyX8 bWAPhnOTIilGAoJOLf7cGO0q4uWqDh/qXmdWsBz6papjnCLeiTTGZcK0qENB74we7i84l94BImYlw g3zU/IxDTFbhSxTXCoEjzxx3wIHmwWIY63CPFoiXnBnREtDDE2AOvYs6rYu21s4BEUoz38WN0DXt/ tDceYjqeE98QHRsPqGfJfUyA9VXWOeD9Ea3wrzbviexZR5LM44ne3K+sxjnZPdyneVwIx1WQaTc06 cmhK5FFXZ6ux5FMdAUjA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iArLv-0003VZ-Sg; Thu, 19 Sep 2019 07:59:48 +0000 Received: from mail-wm1-f66.google.com ([209.85.128.66]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iArLe-0003QN-4L for linux-arm-kernel@lists.infradead.org; Thu, 19 Sep 2019 07:59:35 +0000 Received: by mail-wm1-f66.google.com with SMTP id a6so3147118wma.5 for ; Thu, 19 Sep 2019 00:59:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yy/C8I+qsXanLkKnOE9DEzrTwx4wGS6sU0a5cnC4r3Y=; b=MqfjdV+MK+r5weNWnpFoW4JaiYapDS5pVPlGWzveucHECj6Oco/a9klcS05yvlRgb4 pJPt91hWAmdzJoTGbuATNHdtFxTsOEXM+zDkjED2RXjHyWAO/ZAFVPfj0YZn7AFsYtUr f8wUe7eYNsohBWTbTLdntshJEPMk6GLk3saUJIoTX82Xn+HVBcnUdOKzoeHTLviLSkqj s0w9aoG34diXATlg4akJ9QkDF6rhu1UwTLfkWq1W1BpXKtiK8kr1u7MBGiE1Iy7EGJoI iWHWeIko0rJm3SXqXG4EcH8Ng03u2ei7dch+UetBnHvIx3hH3UkIWhYAUJTDFasy13Qt N5Iw== X-Gm-Message-State: APjAAAXG6DSugxMWuCQ9A9+AmuZUZnuI9cwr9WfqIKEGUQffO1iMMhnJ fUALtcnXaCgldUoYy058K+itev1P X-Google-Smtp-Source: APXvYqy2o5grp6Rt7mjN78sEBbbA8GDZ94gEvftdESomIA11VKGYguGkQaar5ppls9OkNxJQa4i9kg== X-Received: by 2002:a1c:8097:: with SMTP id b145mr1641289wmd.29.1568879967329; Thu, 19 Sep 2019 00:59:27 -0700 (PDT) Received: from pi3 ([194.230.155.145]) by smtp.googlemail.com with ESMTPSA id q22sm3339362wmj.5.2019.09.19.00.59.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2019 00:59:26 -0700 (PDT) Date: Thu, 19 Sep 2019 09:59:24 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Subject: Re: [PATCH v1 2/9] mfd: wm8994: Add support for MCLKn clock control Message-ID: <20190919075924.GB13195@pi3> References: <20190918104634.15216-1-s.nawrocki@samsung.com> <20190918104634.15216-3-s.nawrocki@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190918104634.15216-3-s.nawrocki@samsung.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190919_005930_892979_C0C5ACEA X-CRM114-Status: GOOD ( 17.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, ckeepax@opensource.cirrus.com, b.zolnierkie@samsung.com, sbkim73@samsung.com, patches@opensource.cirrus.com, lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 18, 2019 at 12:46:27PM +0200, Sylwester Nawrocki wrote: > The WM1811/WM8994/WM8958 audio CODEC DT bindings specify two optional > clocks: "MCLK1", "MCLK2". Add code for getting those clocks in the MFD > part of the wm8994 driver so they can be further handled in the audio > CODEC part. I think these are needed only for the codec so how about getting them in codec's probe? Best regards, Krzysztof > > Signed-off-by: Sylwester Nawrocki > --- > drivers/mfd/wm8994-core.c | 9 +++++++++ > include/linux/mfd/wm8994/core.h | 9 +++++++++ > 2 files changed, 18 insertions(+) > > diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c > index 1e9fe7d92597..02c19a0bdeb0 100644 > --- a/drivers/mfd/wm8994-core.c > +++ b/drivers/mfd/wm8994-core.c > @@ -7,6 +7,7 @@ > * Author: Mark Brown > */ > > +#include > #include > #include > #include > @@ -333,6 +334,14 @@ static int wm8994_device_init(struct wm8994 *wm8994, int irq) > > dev_set_drvdata(wm8994->dev, wm8994); > > + wm8994->mclk[WM8994_MCLK1].id = "MCLK1"; > + wm8994->mclk[WM8994_MCLK2].id = "MCLK2"; > + > + ret = devm_clk_bulk_get_optional(wm8994->dev, ARRAY_SIZE(wm8994->mclk), > + wm8994->mclk); > + if (ret != 0) > + return ret; > + > /* Add the on-chip regulators first for bootstrapping */ > ret = mfd_add_devices(wm8994->dev, 0, > wm8994_regulator_devs, > diff --git a/include/linux/mfd/wm8994/core.h b/include/linux/mfd/wm8994/core.h > index e8b093522ffd..320297a1b70c 100644 > --- a/include/linux/mfd/wm8994/core.h > +++ b/include/linux/mfd/wm8994/core.h > @@ -10,12 +10,19 @@ > #ifndef __MFD_WM8994_CORE_H__ > #define __MFD_WM8994_CORE_H__ > > +#include > #include > #include > #include > > #include > > +enum { > + WM8994_MCLK1, > + WM8994_MCLK2, > + WM8994_NUM_MCLK > +}; > + > enum wm8994_type { > WM8994 = 0, > WM8958 = 1, > @@ -60,6 +67,8 @@ struct wm8994 { > struct device *dev; > struct regmap *regmap; > > + struct clk_bulk_data mclk[WM8994_NUM_MCLK]; > + > bool ldo_ena_always_driven; > > int gpio_base; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel