From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 264B4C3A5A6 for ; Thu, 19 Sep 2019 17:24:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC02D21928 for ; Thu, 19 Sep 2019 17:24:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pe/k/c6x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC02D21928 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ukVi0VwxbDtvxOc4IizSFXUaBncRlSLswxEshv+Q+TA=; b=Pe/k/c6x1Y0QH/ lIlGKJpS30iEs/m3/apRpygdhKot+0OjOftE47E61eu+MziR3/dGSa6a/t/92wzS7Ws+2wCKg0rRV nX1SW83hGLT50BDhwxyF62EbdVaG74QDmhTjLx4euCv3IUzfCEe85HKcbV9BvF4KOgKC/AM6Z0fOk tCQTJsnZxLLsRgMUrjSsp+fF2MPMnMNvm2M0jBHmicRpauYdedG2usW6fDY2s5MhH46HrkqXFheuf D0qH+mkEf3emeKV23uQNUgWFnjj3//NoqJNFeLFWp2Z3jS7qCB9Ol1fEpP7vu82N91J+mR/ik8q/h BjMPlzLQ0cB4wVG1wxMw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iB0A3-0006tP-Sa; Thu, 19 Sep 2019 17:24:07 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iB09z-0006sb-4t for linux-arm-kernel@lists.infradead.org; Thu, 19 Sep 2019 17:24:04 +0000 X-Originating-IP: 90.65.161.137 Received: from localhost (lfbn-1-1545-137.w90-65.abo.wanadoo.fr [90.65.161.137]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 090811BF210; Thu, 19 Sep 2019 17:23:51 +0000 (UTC) Date: Thu, 19 Sep 2019 19:23:50 +0200 From: Alexandre Belloni To: Mark Brown Subject: Re: [PATCH] spi: atmel: Fix crash when using more than 4 gpio CS Message-ID: <20190919172350.GZ21254@piout.net> References: <20190919153847.7179-1-gregory.clement@bootlin.com> <20190919160315.GQ3642@sirena.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190919160315.GQ3642@sirena.co.uk> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190919_102403_395487_FEE8CA96 X-CRM114-Status: GOOD ( 11.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gregory CLEMENT , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Ludovic Desroches , Thomas Petazzoni , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/09/2019 17:03:15+0100, Mark Brown wrote: > On Thu, Sep 19, 2019 at 05:38:47PM +0200, Gregory CLEMENT wrote: > > > With this patch, when using a gpio CS, the hardware CS0 is always > > used. Thanks to this, there is no more limitation for the number of > > gpio CS we can use. > > This is going to break any system where we use both a GPIO chip select > and chip select 0. Ideally we'd try to figure out an unused chip select > to use here... The point is that this use case is already broken and this patch fixes the crash and is easily backportable. Fixing the CS + gpio CS should probably be done in a separate patch. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel