From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3866CC3A5A6 for ; Thu, 19 Sep 2019 18:24:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D8BE21928 for ; Thu, 19 Sep 2019 18:24:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YgsprKJf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D8BE21928 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1lqG7gtkZtbQuRMO1noy3IN4URvDXYFI3Bjmb866We0=; b=YgsprKJfEOaosX WVW63/oygJQc67+oPcAr8wO3Nbz3UsxkW08gFGt6TcdP3VZYL6ELSkni84Cx3oOx1eNAMeNUCQYRM RUDff7TRltCqZv41KxoCDzFRQzumlAvr0irFR7KPAwH9NWBbqdgdFc1Zo1gQ5kVzTLf8ZDF6/3Trz Z2D9+BD50Wc3+p6osGB4owQTm1K7SnXiG3DZgPdV+W8yYQ+bIm54rUyzDewjQbI6D3/EIhmNlMaiK 6F7rSzm90VS9wQPYaEf2e5ERXV+2xqQvd6+pJMtUnXMchzMBND//9TOE7+xyOzTzZLIvcBZ9TQg46 Hpmfndfu8Mq4DzxCmonQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iB16R-0002Tr-PP; Thu, 19 Sep 2019 18:24:28 +0000 Received: from mail-wm1-f66.google.com ([209.85.128.66]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iB121-0000im-1x for linux-arm-kernel@lists.infradead.org; Thu, 19 Sep 2019 18:20:34 +0000 Received: by mail-wm1-f66.google.com with SMTP id 3so5088412wmi.3 for ; Thu, 19 Sep 2019 11:19:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MS71DLSrsr/G7o0fTmBzjlmIBqxvb7B9GSSu+P2PwIg=; b=jmRJ4djqkHo97FPFH6z4uGejpa01Mkk36U8xyBEI9G++l5ylBk/0VS0tz09IYDs0r2 cSe9HqnuBSX4jLXINbMgB3/lYa31j61r3emI3SGcs3/tCzICsrNVetnDY1asVbaZ4RkC +6f3fiSWJ/tC6SpgI6vuwZrS1Y44SE+fjC37h+876tqbhDxZC+v/wIR5v5Ta5UA8+PwS jw6WdJ8dLpwBQa5zHeGaK8OHbRn458laeYMoZYu7bMPGpf6rT1Ib2zMutJ7ZVmCdM0Ct GDaahigGgVZYtCeFgkDcQJAcoac0Z6p12P8BCxCCsZtxPoKyoTXAppS0Z+hlNuh27fNl zT/w== X-Gm-Message-State: APjAAAVbefdEgvgJwYZ90tuIQwXeRc/kZ3aBp3kKlayLeivTtPKqMPl+ oJ5V7gyx3IFXuNroWtOi4zg= X-Google-Smtp-Source: APXvYqzDQmkkIzntHgwlryzOqeRBmIg4C0xnns499J6+IhQ83PPvBY71St9Lwr2+SJuP95RGKnOA6Q== X-Received: by 2002:a1c:6508:: with SMTP id z8mr4156412wmb.93.1568917187038; Thu, 19 Sep 2019 11:19:47 -0700 (PDT) Received: from kozik-lap ([194.230.155.145]) by smtp.googlemail.com with ESMTPSA id r13sm13927274wrn.0.2019.09.19.11.19.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Sep 2019 11:19:46 -0700 (PDT) Date: Thu, 19 Sep 2019 20:19:43 +0200 From: Krzysztof Kozlowski To: Lukasz Luba Subject: Re: [PATCH v3 1/2] memory: samsung: exynos5422-dmc: Fix kfree() of devm-allocated memory and missing static Message-ID: <20190919181943.GA10759@kozik-lap> References: <20190919092641.4407-1-l.luba@partner.samsung.com> <20190919092641.4407-2-l.luba@partner.samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190919092641.4407-2-l.luba@partner.samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190919_112001_599016_591D80F9 X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, willy.mh.wolff.ml@gmail.com, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, cw00.choi@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, myungjoo.ham@samsung.com, s.nawrocki@samsung.com, dan.carpenter@oracle.com, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 19, 2019 at 11:26:40AM +0200, Lukasz Luba wrote: > Fix issues captured by static checkers: used kfree() and missing 'static' > in the private function. > > Fixes Smatch warning: > drivers/memory/samsung/exynos5422-dmc.c:272 > exynos5_init_freq_table() warn: passing devm_ allocated variable to kfree. 'dmc->opp' > > Fixes Sparse warning: > drivers/memory/samsung/exynos5422-dmc.c:736:1: > warning: symbol 'exynos5_dmc_align_init_freq' was not declared. > > Reported-by: kbuild test robot > Reported-by: Dan Carpenter > Reported-by: Krzysztof Kozlowski > Signed-off-by: Lukasz Luba > --- > drivers/memory/samsung/exynos5422-dmc.c | 6 ++---- Thanks, applied. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel