From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6671AC3A5A2 for ; Sun, 22 Sep 2019 16:16:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 390F7206C2 for ; Sun, 22 Sep 2019 16:16:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CqFcMMEf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 390F7206C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8JTDF1R+DcN3HHWlrBFch4HEPs3X3mlco8w0i3F6FhA=; b=CqFcMMEfmjJdrI Qkd5I0MGMnu9cF9MZXti//iSDdprGdx/JEe9MWvK6kt8SIVorl2tyc9u/wBhlrOnQBxmXAuw5m6kN H61l51fxTUeeiZyiNs4VeJEevR+mew9fjmCSqdDVvJZmJdt3blpVg8Rrvx1CBjbJPxItSe6GHiBNF Zr7evzYx+CM6IYb64svR/09Zo2AldnD/aqBlZi6oK5SgBW5eV5/06wkSfoa5IO2M6WYNUpA0Bv3PA y6PoAfyi1/yk5daPrt1qf3L51H88PDru7D/RBKMDCw5fwIu4aa5IiqrqakyylZZMjWjoujzpKfIhq 68Wqe/60+7tL2lm2jKYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iC4Wp-0003tW-Vl; Sun, 22 Sep 2019 16:16:04 +0000 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iC4VU-00027j-UU for linux-arm-kernel@lists.infradead.org; Sun, 22 Sep 2019 16:14:43 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 5181D8039C; Sun, 22 Sep 2019 18:14:25 +0200 (CEST) Date: Sun, 22 Sep 2019 18:14:33 +0200 From: Pavel Machek To: Anson Huang Subject: Re: [PATCH V4 2/5] input: keyboard: imx_sc: Add i.MX system controller key support Message-ID: <20190922161432.GE1999@bug> References: <1568602373-14164-1-git-send-email-Anson.Huang@nxp.com> <1568602373-14164-2-git-send-email-Anson.Huang@nxp.com> <20190916235330.GI237523@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190922_091442_417381_FC99D0B2 X-CRM114-Status: GOOD ( 13.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "ulf.hansson@linaro.org" , Jacky Bai , "catalin.marinas@arm.com" , Peng Fan , "stefan@agner.ch" , "bjorn.andersson@linaro.org" , Leonard Crestez , "will@kernel.org" , "festevam@gmail.com" , "yuehaibing@huawei.com" , "marcin.juszkiewicz@linaro.org" , "cw00.choi@samsung.com" , "jagan@amarulasolutions.com" , "linux-input@vger.kernel.org" , "ronald@innovation.ch" , dl-linux-imx , "devicetree@vger.kernel.org" , "arnd@arndb.de" , "s.hauer@pengutronix.de" , "mripard@kernel.org" , "m.felsch@pengutronix.de" , "enric.balletbo@collabora.com" , "robh+dt@kernel.org" , "andriy.shevchenko@linux.intel.com" , Daniel Baluta , "linux-arm-kernel@lists.infradead.org" , Aisheng Dong , Andy Duan , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , "dinguyen@kernel.org" , "kernel@pengutronix.de" , "olof@lixom.net" , "shawnguo@kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! > > > + ret = imx_scu_call_rpc(priv->key_ipc_handle, &msg, true); > > > + if (ret) { > > > + dev_err(&input->dev, "read imx sc key failed, ret %d\n", ret); > > > + return; > > > + } > > > + > > > + state = (bool)msg.state; > > > + > > > + if (!state && !priv->keystate) > > > + state = true; > > > > This needs an explanation please. > > This is to handle the quick press of button, e.g., when button is pressed and released very quickly, > when the delay work is scheduled, the button state read from SCU FW is actually a release state (0), > the press state is (1), so the quick press/release will be ignored. > > However, after double check and test, I think this should be handled by debounce time, if the button is pressed/release > very quickly, the event should be ignored, I will remove it and reduce the debounce time to 30mS, previous 100mS > is too long, using 30mS as debounce time, I did NOT see similar issue no matter how quick I press/release the button. Are you sure this is expected behaviour? AFAIK microswitches can bounce when the button is pressed and released, but will not generate glitches when the button was not pressed, so even short presses are real and should be propagated... Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel