From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF8E2C3A5A6 for ; Sun, 22 Sep 2019 17:49:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A189A206C2 for ; Sun, 22 Sep 2019 17:49:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="egTYEyIT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="A79eBZV8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A189A206C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=AregR4Xtn35wQj+A2wFkwRqEmoSj/XwZmRHrjOLXdIw=; b=egTYEyIT+bou8x aTfoj8gcniV7GACp8Gx8fARpjZCBKAixvPeFSje9RCmHEUVNHUjEmSeudpJGgblZ8D99gFHJ0mLZp acagCBhd/5mjO1f0o/zEpJTtqf7VlFEnrP3afslCTrL1HIHHSR0dUpQySk1qQj8z88VxtuqRxc4lg 9Tpl1F2PzaK7f7iNMuDS4AVGhpzLG5IpkLnIHprwQjqJsuHcVePMjr695XAaZypgU9pFcsMorGHCs SbGxW4UEi8jXi79mT2M/kzL0EV5MPXjCa+IqwJHtsqhvyqiKGPQnNMNw7QDzot2PLPzgDexQFX1Ad PVqTeGd3O25FtW+0G21w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iC5yh-0005g3-T0; Sun, 22 Sep 2019 17:48:55 +0000 Received: from userp2130.oracle.com ([156.151.31.86]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iC5yc-0005fe-9F for linux-arm-kernel@lists.infradead.org; Sun, 22 Sep 2019 17:48:52 +0000 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x8MHesNA018859; Sun, 22 Sep 2019 17:48:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2019-08-05; bh=INbULvYIT/Pb5v51jJEHnRs9ROAHWMn+IjBL3bVcp64=; b=A79eBZV8n8/ZVP9fGbKGZIwxGGbt194EsBlgFxHFH4OccZPuReDFWYr79OjIEq2zC9zm IxChKHlGY6enssLa6OoSirY197kHVk7HPOhQvIWmK4KE3hitrWWaBHZqMwuqX71rPr/p al55rlFi5Wbv0CaIkHzxFOdsXajlvpv+o/Oh2vHbVZh3Tl0RP7F9KPdEeJCF5+YkZADu +QNcp3bt4qCAvY7Ia0AukWTExwKbGJIrNmI+Zb3TWxBmToT8HY5zPpCIyLg9KFbNskLU PtL19u7ZFpi12glADrRB9+Lu+g2vwNfSdwzZ+3qCNKtkmx436+fAUvYNC11sU38ov1wY oA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2v5b9tbbud-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 22 Sep 2019 17:48:20 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x8MHiHhA166738; Sun, 22 Sep 2019 17:48:19 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2v6actrs49-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 22 Sep 2019 17:48:19 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x8MHmC7q025278; Sun, 22 Sep 2019 17:48:15 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 22 Sep 2019 10:48:12 -0700 Date: Sun, 22 Sep 2019 20:48:04 +0300 From: Dan Carpenter To: kbuild@01.org, Russell King Subject: [arm:cex7 23/26] drivers/bus/fsl-mc/fsl-mc-uapi.c:88 fsl_mc_uapi_dev_open() warn: possible memory leak of 'priv_data' Message-ID: <20190922174804.GI20699@kadam> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9388 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909220187 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9388 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909220186 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190922_104850_458295_AEB38D77 X-CRM114-Status: GOOD ( 13.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbuild-all@01.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org tree: git://git.armlinux.org.uk/~rmk/linux-arm.git cex7 head: f959c38798814d3063719e70f279280fde355a49 commit: 00d36fa7e9c860aae5034c5f52acd91e6fb4ab4b [23/26] fsl-mc: add uapi interface for restool If you fix the issue, kindly add following tag Reported-by: kbuild test robot Reported-by: Dan Carpenter smatch warnings: drivers/bus/fsl-mc/fsl-mc-uapi.c:88 fsl_mc_uapi_dev_open() warn: possible memory leak of 'priv_data' git remote add arm git://git.armlinux.org.uk/~rmk/linux-arm.git git remote update arm git checkout 00d36fa7e9c860aae5034c5f52acd91e6fb4ab4b vim +/priv_data +88 drivers/bus/fsl-mc/fsl-mc-uapi.c 00d36fa7e9c860 Russell King 2019-09-12 45 static int fsl_mc_uapi_dev_open(struct inode *inode, struct file *filep) 00d36fa7e9c860 Russell King 2019-09-12 46 { 00d36fa7e9c860 Russell King 2019-09-12 47 struct fsl_mc_device *root_mc_device; 00d36fa7e9c860 Russell King 2019-09-12 48 struct uapi_priv_data *priv_data; 00d36fa7e9c860 Russell King 2019-09-12 49 struct fsl_mc_io *dynamic_mc_io; 00d36fa7e9c860 Russell King 2019-09-12 50 struct fsl_mc_uapi *mc_uapi; 00d36fa7e9c860 Russell King 2019-09-12 51 struct fsl_mc_bus *mc_bus; 00d36fa7e9c860 Russell King 2019-09-12 52 int error; 00d36fa7e9c860 Russell King 2019-09-12 53 00d36fa7e9c860 Russell King 2019-09-12 54 priv_data = kzalloc(sizeof(*priv_data), GFP_KERNEL); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Can we use devm_ here? 00d36fa7e9c860 Russell King 2019-09-12 55 if (!priv_data) 00d36fa7e9c860 Russell King 2019-09-12 56 return -ENOMEM; 00d36fa7e9c860 Russell King 2019-09-12 57 00d36fa7e9c860 Russell King 2019-09-12 58 mc_uapi = container_of(filep->private_data, struct fsl_mc_uapi, misc); 00d36fa7e9c860 Russell King 2019-09-12 59 mc_bus = container_of(mc_uapi, struct fsl_mc_bus, uapi_misc); 00d36fa7e9c860 Russell King 2019-09-12 60 root_mc_device = &mc_bus->mc_dev; 00d36fa7e9c860 Russell King 2019-09-12 61 00d36fa7e9c860 Russell King 2019-09-12 62 mutex_lock(&mc_uapi->mutex); 00d36fa7e9c860 Russell King 2019-09-12 63 00d36fa7e9c860 Russell King 2019-09-12 64 if (!mc_uapi->local_instance_in_use) { 00d36fa7e9c860 Russell King 2019-09-12 65 priv_data->mc_io = mc_uapi->static_mc_io; 00d36fa7e9c860 Russell King 2019-09-12 66 mc_uapi->local_instance_in_use = 1; 00d36fa7e9c860 Russell King 2019-09-12 67 } else { 00d36fa7e9c860 Russell King 2019-09-12 68 error = fsl_mc_portal_allocate(root_mc_device, 0, 00d36fa7e9c860 Russell King 2019-09-12 69 &dynamic_mc_io); 00d36fa7e9c860 Russell King 2019-09-12 70 if (error) { 00d36fa7e9c860 Russell King 2019-09-12 71 dev_dbg(&root_mc_device->dev, 00d36fa7e9c860 Russell King 2019-09-12 72 "Could not allocate MC portal\n"); 00d36fa7e9c860 Russell King 2019-09-12 73 goto error_portal_allocate; ^^^^^^^^^^^^^^^^^^^^^^^^^^^ 00d36fa7e9c860 Russell King 2019-09-12 74 } 00d36fa7e9c860 Russell King 2019-09-12 75 00d36fa7e9c860 Russell King 2019-09-12 76 priv_data->mc_io = dynamic_mc_io; 00d36fa7e9c860 Russell King 2019-09-12 77 } 00d36fa7e9c860 Russell King 2019-09-12 78 priv_data->uapi = mc_uapi; 00d36fa7e9c860 Russell King 2019-09-12 79 filep->private_data = priv_data; 00d36fa7e9c860 Russell King 2019-09-12 80 00d36fa7e9c860 Russell King 2019-09-12 81 mutex_unlock(&mc_uapi->mutex); 00d36fa7e9c860 Russell King 2019-09-12 82 00d36fa7e9c860 Russell King 2019-09-12 83 return 0; 00d36fa7e9c860 Russell King 2019-09-12 84 00d36fa7e9c860 Russell King 2019-09-12 85 error_portal_allocate: 00d36fa7e9c860 Russell King 2019-09-12 86 mutex_unlock(&mc_uapi->mutex); 00d36fa7e9c860 Russell King 2019-09-12 87 00d36fa7e9c860 Russell King 2019-09-12 @88 return error; 00d36fa7e9c860 Russell King 2019-09-12 89 } --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel