From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AF4FC04EBF for ; Mon, 23 Sep 2019 11:34:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F08B720835 for ; Mon, 23 Sep 2019 11:34:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KRdQT2N5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ragnatech-se.20150623.gappssmtp.com header.i=@ragnatech-se.20150623.gappssmtp.com header.b="zAsyPvNJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F08B720835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ragnatech.se Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u/kGJSV/7qazzttggME0HIXPwNYA0P9WOmPl2mY0J7M=; b=KRdQT2N5tRrvVk euBrFP/ViSXlAMULeDH3PfR4m/kWSpL5FIVxj105EXoRqXcAmInDThOPXTtTVYOQP8Pxl7So7N+TA ilA/Wr1ut1iZ2C2K7lQSgDSCODxU+Z0ayopOofoN2aKtneLiWha+HqeQb2QtDh59uY31gtKHBfGsE OUoZMEQjiqs3xXzlZwpeo/3ifz7/jkfh77rCBfoo2Y6oVEA5FOC5SkLozCsgDyG+dTNVQrZzR/+rP /v4CPZuJy8XclBkUKBvDGGDU/B/iqt7AtjagCoikLq8lz9Ac/sk6YUvrx2rRizSkKb8is/xShGaqN 0IMAKRkjx3WIaLn2ggiQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCMba-0006fL-DT; Mon, 23 Sep 2019 11:34:10 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCMbX-0006eN-JR for linux-arm-kernel@lists.infradead.org; Mon, 23 Sep 2019 11:34:09 +0000 Received: by mail-lj1-x242.google.com with SMTP id j19so11838118lja.1 for ; Mon, 23 Sep 2019 04:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=1iHVMQKqhTvi2xyeEpHSWZnbXdJb6BZcBgLx05z/RJY=; b=zAsyPvNJsGYcnnQeTbbprStzO4yMGANU4Wwf8P25L0D1n7azLLG750ich1xVRaWDAW IyAmTFGaVwCJP9xiUik/8q1b66zr5cFf/PG4QRArX19JS2/PwOhFis27q9CH5IQFsysc IgjgN8DM+EhVr1ffjmOsBsngMuGC94o0StTmi8fH6jmvYVS/LlBjgjM+UkpoZerHGp6z LXaU9ZShi7/y/Ab2WMrtyF6IRiCp2pmUvmooh3KCl4I4dI7zDmL/n2AFYqE3OsIifJyt 6xY4M3QgfFH8s4DCfBRwSCg7ZbiUvuwl9kfgIS3JzDNAIos56QJeqRygXAFE+sMLd3YD aIHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=1iHVMQKqhTvi2xyeEpHSWZnbXdJb6BZcBgLx05z/RJY=; b=VM1K2Mok5ZumKCE7FrRjOj2k60kWtASzMMHnyP2JZhjkUk4UeYKw3aAt8vVDQqUJbs wQhJFwZbvOcRleb14KvGUhMwCq93p0PkuKirXJMuLgy/S9UXmRLlTiGWgUsJpI3AnLSy J3e2BFsg5VhZpKvwEjzcvUIMU99xtNlMsR/fLCOFYXbtzTfiG0mhnTVHTKR/3dala1JU 4lyY6y+JGgy4yIISOGdeptdbX81RdHbYaaPV2VGAYkeeyqhtBePZT8LE05wI5OpQNd2O Sn1qe2KRpsMhCkY0Dd3O5yeE9LAuDoIBjVcNM/O3AglJuMkNTlekZKZSqv5oVz5QM4Ku gboQ== X-Gm-Message-State: APjAAAUctjoEZvziQ3kbNAt/KstxiVy67FBbzCV7X4BqKvazko4uBUao DQwHPzOSF5gKG23iS6FhOxAm1w== X-Google-Smtp-Source: APXvYqyLM/Stp8gNwOtRCJqDNGvGHQVfcCbloLsy0YfOl+HNNgEkESrWd92Ftx28l5PJGALh+qbOug== X-Received: by 2002:a2e:8789:: with SMTP id n9mr17263051lji.52.1569238444804; Mon, 23 Sep 2019 04:34:04 -0700 (PDT) Received: from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159]) by smtp.gmail.com with ESMTPSA id 126sm2326083lfh.45.2019.09.23.04.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2019 04:34:04 -0700 (PDT) Date: Mon, 23 Sep 2019 13:34:03 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Markus Elfring Subject: Re: [PATCH] media: platform: Use devm_platform_ioremap_resource() in two functions Message-ID: <20190923113403.GA14837@bigcity.dyn.berto.se> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190923_043407_638260_0AFAE920 X-CRM114-Status: GOOD ( 17.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew-CT Chen , Tiffany Lin , kernel-janitors@vger.kernel.org, LKML , linux-renesas-soc@vger.kernel.org, Bartosz Golaszewski , linux-mediatek@lists.infradead.org, Himanshu Jha , Matthias Brugger , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Markus, Thanks for your patch. On 2019-09-18 11:30:30 +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 18 Sep 2019 11:20:48 +0200 > = > Simplify these function implementations by using a known wrapper function. > = > This issue was detected by using the Coccinelle software. > = > Signed-off-by: Markus Elfring > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 8 +------- > drivers/media/platform/rcar-vin/rcar-core.c | 7 +------ For rcar-vin: Tested-by: Niklas S=F6derlund > 2 files changed, 2 insertions(+), 13 deletions(-) > = > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/dri= vers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > index 00d090df11bb..944771ee5f5c 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > @@ -253,13 +253,7 @@ static int mtk_vcodec_probe(struct platform_device *= pdev) > } > = > for (i =3D 0; i < NUM_MAX_VDEC_REG_BASE; i++) { > - res =3D platform_get_resource(pdev, IORESOURCE_MEM, i); > - if (res =3D=3D NULL) { > - dev_err(&pdev->dev, "get memory resource failed."); > - ret =3D -ENXIO; > - goto err_res; > - } > - dev->reg_base[i] =3D devm_ioremap_resource(&pdev->dev, res); > + dev->reg_base[i] =3D devm_platform_ioremap_resource(pdev, i); > if (IS_ERR((__force void *)dev->reg_base[i])) { > ret =3D PTR_ERR((__force void *)dev->reg_base[i]); > goto err_res; > diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/= platform/rcar-vin/rcar-core.c > index 6993484ff0f3..334c62805959 100644 > --- a/drivers/media/platform/rcar-vin/rcar-core.c > +++ b/drivers/media/platform/rcar-vin/rcar-core.c > @@ -1282,7 +1282,6 @@ static int rcar_vin_probe(struct platform_device *p= dev) > { > const struct soc_device_attribute *attr; > struct rvin_dev *vin; > - struct resource *mem; > int irq, ret; > = > vin =3D devm_kzalloc(&pdev->dev, sizeof(*vin), GFP_KERNEL); > @@ -1301,11 +1300,7 @@ static int rcar_vin_probe(struct platform_device *= pdev) > if (attr) > vin->info =3D attr->data; > = > - mem =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (mem =3D=3D NULL) > - return -EINVAL; > - > - vin->base =3D devm_ioremap_resource(vin->dev, mem); > + vin->base =3D devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(vin->base)) > return PTR_ERR(vin->base); > = > -- > 2.23.0 > = -- = Regards, Niklas S=F6derlund _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel