From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A1DEC432C1 for ; Mon, 23 Sep 2019 23:51:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68EEB206C2 for ; Mon, 23 Sep 2019 23:51:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lQWFFs5B"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="E/y9NXZy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68EEB206C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xFYR0g4MsYG652A3nASxCe8IcjKmF6mobmcSeypyMnM=; b=lQWFFs5BWQcczl VPDI1b1qXUNDU+BpH492ljxKIJnAbse8qMz8TLEzhqIgY/FKfL8LgKdJH0KPxk0Ej+X6+gTxuwFU8 ZQTrqTed3SZQJtpqJKPCLXdR+V8s69HbJxJ9nqWEAyOuVzYGDIT++q4Vj2J+JKvXUdgapakm71Axw d5wcweLuA3vM+i+YLysSHC1rio6lBg3clbOMo7B/qAejqOU+6i6dU1Mvae70ed6bnKXfC5FBGEdZX 8P8zvzMBv7mnc2MJJcESra7+0L2zOy3nHFYBO5/LM9pEZVhxA0p+Lg/rBJawx532zyXIrzv7d0lRI d99/GhlzawP6EDSHR7Iw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCY7H-0003wY-9q; Mon, 23 Sep 2019 23:51:39 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCY7C-0003vZ-W0 for linux-arm-kernel@lists.infradead.org; Mon, 23 Sep 2019 23:51:37 +0000 Received: by mail-pl1-x641.google.com with SMTP id d22so71784pls.0 for ; Mon, 23 Sep 2019 16:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XsWEYEMa3OUxN/rIyJmCXyYBeWS8+cU9XND539Ca4bw=; b=E/y9NXZybs6vA4vrlalGFLTtZlxrC7FtgNZ3guYdN0O/ZGcGF24vZNUnIPI9RNeUSU KG2oaE52Aag0Vkpz8/5DKgjwGlCVtVq1vVyhPWrz1aox1UxP7nt4VCA8fvKlCohfnkIs mSJV6kjx7O2bDKd2DZFiUTXqHAySN3KKJ4g6Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XsWEYEMa3OUxN/rIyJmCXyYBeWS8+cU9XND539Ca4bw=; b=g7BF3YVRgT2ZkWARMDoh4pyV9yIGWU3SRodA2JLSCJq18zvntX/GYabFnUgCkqegwv XDf6uBBfx//sd5v5u1eOnvY2ahMDjigyulNpx90x1abr7a50CwZq3AvQOHckykbxjLUq Aa5Y7ks+5S1xvm8Oi4TLdic6reOHftWWkM/r/h3SKT7CvjI7mUmBxP1oZSI7itw+PfC9 NK0rmkKxYUkI9UHBZnszXCD10N2ZxLMuxv1sFQUk1R6QpLxLi+Rf/3YiJZz+hZ/bMNfJ aXJW0waCTKprr3STGh7Q8B3oHnPGH+X5aUQkmytu7VnbSbRwmO7GYEvvXxP9/ecDS1tu cp0g== X-Gm-Message-State: APjAAAWPTraUsnYQLgbDtK1wYrGriEaazZen20Go+QAAUpt1zqXC0WWd 0vx9dsi8AxLtjT8F/L28bkeQow== X-Google-Smtp-Source: APXvYqwU0BW/btrE2Yva2gh7adQAX91dLGmJKvlNr/ftvqFACr7SANo+L9CNSieSziIXVJm4hCuctg== X-Received: by 2002:a17:902:36a:: with SMTP id 97mr2247384pld.75.1569282694325; Mon, 23 Sep 2019 16:51:34 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m4sm5126340pjs.8.2019.09.23.16.51.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2019 16:51:33 -0700 (PDT) Date: Mon, 23 Sep 2019 16:51:32 -0700 From: Kees Cook To: Borislav Petkov Subject: Re: [PATCH] seccomp: remove unused arg from secure_computing() Message-ID: <201909231650.1CCAFBA6@keescook> References: <20190920131907.6886-1-christian.brauner@ubuntu.com> <20190923094916.GB15355@zn.tnic> <20190923193446.GL15355@zn.tnic> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190923193446.GL15355@zn.tnic> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190923_165135_054304_D75AC512 X-CRM114-Status: GOOD ( 14.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390 , Will Drewry , Parisc List , X86 ML , linux-um@lists.infradead.org, LKML , Oleg Nesterov , Andy Lutomirski , Christian Brauner , Thomas Gleixner , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 23, 2019 at 09:34:46PM +0200, Borislav Petkov wrote: > On Mon, Sep 23, 2019 at 11:41:59AM -0700, Andy Lutomirski wrote: > > On Mon, Sep 23, 2019 at 2:49 AM Borislav Petkov wrote: > > > > > > On Fri, Sep 20, 2019 at 03:19:09PM +0200, Christian Brauner wrote: > > > > While touching seccomp code I realized that the struct seccomp_data > > > > argument to secure_computing() seems to be unused by all current > > > > callers. So let's remove it unless there is some subtlety I missed. > > > > Note, I only tested this on x86. > > > > > > What was amluto thinking in > > > > > > 2f275de5d1ed ("seccomp: Add a seccomp_data parameter secure_computing()") > > > > IIRC there was a period of time in which x86 used secure_computing() > > for normal syscalls, and it was a good deal faster to have the arch > > code supply seccomp_data. x86 no longer works like this, and syscalls > > aren't fast anymore ayway :( > > Uhuh, thanks Andy. > > Christian, pls add that piece of history to the commit message. Yeah, this is just left-over from the "two phase" seccomp optimization that was removed a while back. I'll take this clean up into the seccomp tree. Thanks! -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel