From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73590C4CEC4 for ; Mon, 23 Sep 2019 17:33:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40EBB21906 for ; Mon, 23 Sep 2019 17:33:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F6zMrphG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40EBB21906 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HaGkG/FsnGdOQmshNxd8vkcOO4Q1G0d/N2KTsvOVpfs=; b=F6zMrphG6CbpBW gP+8SURywd8UPN98nCJ7TG9pAxSGiD9XoPxHy5q0cCKyH88GKOq5LC2JC2QD7IwFELwcYeybG3Nnv rNxwBWy4fLRYO/qTtLEr5/+R0SuYxq7sLpQiHwaGwNC7P0ki6G+dy/f/38qZ5psGDQXz3byfl146n 20rym5YHsQtOpLjTCufutwB18USKfYJKTNems0DFYjSWwhDMmCCIihubmoxstrtpcDb3I0JIDmkhe KXbicEQ13dTXDHjk+CK8QZGX+5fNiCsSivV3icbLQA0Mu7VigZUdGUs1pGXpZbGkFYG9rKXBA1IUq wDADENkH51l8Tqw1KEpw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCSDD-0000d6-4e; Mon, 23 Sep 2019 17:33:23 +0000 Received: from asavdk3.altibox.net ([109.247.116.14]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCSD9-0000ZO-LN for linux-arm-kernel@lists.infradead.org; Mon, 23 Sep 2019 17:33:21 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 3E7FF20042; Mon, 23 Sep 2019 19:31:08 +0200 (CEST) Date: Mon, 23 Sep 2019 19:31:06 +0200 From: Sam Ravnborg To: Sandy Huang Subject: Re: [PATCH 22/36] drm/atmel-hlcdc: use bpp instead of cpp for drm_format_info Message-ID: <20190923173106.GA13649@ravnborg.org> References: <1569243119-183293-1-git-send-email-hjc@rock-chips.com> <1569243119-183293-2-git-send-email-hjc@rock-chips.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1569243119-183293-2-git-send-email-hjc@rock-chips.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=s8YR1HE3AAAA:8 a=GZYic5qFh62CaahH_tAA:9 a=CjuIK1q_8ugA:10 a=jGH_LyMDp9YhSvY-UuyI:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190923_103319_876363_9A67C9DA X-CRM114-Status: GOOD ( 16.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Boris Brezillon , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ludovic Desroches , Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sandy. Thanks for taking care of this, but... On Mon, Sep 23, 2019 at 08:51:45PM +0800, Sandy Huang wrote: > cpp[BytePerPlane] can't describe the 10bit data format correctly, > So we use bpp[BitPerPlane] to instead cpp. > > Signed-off-by: Sandy Huang > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > index 89f5a75..ab7d423 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > @@ -644,7 +644,7 @@ static int atmel_hlcdc_plane_atomic_check(struct drm_plane *p, > int xdiv = i ? fb->format->hsub : 1; > int ydiv = i ? fb->format->vsub : 1; > > - state->bpp[i] = fb->format->cpp[i]; > + state->bpp[i] = fb->format->bpp[i] / 8; > if (!state->bpp[i]) > return -EINVAL; Awaiting conclusion on Daniels comment on PATCH 1 and has dropped this patch for now. And please address the concerns Rob has about bisectability in your cover letter for v2. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel