From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77DCBC4CEC4 for ; Mon, 23 Sep 2019 18:29:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C3ED20B7C for ; Mon, 23 Sep 2019 18:29:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pF7t9taB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Yh7pE8es" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C3ED20B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vBjQ/hGA7FN7KehqRU8KT7YNHk8ktm+0D0iWvWVXW1k=; b=pF7t9taB18pCVe i9C08cwWKSfZsJC9XivUncWOG+BBTzK+QWTkjNv9AtWUUNIcmAOXe04M1hK1JX58iy2tNhJoBCRr0 bPJXz3zmwxKKDj3V2Gn6hz9F1uDB1QnQsMcX3PaO7IFE/cDVerIyJN4krfXCg3CgVtSZ4k4h82Zsi hMfLlX+Ms64klhcsn3WmGSAh35SmcfI+/yTm3jMVxAujcvwF1wuNfRZKCBKklOqVA+TE8O1aR+MZJ JEEUPmM8hF1b4UYV91kAZw9MFOxVDqHebIM09DbRfu41BSACepHchQVF/cHk6aKjJI0RwiAcZdr5N 2kGNm7Sf7qcERRiXIlhQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCT53-0002Vy-3K; Mon, 23 Sep 2019 18:29:01 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCT4v-0002VW-8E for linux-arm-kernel@lists.infradead.org; Mon, 23 Sep 2019 18:28:54 +0000 Received: by mail-pg1-x544.google.com with SMTP id z12so8444700pgp.9 for ; Mon, 23 Sep 2019 11:28:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=osrTSn6KjMgzsQs20d8e8jW1Eld7CeaYVglhaLiaLFM=; b=Yh7pE8es+GVW4C8JR7aOYXG2O0qKNB6DC0vm4QpDXsa1xVGouuF8HLw6sJIaI1fdC5 kN2rydapFx5DlHkCLwyPiPEaXhLX8PW4fM4+aMPvuP7hRrS3NjmJvVsAmN6cGSmMe2sC CaoJDzr+VPWJrywZdIYc5zH3+xiRqRadGHncE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=osrTSn6KjMgzsQs20d8e8jW1Eld7CeaYVglhaLiaLFM=; b=nBH05f19PgPjMY/R+5wvAUDSh737pQqTictB2yeEWCHrM+onQLd6fEauipudMoYwDL +zOLFqzG1Q8faedAaqW/wEGBMe5ywuRsYYARxLsZCnGTac9Rx3upEeSFjzvuEMPSBDnf QhkT5oHKGpwSwaH8cGp7Jd//HOO9nVpWWp/e2uSc/s85t+G/2m2MUA6sM6wd1t3I+pb+ 7hvWUGg/KSr6tG+t3eEO0SQWTd+awXKwd9FD8yXeh65tMKRuhZVlh6qP4C21XV9y/ZJO o8Jbfs93WWe74uex6dnU1sVHvzrzLgYPkwOW0pKrKaRlHpSfp6uUt1+6gRteVz+erzZr P8ew== X-Gm-Message-State: APjAAAWb+Hbb6WZth1ChRLaYu1STkDueKP+qbai4hNV1WwKE6KpHo4ZI baCbqc9KpMb9HO9/JhKMcrxU4Q== X-Google-Smtp-Source: APXvYqxnWvwnP8W6mGj9+JL5YprZG5pP/WpUUgP7zfCNFpJEkySyt5F6Iu1FF86JYwkPO2XQ0Q9GHw== X-Received: by 2002:a17:90a:8087:: with SMTP id c7mr941118pjn.56.1569263332455; Mon, 23 Sep 2019 11:28:52 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id w11sm19047961pfd.116.2019.09.23.11.28.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2019 11:28:51 -0700 (PDT) Date: Mon, 23 Sep 2019 11:28:49 -0700 From: Matthias Kaehlcke To: Leonard Crestez Subject: Re: [PATCH v6 5/6] PM / devfreq: Add PM QoS support Message-ID: <20190923182849.GA133864@google.com> References: <55807c847f072690f3ec904168023484767dc603.1569252537.git.leonard.crestez@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <55807c847f072690f3ec904168023484767dc603.1569252537.git.leonard.crestez@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190923_112853_319430_19249068 X-CRM114-Status: GOOD ( 14.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Artur =?utf-8?B?xZp3aWdvxYQ=?= , Abel Vesa , Saravana Kannan , linux-pm@vger.kernel.org, Viresh Kumar , NXP Linux Team , Krzysztof Kozlowski , Lukasz Luba , Chanwoo Choi , Kyungmin Park , MyungJoo Ham , Alexandre Bailon , Georgi Djakov , linux-arm-kernel@lists.infradead.org, Jacky Bai Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Please see my comments on v5: https://patchwork.kernel.org/patch/11149485/ an additional nit inline On Mon, Sep 23, 2019 at 06:51:08PM +0300, Leonard Crestez wrote: > Register notifiers with the PM QoS framework in order to respond to > requests for DEV_PM_QOS_MIN_FREQUENCY and DEV_PM_QOS_MAX_FREQUENCY. > > Signed-off-by: Leonard Crestez > --- > drivers/devfreq/devfreq.c | 71 +++++++++++++++++++++++++++++++++++++++ > include/linux/devfreq.h | 5 +++ > 2 files changed, 76 insertions(+) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index b6acb827fee5..a4c7dde17a06 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -22,17 +22,20 @@ > #include > #include > #include > #include > #include > +#include > #include "governor.h" > > #define HZ_PER_KHZ 1000 > > #define CREATE_TRACE_POINTS > #include > > +#define HZ_PER_KHZ 1000 > + > static struct class *devfreq_class; > > /* > * devfreq core provides delayed work based load monitoring helper > * functions. Governors can use these or can implement their own > @@ -123,10 +126,16 @@ static void devfreq_get_freq_range(struct devfreq *devfreq, > } else { > *min_freq = freq_table[devfreq->profile->max_state - 1]; > *max_freq = freq_table[0]; > } > > + /* constraints from PM QoS: */ nit: remove colon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel