From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC69DC4360C for ; Fri, 27 Sep 2019 09:25:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC0A0217D9 for ; Fri, 27 Sep 2019 09:25:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Bp/V8R9d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC0A0217D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=79VBZ0YUNBY8HWq6Bf1F5Ud/J9mpK0XPFML32bBz9/I=; b=Bp/V8R9drN4TIF cJrgTTr4Yf4lF4KeRydSnN6FnEaECOb9kL6ouJHT1wLf9afEXExqfobQ7uhPFS6Duq1xf9CBsG2wM 9RFXBlCKBoXCeTSFFPplGK8JnZ78pJs706/3Pud6fMZlIGqCp7joYF9bpyAlFjGAnvXdEWwsyeQtU 55cJNDTlntvAZojd2huBer4bS2NbYaMfh+rWh/j9rgEq7QuWMusR5sYDWPWEvEZv2bFB8NlwXdnY+ /l9lWlA6uBtLB4nAHSG4fd9QE0d9i6xEU7XGIvM6JpJyPdf1RHkKFf3JzbLWm/AG/vtz0HiyngB+X x7j56nCtoWqQsnm4W+vg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDmUo-0006MO-Oi; Fri, 27 Sep 2019 09:25:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDmUk-0006LG-J2 for linux-arm-kernel@lists.infradead.org; Fri, 27 Sep 2019 09:24:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 51BBC28; Fri, 27 Sep 2019 02:24:57 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4DFCB3F534; Fri, 27 Sep 2019 02:24:56 -0700 (PDT) Date: Fri, 27 Sep 2019 10:24:54 +0100 From: Catalin Marinas To: Vincenzo Frascino Subject: Re: [PATCH v3 1/5] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Message-ID: <20190927092453.GA20642@arrakis.emea.arm.com> References: <20190926214342.34608-1-vincenzo.frascino@arm.com> <20190926214342.34608-2-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190926214342.34608-2-vincenzo.frascino@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190927_022458_666864_E9ADD5CA X-CRM114-Status: UNSURE ( 9.43 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ard.biesheuvel@linaro.org, ndesaulniers@google.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 26, 2019 at 10:43:38PM +0100, Vincenzo Frascino wrote: > Address the problem removing CONFIG_CROSS_COMPILE_COMPAT_VDSO and moving And this config does need to go in a subsequent patch. > the detection of the correct compiler into Kconfig via COMPAT_CC_IS_GCC. Nitpick: it's COMPATCC_IS_ARM_GCC now. > As a consequence of this it is not possible anymore to set the compat > cross compiler from menuconfig but it requires to be exported via > command line. > > E.g.: > > $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- > CROSS_COMPILE_COMPAT=arm-linux-gnueabihf Another nitpick, add a '-' at the end of 'gnueabihf'. Otherwise: Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel