From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D18CC4360C for ; Fri, 27 Sep 2019 09:46:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C7C32146E for ; Fri, 27 Sep 2019 09:46:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kM8Lzg/Z"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Vf4lnWSX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C7C32146E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xyAnNOgArF/ebIDVKKi4lYQp4m1CnPpFtmdI2ouDQG4=; b=kM8Lzg/ZirBb7W aTCbQkJVrvTM1XanPjVHQ8OvOvMEbV3MhzzZudYHySeqSsLF7RkHNSnk9+b+Lk5UBh7TYEJCGHkkZ RNlHMCBxlohBzbugFv+Zt/SIqEWCWTv5gCPiy5YQP10zbiFUtLqrpChk5+bot9xrL7IaUeiVOo5/c WebgyMQN67bAWTEt8ftIFlFJoiVA5g+uap+4V6ek1a5LK+YzpqEJgYdJP22hweKWttm8yvzUAzSuU i20ohzCnCvfg8VYevOSBqFVZrAENvb3e+vTX22WSWcDRHB4OPrZ9pbdliaccBVfvJZkolod9Pn7zb W1DxAvqwMxzz8JgK3OlQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDmpo-0000sZ-Pu; Fri, 27 Sep 2019 09:46:44 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDmpm-0000sT-Ti for linux-arm-kernel@bombadil.infradead.org; Fri, 27 Sep 2019 09:46:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XiYSAtcPx5fGqbm0ITh1APYnTU1YBYfAVVdvhAkRtYs=; b=Vf4lnWSXtbmTFP4CtgH3SV1LwD c2/Aeo2ImBQ6Hnk7Jmb1KdeKnxS4Wo0oZ3Thb2Dgb5z5oL2n/3sPvcnmygZfj/pcDGre5zKj73g2e Q3YICiDvjWXbquEaumnoxd9iz4SaHqHQ9udA88p28ovPh9QyRC0fmY/LE7RdTOHV2hUN4wlcg4zYs ZS5jcLZY42Ia7kxdVFQoBq3sYlaYD8MM0bruJ758Jo70ikVlh+Is4kvMjoHQWvhjhRyZUyfbM1FkD dG7hFrbwhvQDW7KCgFgR6K5r/eVs+++tfQERI7H6En9E3hKvo333Omt0pw0YOFgw4uhjDfAJ5CyMQ Xmge+3rg==; Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by merlin.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDmpj-0007cg-GO for linux-arm-kernel@lists.infradead.org; Fri, 27 Sep 2019 09:46:40 +0000 X-Originating-IP: 86.250.200.211 Received: from windsurf (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id DACC9E000D; Fri, 27 Sep 2019 09:45:55 +0000 (UTC) Date: Fri, 27 Sep 2019 11:45:55 +0200 From: Thomas Petazzoni To: Remi Pommarel Subject: Re: [PATCH v3] PCI: aardvark: Don't rely on jiffies while holding spinlock Message-ID: <20190927114555.193a9d68@windsurf> In-Reply-To: <20190927085502.1758-1-repk@triplefau.lt> References: <20190927085502.1758-1-repk@triplefau.lt> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Lorenzo Pieralisi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 27 Sep 2019 10:55:02 +0200 Remi Pommarel wrote: > advk_pcie_wait_pio() can be called while holding a spinlock (from > pci_bus_read_config_dword()), then depends on jiffies in order to > timeout while polling on PIO state registers. In the case the PIO > transaction failed, the timeout will never happen and will also cause > the cpu to stall. > > This decrements a variable and wait instead of using jiffies. > > Signed-off-by: Remi Pommarel Acked-by: Thomas Petazzoni Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel