From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36006C32792 for ; Mon, 30 Sep 2019 12:53:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0730E2054F for ; Mon, 30 Sep 2019 12:53:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m74MPF55" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0730E2054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Awz9IgoMw/5ZufxqTY30NdQVtScbnSKJ3GyBzJgv1Ps=; b=m74MPF55cvhBTo 1Xj3ux8YegAcMgHPFXvMC7P2fboXHzK+Tb4y+/D9URGggbZtT1X04bLOgS+VQwNYHWGKML/DIF0hH OLUfgiuLLpFr+BVx1NWqAnSyCGpjqYIGSiaB4fdKB4O1Tj1OVGYJcjfTkQYR4vaTIOhXLcfo35Glw zk+UFSE0O0ZIb4warsYs7CuVW0Z99LCfhJPrHn7scURHka7LPhpmMK1CiRdFuaIZf1euBrZS32YZf Jh/UySqCjxyLIV51Zbqo4lrJu3/X7+pf6O8cvqvuOFXeu9Ng4AKedXx+gts+INqz56RM0M36cFhWl a+eq1z+SW9fpzttXFqgw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iEvBS-0005ja-6Q; Mon, 30 Sep 2019 12:53:46 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92.2 #3 (Red Hat Linux)) id 1iEvBP-0005jM-NT; Mon, 30 Sep 2019 12:53:43 +0000 Date: Mon, 30 Sep 2019 05:53:43 -0700 From: Christoph Hellwig To: Rob Herring Subject: Re: [PATCH 02/11] of: Make of_dma_get_range() private Message-ID: <20190930125343.GB12051@infradead.org> References: <20190927002455.13169-1-robh@kernel.org> <20190927002455.13169-3-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190927002455.13169-3-robh@kernel.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Florian Fainelli , Geert Uytterhoeven , Arnd Bergmann , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , linux-kernel@vger.kernel.org, Marek Vasut , Lorenzo Pieralisi , Oza Pawandeep , Stefan Wahren , Simon Horman , Frank Rowand , linux-arm-kernel@lists.infradead.org, Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > +#ifdef CONFIG_OF_ADDRESS > +extern int of_dma_get_range(struct device_node *np, u64 *dma_addr, > + u64 *paddr, u64 *size); No need for the extern here. Otherwise looks good: Reviewed-by: Christoph Hellwig _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel