From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE46C32792 for ; Mon, 30 Sep 2019 13:17:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9011720842 for ; Mon, 30 Sep 2019 13:17:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qpXvV3jQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K4Me9Abz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9011720842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G9i6HG7p1muChudRX5P8Bl908SM/tppysN4CljdqkH8=; b=qpXvV3jQRQt7xD HaurjCK1QOp9Y/aNTV8QnM+0sOTh45veeW7pBx6VlpD2jinOXuY9dKnUQeNpFPHbDV7DNkSyygf70 wkbUB7BPNGkjIMMZQFcN6Fr3VYWuO4mdnJMYuXELCnBB50tb8g6a2N0bVNyLEJeZ64verMigE6oXT +3+n527UDvKBSOW1KadhQXg1HcKYbrbjjpyVoNv/+qTS/ekQ/A7iVBYUDB7Gz2vlHGKPvvR6MDG7f mYBR/69WHrLcth7IpqDUSO1zMPBNWbfN4X/ytSk74wBTgfOOPfpRviTTJfeAti8o1V3brres2CSUQ wqFgxeSoHfFJoXbiJFHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iEvYY-0001Kq-Cm; Mon, 30 Sep 2019 13:17:38 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iEvYU-0001JM-5l for linux-arm-kernel@lists.infradead.org; Mon, 30 Sep 2019 13:17:36 +0000 Received: by mail-pf1-x443.google.com with SMTP id q7so5600853pfh.8 for ; Mon, 30 Sep 2019 06:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lyjxLghcbPT/guXD86JE2tkfP9LwZRh+SOW/3r4IE0k=; b=K4Me9AbzWb0e36PT1RsITpHnGoILWsd5427QwnSCROrxI8VBVpspAQ6nRIzi7NA8Yn 57ZD4FqtDnmz5HuabUkCGTso9R7y3I8Vm6mJjZjQR4uJkiflPUKE9KV9JDxz4Ibnuj9P K6HdrGOHt2e2MLp8rdaATbgAkLHOwXs6LjtqzM6F4yYSzTZBR6cGMda/6TqP3Iwssc4f 8EJnd0XT1F73jg0qhZFLTU5EX3Tyrpo//WWQDII+o0x1o+fGsuyi/OrEXu6swwTKEnSn w9s15QoapIOOScFiVI+HgZskTz/+kFV72evMnMH6eKX9cE8Q0GF+CsSkTf6OHKz0BcEM OTkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=lyjxLghcbPT/guXD86JE2tkfP9LwZRh+SOW/3r4IE0k=; b=LiqrcLSYbAQxNeqCsRKRlCg/7UYacUiaPl4qSNXzh9EctYw2wWBB0xm9/WQaIWlyZS 6BmXCEMwPhHq3ZBl/4ZSDZ6BK6af+9jG5QMUmsodXrWbQGxrLu4NnIXTALeR/25EGz6H OF4qonPTikomTfOCyxwmEhpHQ28u9S1l0fia76+iNGSlBrwRafDqF9unSH/i26JcjS2B rftv6CC5WU7lxfeGTFrHHI3T1L6xSWW2m3cpYbHXS76A+l4oFXSPmGgMdtgHmmfuTWyq es0cdFzwhnnc2HIjSsnRQoebbnvp7cu6hv/+oZYPhWn4QeUQllx1LiqLmx6CUqFIPoDG kNBw== X-Gm-Message-State: APjAAAX0EfuH4vkrLamKJtYiFG8Zv7vIeFhHtC6jr4bJJPleQAdzqOtN q++RTz5p7K4Pex9a5NY1CDM= X-Google-Smtp-Source: APXvYqw2pu0gcwNDmR9jMGGlX/s5QhDeUO87p2+wVCm/9EfBUDnUV9c1aZTkY/ExoTEP0eKPr2VX5Q== X-Received: by 2002:a63:d05:: with SMTP id c5mr23721805pgl.182.1569849453673; Mon, 30 Sep 2019 06:17:33 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id n3sm10936090pff.102.2019.09.30.06.17.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Sep 2019 06:17:33 -0700 (PDT) Date: Mon, 30 Sep 2019 06:17:32 -0700 From: Guenter Roeck To: Anson Huang Subject: Re: [PATCH 2/3] watchdog: imx2_wdt: Use __maybe_unused instead of #if CONFIG_PM_SLEEP Message-ID: <20190930131732.GB29750@roeck-us.net> References: <1569308828-8320-1-git-send-email-Anson.Huang@nxp.com> <1569308828-8320-2-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1569308828-8320-2-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190930_061734_216307_8C504A8B X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-watchdog@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, Linux-imx@nxp.com, kernel@pengutronix.de, wim@linux-watchdog.org, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 24, 2019 at 03:07:07PM +0800, Anson Huang wrote: > Use __maybe_unused for power management related functions instead > of #if CONFIG_PM_SLEEP to simply the code. > > Signed-off-by: Anson Huang Reviewed-by: Guenter Roeck > --- > drivers/watchdog/imx2_wdt.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c > index 6711b4e..034f32c 100644 > --- a/drivers/watchdog/imx2_wdt.c > +++ b/drivers/watchdog/imx2_wdt.c > @@ -358,9 +358,8 @@ static void imx2_wdt_shutdown(struct platform_device *pdev) > } > } > > -#ifdef CONFIG_PM_SLEEP > /* Disable watchdog if it is active or non-active but still running */ > -static int imx2_wdt_suspend(struct device *dev) > +static int __maybe_unused imx2_wdt_suspend(struct device *dev) > { > struct watchdog_device *wdog = dev_get_drvdata(dev); > struct imx2_wdt_device *wdev = watchdog_get_drvdata(wdog); > @@ -381,7 +380,7 @@ static int imx2_wdt_suspend(struct device *dev) > } > > /* Enable watchdog and configure it if necessary */ > -static int imx2_wdt_resume(struct device *dev) > +static int __maybe_unused imx2_wdt_resume(struct device *dev) > { > struct watchdog_device *wdog = dev_get_drvdata(dev); > struct imx2_wdt_device *wdev = watchdog_get_drvdata(wdog); > @@ -406,7 +405,6 @@ static int imx2_wdt_resume(struct device *dev) > > return 0; > } > -#endif > > static SIMPLE_DEV_PM_OPS(imx2_wdt_pm_ops, imx2_wdt_suspend, > imx2_wdt_resume); > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel