Re: [PATCH v2 2/3] ARM: dts: add Netronix E60K02 board common file

Andreas Kemnade
2019-10-07T05:48:44Z

[-- Attachment #1.1: Type: text/plain, Size: 2242 bytes --]

Hi Jonathan,

On Mon, 7 Oct 2019 00:38:48 +0200
Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:

> Thanks for CCing me on this patchset. Nice to see more e-book reader
> related work!
>
> A few comments and questions below.
>
> On Mon, Sep 30, 2019 at 09:43:31PM +0200, Andreas Kemnade wrote:
> > The Netronix board E60K02 can be found some several Ebook-Readers,
> > at least the Kobo Clara HD and the Tolino Shine 3. The board
> > is equipped with different SoCs requiring different pinmuxes.
>
> Do I understand it correctly that i.MX6SL and i.MX6SLL are pin-
> compatible so we can use the same pin numbers and GPIO handles in the
> DT?
>
Yes, for that purpose yes, The i.MX6SL has more functions than the i.MX6SLL,
which you will of course not find on the SLL pins.

> > + leds {
> > + compatible = "gpio-leds";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_led>;
> > +
> > + GLED {
>
> What does "GLED" mean? It's not obvious to me.
> What user-visible purpose does this LED have, or where is it on the
> board?
>
It is on the power key. So probably we could have "power" in its name.
GLED is just the name in vendors uboot and kernel.

I use that led also as an output in uboot to have multiboot between
vendor system, vendor kernel +debian system and patched mainline + debian system.

> > + gpios = <&gpio5 7 GPIO_ACTIVE_LOW>;
> > + linux,default-trigger = "timer";
> > + };
> > + };
> > +
> > + memory {
> > + reg = <0x80000000 0x80000000>;
>
> 2 GiB of memory?
>
Well, 512MByte. Seems that uboot overwrites that. But we should use the correct
value here.

> > + /* Core3_3V3 */
>
> What are these labels (Core3_3V3, Core4_1V2, etc.)?
>
I have taken then from the tolino board file. Probably they are netnames
of the pcb but not the names of the regulators in the pmic.

> > + dcdc2_reg: DCDC2 {
> > + regulator-name = "DCDC2";
> > + regulator-always-on;
> > + regulator-boot-on;
> > + regulator-state-mem {
> > + regulator-on-in-suspend;
> > + regulator-suspend-max-microvolt = <3300000>;
> > + regulator-suspend-min-microvolt = <3300000>;
> > + };
> > + };
>
Regards,
Andreas

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]