From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: simplify syscall wrapper ifdeffery
Date: Tue, 1 Oct 2019 17:02:39 +0100 [thread overview]
Message-ID: <20191001160239.GP41399@arrakis.emea.arm.com> (raw)
In-Reply-To: <20190913125550.7053-1-mark.rutland@arm.com>
On Fri, Sep 13, 2019 at 01:55:50PM +0100, Mark Rutland wrote:
> Back in commit:
>
> 4378a7d4be30ec69 ("arm64: implement syscall wrappers")
>
> ... I implemented the arm64 syscall wrapper glue following the approach
> taken on x86. While doing so, I also copied across some ifdeffery that
> isn't necessary on arm64.
>
> On arm64 we don't share any of the native wrappers with compat tasks,
> and unlike x86 we don't have alternative implementations of
> SYSCALL_DEFINE0(), COND_SYSCALL(), or SYS_NI() defined when AArch32
> compat support is enabled.
>
> Thus we don't need to prevent multiple definitions of these macros, and
> can remove the #ifndef ... #endif guards protecting them. If any of
> these had been previously defined elsewhere, syscalls are unlikely to
> work correctly, and we'd want the compiler to warn about the multiple
> definitions.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
Queued for 5.5. Thanks.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-01 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 12:55 [PATCH] arm64: simplify syscall wrapper ifdeffery Mark Rutland
2019-10-01 12:57 ` Will Deacon
2019-10-01 16:02 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001160239.GP41399@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).