From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: avoid unused variable warning for rt5659_acpi_match
Date: Wed, 20 Jan 2016 11:58:51 +0100 [thread overview]
Message-ID: <20191003.vNJkcIvuCq@wuerfel> (raw)
In-Reply-To: <20160120104555.GY6588@sirena.org.uk>
On Wednesday 20 January 2016 10:45:55 Mark Brown wrote:
> On Wed, Jan 20, 2016 at 11:43:48AM +0100, Arnd Bergmann wrote:
> > The newly added rt5659 codec driver unconditionally defines an
> > ACPI device match table but then uses ACPI_PTR() to remove the
> > only reference to it, so we get a harmless build warning:
>
> > sound/soc/codecs/rt5659.c:4200:30: warning: 'rt5659_acpi_match' defined but not used [-Wunused-variable]
> > static struct acpi_device_id rt5659_acpi_match[] = {
>
> > This removes the ACPI_PTR() to avoid the warning.
>
> Why is this a better fix than conditionally defining the table?
I'm not overly fond of adding #ifdef if it can be avoided. In this case,
both approaches seemed reasonable (either add an #ifdef or waste a couple
of bytes), and I picked at random. I'll send you the alternative as well,
please apply whichever one you prefer.
Arnd
next prev parent reply other threads:[~2016-01-20 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 10:43 [PATCH] ASoC: avoid unused variable warning for rt5659_acpi_match Arnd Bergmann
2016-01-20 10:45 ` Mark Brown
2016-01-20 10:58 ` Arnd Bergmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-20 11:46 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003.vNJkcIvuCq@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox