From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 052E3C32792 for ; Thu, 3 Oct 2019 18:11:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D471E2086A for ; Thu, 3 Oct 2019 18:11:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WTZXL13R"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sTG8BoNG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D471E2086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zf30AFqdVsLFD+rO2UQg9hAzq920YsnbkGhTxuYDIzA=; b=WTZXL13RdffX+Y f/nVQLKen8ib4tA2OJdq1MwuPyuM8BJAXv2v/8J1IzqhWvDzuG3z5tkJ4Q3NjVWvX7C8EMnmNAnn1 Qe5OG6K+rs0umE6lhqb1bz10n9KRxjypQmbajoIO9ZpJelcwHjP5A0rAjpzh3xWvC+JJ2KL8I5/pQ vRdPALlpYGuhqr7bZD5xQkxGlQTNXBTS+l314CS86BWFMCtxMVBdwZ2SRiVEcBQ6Z/TAq49Lq4QY/ FweSPGusDXxYXjIfd5exLqNFgIXnmNOirgfSjFeKnbLur3RIsF9xze/ifqbJEZh+Y88oviQ4jm1ur Z6z00Io17oS8ucoeDw9g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iG5ZB-0001zx-BN; Thu, 03 Oct 2019 18:11:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iG5Z8-0001ym-TM; Thu, 03 Oct 2019 18:11:04 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 803B120862; Thu, 3 Oct 2019 18:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570126262; bh=aArKOWxO0UzBJPgQiYgtFIO0VS3NLn3FEgzr04GaghE=; h=In-Reply-To:References:From:To:Cc:Subject:Date:From; b=sTG8BoNGODYMJh9K8VdkTLOSAFtZXJXm0caFHt36ztIL/MBfhYfFtDzI1Oi6LU0sL O1j9gxbPlg8iCQnVT8pMZIipOVO2X+bRYi5fdMJLaH1XMsr/Tl3y6rf1l0WaJpLBh+ p2KCBMaJK91l7C6g24fwfoT8haHVbqLr8Dx8CycM= MIME-Version: 1.0 In-Reply-To: <1569553244-3165-3-git-send-email-zhangqing@rock-chips.com> References: <1569553244-3165-1-git-send-email-zhangqing@rock-chips.com> <1569553244-3165-3-git-send-email-zhangqing@rock-chips.com> From: Stephen Boyd To: Elaine Zhang , heiko@sntech.de Subject: Re: [PATCH v3 2/5] clk: rockchip: fix up the frac clk get rate error User-Agent: alot/0.8.1 Date: Thu, 03 Oct 2019 11:11:01 -0700 Message-Id: <20191003181102.803B120862@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191003_111102_968058_D513AED1 X-CRM114-Status: GOOD ( 12.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: huangtao@rock-chips.com, xf@rock-chips.com, mturquette@baylibre.com, Elaine Zhang , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org, xxx@rock-chips.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Elaine Zhang (2019-09-26 20:00:41) > support fractional divider with only one level parent clock Please put a lot more description in here. A single sentence doesn't help anyone understand the motivation for the change. > > Signed-off-by: Elaine Zhang > --- > drivers/clk/rockchip/clk.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c > index fac5a4a3f5c3..8f77c3f9fab7 100644 > --- a/drivers/clk/rockchip/clk.c > +++ b/drivers/clk/rockchip/clk.c > @@ -190,16 +190,21 @@ static void rockchip_fractional_approximation(struct clk_hw *hw, > if (((rate * 20 > p_rate) && (p_rate % rate != 0)) || > (fd->max_prate && fd->max_prate < p_rate)) { > p_parent = clk_hw_get_parent(clk_hw_get_parent(hw)); > - p_parent_rate = clk_hw_get_rate(p_parent); > - *parent_rate = p_parent_rate; > - if (fd->max_prate && p_parent_rate > fd->max_prate) { > - div = DIV_ROUND_UP(p_parent_rate, fd->max_prate); > - *parent_rate = p_parent_rate / div; > + if (!p_parent) { > + *parent_rate = p_rate; > + } else { > + p_parent_rate = clk_hw_get_rate(p_parent); > + *parent_rate = p_parent_rate; > + if (fd->max_prate && p_parent_rate > fd->max_prate) { > + div = DIV_ROUND_UP(p_parent_rate, > + fd->max_prate); > + *parent_rate = p_parent_rate / div; > + } > } > > if (*parent_rate < rate * 20) { > - pr_err("%s parent_rate(%ld) is low than rate(%ld)*20, fractional div is not allowed\n", > - clk_hw_get_name(hw), *parent_rate, rate); > + pr_warn("%s p_rate(%ld) is low than rate(%ld)*20, use integer or half-div\n", > + clk_hw_get_name(hw), *parent_rate, rate); Hm.. now it's changed to a warning? > *m = 0; > *n = 1; > return; > -- > 1.9.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel