From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 353E8C10F14 for ; Thu, 3 Oct 2019 20:26:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05A0D20862 for ; Thu, 3 Oct 2019 20:26:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LrDaZ+gk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="VVK3HtIf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05A0D20862 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wwcj4bSH7b9z7AuM4d1dQq2tN3rF/sTzd9v4+z8cK3s=; b=LrDaZ+gk4dM3Io Lo7TYum2Wy4E86Gin/9bL6kL5oQ4m8goon3Y2ABekv3a+q5GKhrOZnWC+GDM6+VbzYXc24Ys5gLm6 JKB9D9KElAEstEgkgUFY6lrrccVskRKPEo3VP5UwnderOqxm8mlDb+CXHYTrsFIjW9FAhw1rWOJjO 0pRVqTGOp6+oFLKGaKbl37IgPwiTSCFjKnuKgguV3cRf3SvpKVMgvHD9bInf2nooOC71Efhlk8X9E m8tI1UecVB3KdVC9BriASdI/fT/QKkU5fIvBDFW3VLLWf0cAqEQADPNirM9R9gr/7aOP8RPItZjOq 5LuQiiuFf83RvxfLbLhA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iG7gG-0004Rh-Ia; Thu, 03 Oct 2019 20:26:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iG7gE-0004Qs-6R for linux-arm-kernel@lists.infradead.org; Thu, 03 Oct 2019 20:26:31 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A2ABB20862; Thu, 3 Oct 2019 20:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570134387; bh=jFnbR5AMDd9ph3gWWRIGQf/AuwZ+qx+EEfIXSSgKEvE=; h=In-Reply-To:References:From:To:Cc:Subject:Date:From; b=VVK3HtIfxAnUqKczTjdKvK7SEdDp9rpAOnzBiCCqWdMQg/B+th7HzaDNExPinXFSj eFa2iUZXAXdxsLGZPULQw4XPD/lpHP8Alvc+6LasxLI0CK9llGRLCwO2+DiGRRladw S54vgwpqtDNHa/ta84AZuWFR2ahw45thPtmtPDeQ= MIME-Version: 1.0 In-Reply-To: <20191003201837.86824-1-swarren@wwwdotorg.org> References: <20191003201837.86824-1-swarren@wwwdotorg.org> From: Stephen Boyd To: Jonathan Hunter , Peter De Schrijver , Prashant Gaikwad , Stephen Warren , Thierry Reding Subject: Re: [PATCH V2 1/4] clk: tegra: mark fuse clock as critical User-Agent: alot/0.8.1 Date: Thu, 03 Oct 2019 13:26:26 -0700 Message-Id: <20191003202627.A2ABB20862@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191003_132630_260713_45FEF7AD X-CRM114-Status: UNSURE ( 8.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Michael Turquette , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Stephen Warren (2019-10-03 13:18:34) > diff --git a/drivers/clk/tegra/clk-tegra-periph.c b/drivers/clk/tegra/clk-tegra-periph.c > index 1ed85f120a1b..76dd91eebd13 100644 > --- a/drivers/clk/tegra/clk-tegra-periph.c > +++ b/drivers/clk/tegra/clk-tegra-periph.c > @@ -785,7 +785,7 @@ static struct tegra_periph_init_data gate_clks[] = { > GATE("ahbdma", "hclk", 33, 0, tegra_clk_ahbdma, 0), > GATE("apbdma", "pclk", 34, 0, tegra_clk_apbdma, 0), > GATE("kbc", "clk_32k", 36, TEGRA_PERIPH_ON_APB | TEGRA_PERIPH_NO_RESET, tegra_clk_kbc, 0), > - GATE("fuse", "clk_m", 39, TEGRA_PERIPH_ON_APB, tegra_clk_fuse, 0), > + GATE("fuse", "clk_m", 39, TEGRA_PERIPH_ON_APB, tegra_clk_fuse, CLK_IS_CRITICAL), Please comment in the code why it's critical so we don't have to dig through commit history to figure this out. > GATE("fuse_burn", "clk_m", 39, TEGRA_PERIPH_ON_APB, tegra_clk_fuse_burn, 0), > GATE("kfuse", "clk_m", 40, TEGRA_PERIPH_ON_APB, tegra_clk_kfuse, 0), > GATE("apbif", "clk_m", 107, TEGRA_PERIPH_ON_APB, tegra_clk_apbif, 0), _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel